Yannick, I agree, but I thought it was required for OCA modules - I can't
remember why I assumed that, maybe read it in some guide somewhere.
I'll fix it.
--
https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date/+merge/211374
Your team Purchase Core
Here is the reference for this community Guideline.
https://doc.openerp.com/contribute/05_developing_modules/#modules-description
This has the advantage to show who contributed directly on apps.odoo.com as we
don't have such field in manifest.
--
I moved the crediting to a comment in __openerp__.py, is it right?
--
https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date/+merge/211374
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.
--
Mailing list:
Here is an exemple:
http://bazaar.launchpad.net/~report-print-send-core-editors/report-print-send/7.0/view/head:/base_report_to_printer/__openerp__.py
--
https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date/+merge/211374
Your team Purchase Core Editors
I think it's fixed now.
--
https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date/+merge/211374
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Approve code review, no test
Perfect, thanks for the changes Lionel
--
https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date/+merge/211374
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.
--
Mailing list:
Review: Needs Fixing
Please don't add AUTHOR.txt file and add Contributors in __openerp__.py
For who did exaclty what there is the CVS
--
https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date/+merge/211374
Your team Purchase Core Editors is subscribed
Thanks Joël, I've updated the module as you suggested.
--
https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date/+merge/211374
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.
--
Mailing list:
Review: Approve code review
--
https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date/+merge/211374
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to
Review: Needs Fixing code review, no tests
Hi Lionel,
Thanks for the contrib ! A few remarks concerning community guideline:
* L32 : use from . import purchase
* L95 : use full path instead : from openerp.osv import orm
* L114 : use let a print, remove it please
Otherwise, LGTM,
Regards,
Review: Approve code review
--
https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date/+merge/211374
Your team Purchase Core Editors is requested to review the proposed merge of
lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date
11 matches
Mail list logo
