Review: Approve code review
As itself base_delivery_carrier_label module only provide an interface class,
this method here makes sense.
LGTM
--
https://code.launchpad.net/~akretion-team/carriers-deliveries/7-base-delivery-carrier-dbl/+merge/221226
Your team Stock and Logistic Core Editors is su
This has been fixed by Pedro, some revision were overwritten last week and are
now back in OCB.
Thanks for noticing it Stéphane
--
https://code.launchpad.net/~camptocamp/account-financial-report/7.0-sync-afr_webkit-with-report_webkit/+merge/223058
Your team Account Report Core Editors is subscri
Review: Approve test, review
As it's a small abstract feature, I think it make sense to create a helper
module for all similary one. The aim is just to have one module which is a
toolbox with all abstract feature (not user feature) that can be use everythere.
Description is clear now so I approv
Review: Approve
LGTM, I agree too. It's only an abstract module that provider a standard API
for real implementation
--
https://code.launchpad.net/~akretion-team/carriers-deliveries/7-base-delivery-carrier-dbl/+merge/221226
Your team Stock and Logistic Core Editors is subscribed to branch
lp:ca
Hello,
Thanks for the Review, I have test on customer branches instead of a fresh one
(bad idea).
I have fixed according to your review and test it on a fresh instance.
Sorry for the mistake.
Vincent
--
https://code.launchpad.net/~camptocamp/sale-reports/vre-sale_order_proformat/+merge/2235
Review: Approve code review
OK, I see. Thanks for the clarification.
I approve it and proceed with the merge.
Regards.
--
https://code.launchpad.net/~akretion-team/carriers-deliveries/7-base-delivery-carrier-dbl/+merge/221226
Your team Stock and Logistic Core Editors is subscribed to branch
lp
The proposal to merge
lp:~akretion-team/carriers-deliveries/7-base-delivery-carrier-dbl into
lp:carriers-deliveries has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~akretion-team/carriers-deliveries/7-base-delivery-carrier-dbl/+merge/221226
Review: Needs Fixing code review and test
Thanks for the changes, Vincent. Now it works as intended. Only one last fix:
please put at the end of the mako file this:
%if inv != objects[-1]:
%endif
That is because depending on the wkhtmltopdf version, you get an extra blank
page at the end.
Review: Needs Fixing code review
OK, let's use this module as is as an umbrella for future partner related
functionality.
One last thing: please rename to base_partner_helper to match current
convention on naming (Odoo is talking even to create a base_partner split from
base module).
Regards.
The proposal to merge lp:~camptocamp/sale-wkfl/7.0-add-last_sale_price-yvr into
lp:sale-wkfl has been updated.
Description changed to:
Add a module to show last price defined for customer on sale order line
For more details, see:
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-add-last_sal
Yannick Vaucher @ Camptocamp has proposed merging
lp:~camptocamp/sale-wkfl/7.0-add-last_sale_price-yvr into lp:sale-wkfl.
Commit message:
[ADD] module last_sale_price - This module provides new columns in sale order
line in order to let the sellerman know if a customer already ordrered a product
Vincent Renaville@camptocamp has proposed merging
lp:~camptocamp/account-budgeting/vre-budget-responsible-group into
lp:account-budgeting.
Requested reviews:
Account Core Editors (account-core-editors)
For more details, see:
https://code.launchpad.net/~camptocamp/account-budgeting/vre-budget-
Review: Needs Information code review
Don't you think it's better to put the group in any category?
Regards.
--
https://code.launchpad.net/~camptocamp/account-budgeting/vre-budget-responsible-group/+merge/223705
Your team Account Core Editors is subscribed to branch lp:account-budgeting.
--
Ma
Hello,
Many thanks for the review and the fix suggestion , I was not aware of it.
I have push a version according to your last review.
thanks for your help,
Vincent
--
https://code.launchpad.net/~camptocamp/sale-reports/vre-sale_order_proformat/+merge/223563
Your team OpenERP Community Review
Review: Needs Fixing
l63 sellerman -> salesman
l63 ordrer -> ordered
hint of -> a hint about
those information -> that information
in sale -> in the sale
Thanks for the review.
I just fixed the __openerp__.py
--
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-add-last_sale_price-yvr/+merge/223704
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Approve code review and test
Thanks for the changes!
Regards.
--
https://code.launchpad.net/~camptocamp/sale-reports/vre-sale_order_proformat/+merge/223563
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:sale-reports.
--
Mailing list: https://launchpad.net/~
Yannick, you need to save the sales order to see the prices. That seems a
usability issue.
I'm not sure that we can deal with that properly with onchanges though.
--
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-add-last_sale_price-yvr/+merge/223704
Your team Sale Core Editors is subscribe
Review: Approve
Thanks Yannick.
I agree with Guewen an onchange would be a better UI, but I'm not blocking on
this.
--
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-add-last_sale_price-yvr/+merge/223704
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
--
Mailing list:
Yannick Vaucher @ Camptocamp has proposed merging
lp:~camptocamp/ocb-addons/7.0-fix-github-650 into lp:ocb-addons.
Requested reviews:
OpenERP Community Backports (ocb)
For more details, see:
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-github-650/+merge/223727
Official MP is ther
Review: Approve
LGTM
--
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-github-650/+merge/223727
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lis
Review: Approve
+1
--
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-github-650/+merge/223727
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists
The proposal to merge
lp:~therp-nl/partner-contact-management/7.0_partner_relations into
lp:partner-contact-management has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~therp-nl/partner-contact-management/7.0_partner_relations/+merge/223734
The proposal to merge
lp:~therp-nl/partner-contact-management/7.0_partner_relations into
lp:partner-contact-management has been updated.
Status: Merged => Needs review
For more details, see:
https://code.launchpad.net/~therp-nl/partner-contact-management/7.0_partner_relations/+merge/223734
Sorry Alexis for my late reply! Meanwhile, we added quite a bit to our approach
to partner relations, so I made an alternative MP:
https://code.launchpad.net/~therp-nl/partner-contact-management/7.0_partner_relations/+merge/223734
The differences are: We use views to duplicate data instead of co
David BEAL (ak) has proposed merging
lp:~akretion-team/sale-wkfl/7.0-addmulticpny-sale-except-module-dbl into
lp:sale-wkfl.
Requested reviews:
Sale Core Editors (sale-core-editors)
For more details, see:
https://code.launchpad.net/~akretion-team/sale-wkfl/7.0-addmulticpny-sale-except-module-d
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~akretion-team/sale-wkfl/7.0-addmulticpny-sale-except-module-dbl/+merge/223750
Your team Sale Core Editors is requested to review the proposed merge of
lp:~akretion-team/sale-wkfl/7.0-addmulticpny-sale-except-module-dbl int
Hello,
Thanks for your review !
After discussion I have put the Category : Accounting And Finance
Vincent
--
https://code.launchpad.net/~camptocamp/account-budgeting/vre-budget-responsible-group/+merge/223705
Your team Account Core Editors is subscribed to branch lp:account-budgeting.
--
Maili
Review: Needs Fixing code review
Hi Vincent,
I'm not sure but I think it's better to put ## -*- coding: utf-8 -*- at the
start of mako file.
other small things:
l.10,36 : comma is misplaced between our 2 names
l.62 : s/base_header_webkit/base_headers_webkit
Thanks for porting this addon here,
Lorenzo Battistini - Agile BG has proposed merging
lp:~agilebg/account-invoice-report/7_fix_1221570 into lp:account-invoice-report.
Requested reviews:
Account Core Editors (account-core-editors)
Related bugs:
Bug #1221570 in Account - Invoicing Reports: "[7.0] invoice_webkit overwrites
repor
The proposal to merge lp:~agilebg/sale-reports/7_fix_1315445 into
lp:sale-reports has been updated.
Description changed to:
Same as
https://code.launchpad.net/~agilebg/account-invoice-report/7.0-fix_invoice_webkit_description_bugs/+merge/205204
For more details, see:
https://code.launchpad.net
Lorenzo Battistini - Agile BG has proposed merging
lp:~agilebg/sale-reports/7_fix_1315445 into lp:sale-reports.
Requested reviews:
Sale Core Editors (sale-core-editors)
Related bugs:
Bug #1315445 in Sales - Reports: "[7.0] sale_order_webkit - 'Description'
field overlaps the next one 'Qty' w
Lorenzo Battistini - Agile BG has proposed merging
lp:~agilebg/purchase-report/7_fix_1331394 into lp:purchase-report.
Requested reviews:
Purchase Core Editors (purchase-core-editors)
Related bugs:
Bug #1331394 in Purchase - Reports: "[7.0] purchase_order_webkit -
'Description' field overlaps
Review: Approve code review
Thanks for the change.
Regards.
--
https://code.launchpad.net/~camptocamp/account-budgeting/vre-budget-responsible-group/+merge/223705
Your team Account Core Editors is subscribed to branch lp:account-budgeting.
--
Mailing list: https://launchpad.net/~openerp-commun
Review: Approve code review
LGTM
--
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-github-650/+merge/223727
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-
Review: Needs Fixing code review
Please update pot file.
The rest LGTM.
Regards.
--
https://code.launchpad.net/~akretion-team/sale-wkfl/7.0-addmulticpny-sale-except-module-dbl/+merge/223750
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
--
Mailing list: https://launchpad.ne
Review: Needs Fixing code review
Another thing: please comply with 80 cols PEP8.
Regards.
--
https://code.launchpad.net/~akretion-team/sale-wkfl/7.0-addmulticpny-sale-except-module-dbl/+merge/223750
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
--
Mailing list: https://laun
Review: Approve code review
LGTM
--
https://code.launchpad.net/~agilebg/account-invoice-report/7_fix_1221570/+merge/223781
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-invoice-report.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post
Looking a lot better, still issues about the comments preceding functions which
would be more useful as docstrings.
Diff comments:
> === added directory 'cmis'
> === added file 'cmis/__init__.py'
> --- cmis/__init__.py 1970-01-01 00:00:00 +
> +++ cmis/__init__.py 2014-06-12 19:47:23 +
Review: Approve
Looking better
--
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_read/+merge/212260
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:knowledge-addons/7.0.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Po
You have been requested to review the proposed merge of
lp:~savoirfairelinux-openerp/knowledge-addons/cmis_read into
lp:knowledge-addons/7.0.
For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_read/+merge/212260
Add cmis_read; It allows to use the
Review: Approve
--
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_read/+merge/212260
Your team OpenERP Community Reviewer/Maintainer is requested to review the
proposed merge of lp:~savoirfairelinux-openerp/knowledge-addons/cmis_read into
lp:knowledge-addons/7.0.
-
Review: Approve code review
LGTM
--
https://code.launchpad.net/~agilebg/purchase-report/7_fix_cannot_import_name_purchase_order/+merge/223531
Your team Purchase Core Editors is subscribed to branch lp:purchase-report.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to
The proposal to merge
lp:~agilebg/purchase-report/7_fix_cannot_import_name_purchase_order into
lp:purchase-report has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~agilebg/purchase-report/7_fix_cannot_import_name_purchase_order/+merge/223531
44 matches
Mail list logo
