[Openerp-community-reviewer] [Bug 1190236] Re: Kanban view doesn't show constraint error message

2014-04-22 Thread Alexandre Fayolle - camptocamp
** Also affects: ocb-web Importance: Undecided Status: New ** Also affects: ocb-web/7.0 Importance: Undecided Status: New -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is subscribed to OpenERP Community Backports

[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-web/7.0-fix_1190236_opw-595981-msh into lp:ocb-web

2014-04-22 Thread Alexandre Fayolle - camptocamp
Alexandre Fayolle - camptocamp has proposed merging lp:~camptocamp/ocb-web/7.0-fix_1190236_opw-595981-msh into lp:ocb-web. Requested reviews: OpenERP Community Backports Team (ocb) Related bugs: Bug #1190236 in OpenERP Community Backports (Web): Kanban view doesn't show constraint error

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-web/7.0-fix_1190236_opw-595981-msh into lp:ocb-web

2014-04-22 Thread Pedro Manuel Baeza
Review: Approve code review LGTM. Regards. -- https://code.launchpad.net/~camptocamp/ocb-web/7.0-fix_1190236_opw-595981-msh/+merge/216664 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-web. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-web/7.0-fix_1190236_opw-595981-msh into lp:ocb-web

2014-04-22 Thread Leonardo Pistone - camptocamp
Review: Approve code review thanks -- https://code.launchpad.net/~camptocamp/ocb-web/7.0-fix_1190236_opw-595981-msh/+merge/216664 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-web. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-tools/account_partner_required-sbi into lp:account-financial-tools

2014-04-22 Thread Lorenzo Battistini - Agile BG
Review: Needs Information Hello Stéphane, why not using '_constraints' member instead of overriding create and write methods? Is there any technical reason to avoid YAML tests? Thanks! --

Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/web-addons/web_easy_switch_company-userform-fix-sbi into lp:web-addons

2014-04-22 Thread arthru
Review: Approve code review -- https://code.launchpad.net/~acsone-openerp/web-addons/web_easy_switch_company-userform-fix-sbi/+merge/216170 Your team Web-Addons Core Editors is subscribed to branch lp:web-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/web-addons/bug-1303944-sbi into lp:web-addons

2014-04-22 Thread arthru
Review: Approve tested Tested with admin and non admin users. -- https://code.launchpad.net/~acsone-openerp/web-addons/bug-1303944-sbi/+merge/216422 Your team Web-Addons Core Editors is requested to review the proposed merge of lp:~acsone-openerp/web-addons/bug-1303944-sbi into lp:web-addons.

Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/web-addons/bug-1303944-sbi into lp:web-addons

2014-04-22 Thread Acsone
Note: logos do not display correctely, and, as far as I can tell, there is no way to make this work with the default record rule. -- https://code.launchpad.net/~acsone-openerp/web-addons/bug-1303944-sbi/+merge/216422 Your team Web-Addons Core Editors is requested to review the proposed merge of

[Openerp-community-reviewer] [Bug 1309105] Re: stock.picking.out group by in multi companies

2014-04-22 Thread Yannick Vaucher @ Camptocamp
** Also affects: ocb-addons Importance: Undecided Status: New ** Also affects: ocb-addons/7.0 Importance: Undecided Status: New ** Changed in: ocb-addons/7.0 Status: New = Fix Committed -- You received this bug notification because you are a member of OpenERP

[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1309105 into lp:ocb-addons

2014-04-22 Thread Yannick Vaucher @ Camptocamp
Yannick Vaucher @ Camptocamp has proposed merging lp:~camptocamp/ocb-addons/7.0-fix-1309105 into lp:ocb-addons. Requested reviews: OpenERP Community Backports Team (ocb) Related bugs: Bug #1309105 in OpenERP Community Backports (Addons): stock.picking.out group by in multi companies

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/ocb-7.0-fix_1311004_account_move_line_index-afe into lp:ocb-addons

2014-04-22 Thread Guewen Baconnier @ Camptocamp
Review: Approve code review LGTM -- https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_1311004_account_move_line_index-afe/+merge/216686 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list:

[Openerp-community-reviewer] [Bug 1311004] Re: missing database index on account_move_line(date, id)

2014-04-22 Thread Guewen Baconnier @ Camptocamp
** Also affects: ocb-addons Importance: Undecided Status: New ** Also affects: ocb-addons/6.1 Importance: Undecided Status: New ** Also affects: ocb-addons/7.0 Importance: Undecided Status: New ** Changed in: ocb-addons/6.1 Status: New = Fix Committed **

[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/ocb-7.0-fix_1311004_account_move_line_index-afe into lp:ocb-addons

2014-04-22 Thread Alexandre Fayolle - camptocamp
Alexandre Fayolle - camptocamp has proposed merging lp:~camptocamp/ocb-addons/ocb-7.0-fix_1311004_account_move_line_index-afe into lp:ocb-addons. Requested reviews: Guewen Baconnier @ Camptocamp (gbaconnier-c2c): code review Related bugs: Bug #1311004 in OpenERP Community Backports

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/ocb-7.0-fix_1311004_account_move_line_index-afe into lp:ocb-addons

2014-04-22 Thread Pedro Manuel Baeza
Review: Approve code review LGTM. Regards. -- https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_1311004_account_move_line_index-afe/+merge/216686 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/ocb-7.0-fix_1311004_account_move_line_index-afe into lp:ocb-addons

2014-04-22 Thread Acsone
Review: Approve code review LGTM -- https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_1311004_account_move_line_index-afe/+merge/216686 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list:

[Openerp-community-reviewer] [Merge] lp:~openerp-community/openerp-canada/7.0-l10n_ca_account_check_writing into lp:openerp-canada

2014-04-22 Thread Vincent Vinet
The proposal to merge lp:~openerp-community/openerp-canada/7.0-l10n_ca_account_check_writing into lp:openerp-canada has been updated. Description changed to: Modify the l10n_ca_account_check_writing module pdf reports to also show credit lines for a voucher. Also fix a str being used instead

[Openerp-community-reviewer] [Bug 1254631] Re: No bank account on invoice when invoicing a contact

2014-04-22 Thread Pedro Manuel Baeza
** Branch linked: lp:~pedro.baeza/ocb-addons/fix-lp_1254631 ** Also affects: ocb-addons Importance: Undecided Status: New ** Also affects: ocb-addons/7.0 Importance: Undecided Status: New ** Changed in: ocb-addons/7.0 Status: New = Fix Committed ** Changed in:

[Openerp-community-reviewer] Invitation to openerp-community-reviewer accepted by jgrandguillaume-c2c

2014-04-22 Thread OpenERP data files editors
Hello OpenERP Community Reviewer/Maintainer, Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) has accepted the invitation to make OpenERP Community Reviewer/Maintainer (openerp- community-reviewer) a member of OpenERP data files editors (openerp- data-editors).

[Openerp-community-reviewer] [Merge] lp:~pedro.baeza/ocb-addons/fix-lp_1254631 into lp:ocb-addons

2014-04-22 Thread Pedro Manuel Baeza
Pedro Manuel Baeza has proposed merging lp:~pedro.baeza/ocb-addons/fix-lp_1254631 into lp:ocb-addons. Requested reviews: OpenERP Community Backports Team (ocb) Related bugs: Bug #1254631 in OpenERP Community Backports (Addons): No bank account on invoice when invoicing a contact

[Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep into lp:purchase-wkfl

2014-04-22 Thread Leonardo Pistone - camptocamp
Leonardo Pistone - camptocamp has proposed merging lp:~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep into lp:purchase-wkfl. Requested reviews: Purchase Core Editors (purchase-core-editors) For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/ocb-7.0-fix_1311004_account_move_line_index-afe into lp:ocb-addons

2014-04-22 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, no test -- https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_1311004_account_move_line_index-afe/+merge/216686 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep into lp:purchase-wkfl

2014-04-22 Thread Pedro Manuel Baeza
Review: Needs Information Hi, Leonardo, very good workaround, but I think it deserves to propose this change to 7.0/trunk official branches instead of a module, so that we don't have to update module with each change/fix made in the replaced part. It doesn't imply changes in DB layout, so it

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep into lp:purchase-wkfl

2014-04-22 Thread Leonardo Pistone - camptocamp
Hi Pedro. For trunk, I am actually going to propose it in the official branches tomorrow. See lp:~camptocamp/openobject-addons/trunk-refactor-po-merge-lep For 7.0, I thought it would be easier to do an extra module. Thanks! --

[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact into lp:partner-contact-management

2014-04-22 Thread Sandy Carter (http://www.savoirfairelinux.com)
You have been requested to review the proposed merge of lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact into lp:partner-contact-management. For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~vauxoo/web-addons/7.0-web_hideleftmenu into lp:web-addons

2014-04-22 Thread Pedro Manuel Baeza
Review: Needs Fixing code review Hi, Oscar, thanks for the MP. Could you please clean MP with only the module web_hideleftmenu? Regards. -- https://code.launchpad.net/~vauxoo/web-addons/7.0-web_hideleftmenu/+merge/216796 Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.

Re: [Openerp-community-reviewer] [Merge] lp:~vauxoo/web-addons/7.0-web_hideleftmenu into lp:web-addons

2014-04-22 Thread OscarAlca
Review: Disapprove Hello Pedro, Im sorry about this MP, I was making a merge on our own dev branches and wrongly sent the MP to web_addons, please skip this MP, sorry for the inconvenience -- https://code.launchpad.net/~vauxoo/web-addons/7.0-web_hideleftmenu/+merge/216796 Your team Web-Addons