[Openerp-community-reviewer] [Merge] lp:~akretion-team/server-env-tools/module-configuration-helper-dbl into lp:server-env-tools

2014-05-21 Thread David BEAL
David BEAL has proposed merging lp:~akretion-team/server-env-tools/module-configuration-helper-dbl into lp:server-env-tools. Commit message: [ADD] module configuration_helper Requested reviews: Server Environment And Tools Core Editors (server-env-tools-core-editors) For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1319109 into lp:ocb-addons

2014-05-21 Thread Leonardo Pistone - camptocamp
Review: Approve LGTM -- https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1319109/+merge/219473 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

Re: [Openerp-community-reviewer] [Openerp-community] OCA LP Project migration to Github

2014-05-21 Thread Joël Grand-Guillaume
Dear community, Here is a Trello board to help us organize tasks of each of us for this migration : https://trello.com/b/JFEZglXl/moving-oca-to-github I already started. He's public to read, only members can write/create. I currently added/invited some of you to it, please just ask if you

[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1319109 into lp:ocb-addons

2014-05-21 Thread Leonardo Pistone - camptocamp
The proposal to merge lp:~camptocamp/ocb-addons/7.0-fix-1319109 into lp:ocb-addons has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1319109/+merge/219473 --

[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1319095 into lp:ocb-addons

2014-05-21 Thread Leonardo Pistone - camptocamp
The proposal to merge lp:~camptocamp/ocb-addons/7.0-fix-1319095 into lp:ocb-addons has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1319095/+merge/219476 --

[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1319095 into lp:ocb-addons

2014-05-21 Thread noreply
The proposal to merge lp:~camptocamp/ocb-addons/7.0-fix-1319095 into lp:ocb-addons has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1319095/+merge/219476 --

[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1319109 into lp:ocb-addons

2014-05-21 Thread noreply
The proposal to merge lp:~camptocamp/ocb-addons/7.0-fix-1319109 into lp:ocb-addons has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1319109/+merge/219473 --

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/server-env-tools/module-configuration-helper-dbl into lp:server-env-tools

2014-05-21 Thread Yannick Vaucher @ Camptocamp
Review: Needs Fixing test + code review Used it to create a config and works well. Code review l.161 + l.163 + l.172 please remove commented print line l.226 no need to quote me for this code I took it from addons/account/res_config.py --

[Openerp-community-reviewer] [Bug 1321675] [NEW] Server crash when copying one2many function field

2014-05-21 Thread Ronald Portier (Therp)
Public bug reported: Server crashes when copying the translations of a record that contains a - not stored - one2many function field. These fields should not have translations copied. Traceback (most recent call last): File /home/openeyedev/bzr/oe70/ocb-server/7.0/openerp/netsvc.py, line 296,

[Openerp-community-reviewer] [Bug 1319109] Re: webkit_report - webkit parser is not thread safe because of attribute parser_instance

2014-05-21 Thread Yannick Vaucher @ Camptocamp
** Changed in: ocb-addons/7.0 Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of OpenERP Community Backports, which is subscribed to OpenERP Community Backports (Addons). https://bugs.launchpad.net/bugs/1319109 Title: webkit_report -

[Openerp-community-reviewer] [Bug 1290820] Re: report_webkit not thread-safe: risk of document corruption

2014-05-21 Thread Yannick Vaucher @ Camptocamp
** Changed in: ocb-addons/7.0 Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of OpenERP Community Backports, which is subscribed to OpenERP Community Backports (Addons). https://bugs.launchpad.net/bugs/1290820 Title: report_webkit

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/server-env-tools/module-configuration-helper-dbl into lp:server-env-tools

2014-05-21 Thread David BEAL
@yannick I have fixed it. Your code gave me the idea to do this module, You have done an improvement revision 7 thanks to you -- https://code.launchpad.net/~akretion-team/server-env-tools/module-configuration-helper-dbl/+merge/220392 Your team Server Environment And Tools Core Editors is

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/server-env-tools/module-configuration-helper-dbl into lp:server-env-tools

2014-05-21 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review and test still you can remove l.223 Otherwise LGTM -- https://code.launchpad.net/~akretion-team/server-env-tools/module-configuration-helper-dbl/+merge/220392 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. --

[Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-server/7.0_lp1321675_crash_on_copy into lp:ocb-server

2014-05-21 Thread Ronald Portier (Therp)
Ronald Portier (Therp) has proposed merging lp:~therp-nl/ocb-server/7.0_lp1321675_crash_on_copy into lp:ocb-server. Requested reviews: OpenERP Community Backports (ocb) Related bugs: Bug #1321675 in OpenERP Community Backports (Server): Server crash when copying one2many function field

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/account-invoicing/7.0-account_cash_discount into lp:account-invoicing

2014-05-21 Thread Erwin van der Ploeg (BAS Solutions)
Hi Holger. I did some testing on the sales site and it looks ok - First of all you example is not correct, You say: On 01/20/2014, you charged EUR 80 to a customer, with 20% tax, totalling in EUR 100. If the amount is 80 and tax is 20%, then the total is 96,- - Second. In the Netherlands it is

[Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-warehouse/7.0-port-stock-orderpoint-creator-mdh into lp:stock-logistic-warehouse

2014-05-21 Thread Matthieu Dietrich @ camptocamp
Matthieu Dietrich @ camptocamp has proposed merging lp:~camptocamp/stock-logistic-warehouse/7.0-port-stock-orderpoint-creator-mdh into lp:stock-logistic-warehouse. Commit message: [IMP] 7.0 version of stock_orderpoint_creator Requested reviews: Stock and Logistic Core Editors

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoicing/adding_invoice_line_no_picking_name_7 into lp:account-invoicing

2014-05-21 Thread Lorenzo Battistini - Agile BG
Review: Approve code review -- https://code.launchpad.net/~agilebg/account-invoicing/adding_invoice_line_no_picking_name_7/+merge/220289 Your team Account Core Editors is requested to review the proposed merge of lp:~agilebg/account-invoicing/adding_invoice_line_no_picking_name_7 into

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-wkfl/imp_product_by_supplier into lp:purchase-wkfl

2014-05-21 Thread Lorenzo Battistini - Agile BG
Hello Pedro, just modified the name_search. Thanks -- https://code.launchpad.net/~agilebg/purchase-wkfl/imp_product_by_supplier/+merge/219017 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/hr-timesheet/imp_hr_attendance_analysis_roundings into lp:hr-timesheet

2014-05-21 Thread Lorenzo Battistini - Agile BG
Hello Pedro and Yannick, I made the changes. Thanks -- https://code.launchpad.net/~agilebg/hr-timesheet/imp_hr_attendance_analysis_roundings/+merge/206493 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:hr-timesheet. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/hr-timesheet/imp_hr_attendance_analysis_roundings into lp:hr-timesheet

2014-05-21 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, no test LGTM thanks! -- https://code.launchpad.net/~agilebg/hr-timesheet/imp_hr_attendance_analysis_roundings/+merge/206493 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:hr-timesheet. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/hr-timesheet/imp_hr_attendance_analysis_roundings into lp:hr-timesheet

2014-05-21 Thread Pedro Manuel Baeza
Review: Approve code review Thanks for the changes. Regards. -- https://code.launchpad.net/~agilebg/hr-timesheet/imp_hr_attendance_analysis_roundings/+merge/206493 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:hr-timesheet. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~echeverrifm/oemedical/oemedical_lab into lp:oemedical

2014-05-21 Thread Federico Manuel Echeverri Choux
This sentence seams wrong. l.64 Manager the request, creation and evaluation of laboratory analyses. Wouldn't this be better? : Manage request, creation and evaluation of laboratory analysis. Hello, Yannick It's better and done Regards --

[Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_journal_report_xls-namespace-extra into lp:account-financial-report

2014-05-21 Thread Luc De Meyer (Noviat)
Luc De Meyer (Noviat) has proposed merging lp:~luc-demeyer/account-financial-report/7.0-account_journal_report_xls-namespace-extra into lp:account-financial-report. Requested reviews: Account Report Core Editors (account-report-core-editor) For more details, see:

[Openerp-community-reviewer] [Merge] lp:~agilebg/hr-timesheet/imp_hr_attendance_analysis_roundings into lp:hr-timesheet

2014-05-21 Thread noreply
The proposal to merge lp:~agilebg/hr-timesheet/imp_hr_attendance_analysis_roundings into lp:hr-timesheet has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~agilebg/hr-timesheet/imp_hr_attendance_analysis_roundings/+merge/206493 --

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-wkfl/imp_product_by_supplier into lp:purchase-wkfl

2014-05-21 Thread Pedro Manuel Baeza
Review: Approve code review Thanks for the changes. Regards. -- https://code.launchpad.net/~agilebg/purchase-wkfl/imp_product_by_supplier/+merge/219017 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer

Re: [Openerp-community-reviewer] [Merge] lp:~echeverrifm/oemedical/oemedical_lab into lp:oemedical

2014-05-21 Thread Pedro Manuel Baeza
Review: Approve code review LGTM. Regards. -- https://code.launchpad.net/~echeverrifm/oemedical/oemedical_lab/+merge/205519 Your team OEmedical Commiter is subscribed to branch lp:oemedical. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :