Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/adding_account_invoice_production_lot_7 into lp:account-invoice-report

2014-01-02 Thread Nicola Malcontenti - Agile BG
Hello Maxime, i have removed the file and added the author to the module. Thanks. -- https://code.launchpad.net/~agilebg/account-invoice-report/adding_account_invoice_production_lot_7/+merge/191230 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report.

[Openerp-community-reviewer] [Merge] lp:~agilebg/sale-wkfl/adding_product_customer_code_sale_7 into lp:sale-wkfl

2014-01-21 Thread Nicola Malcontenti - Agile BG
Nicola Malcontenti - Agile BG has proposed merging lp:~agilebg/sale-wkfl/adding_product_customer_code_sale_7 into lp:sale-wkfl. Requested reviews: Sale Core Editors (sale-core-editors) For more details, see: https://code.launchpad.net/~agilebg/sale-wkfl/adding_product_customer_code_sale_7

[Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoicing/adding_product_customer_code_invoice into lp:account-invoicing

2014-01-21 Thread Nicola Malcontenti - Agile BG
Nicola Malcontenti - Agile BG has proposed merging lp:~agilebg/account-invoicing/adding_product_customer_code_invoice into lp:account-invoicing. Requested reviews: Account Core Editors (account-core-editors) For more details, see: https://code.launchpad.net/~agilebg/account-invoicing

[Openerp-community-reviewer] [Merge] lp:~agilebg/stock-logistic-flows/adding_product_customer_code_picking into lp:stock-logistic-flows

2014-01-21 Thread Nicola Malcontenti - Agile BG
Nicola Malcontenti - Agile BG has proposed merging lp:~agilebg/stock-logistic-flows/adding_product_customer_code_picking into lp:stock-logistic-flows. Requested reviews: Stock and Logistic Core Editors (stock-logistic-core-editors) For more details, see: https://code.launchpad.net/~agilebg

[Openerp-community-reviewer] [Merge] lp:~agilebg/openerp-product-attributes/7.0-product-customer-code-extraction-improvements into lp:openerp-product-attributes

2014-01-21 Thread Nicola Malcontenti - Agile BG
Nicola Malcontenti - Agile BG has proposed merging lp:~agilebg/openerp-product-attributes/7.0-product-customer-code-extraction-improvements into lp:openerp-product-attributes. Requested reviews: Product Core Editors (product-core-editors) For more details, see: https://code.launchpad.net

[Openerp-community-reviewer] [Merge] lp:~agilebg/openerp-product-attributes/7.0-product-customer-code-extraction-improvements into lp:~akretion-team/openerp-product-attributes/7.0-product-customer-cod

2014-01-23 Thread Nicola Malcontenti - Agile BG
Nicola Malcontenti - Agile BG has proposed merging lp:~agilebg/openerp-product-attributes/7.0-product-customer-code-extraction-improvements into lp:~akretion-team/openerp-product-attributes/7.0-product-customer-code-extraction. Requested reviews: Lorenzo Battistini - Agile BG (elbati

[Openerp-community-reviewer] [Merge] lp:~agilebg/openerp-mrp-reports/adding_mrp_webkit into lp:openerp-mrp-reports

2014-02-20 Thread Nicola Malcontenti - Agile BG
Nicola Malcontenti - Agile BG has proposed merging lp:~agilebg/openerp-mrp-reports/adding_mrp_webkit into lp:openerp-mrp-reports. Requested reviews: OpenERP Community Reviewer/Maintainer (openerp-community-reviewer) For more details, see: https://code.launchpad.net/~agilebg/openerp-mrp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/openerp-mrp-reports/adding_mrp_webkit into lp:openerp-mrp-reports

2014-02-26 Thread Nicola Malcontenti - Agile BG
> Ciao Nico > > you should remove mrp_webkit/.DS_Store > and run a PEP8 validator > > When importing Python modules from the same addon, use explicit relative > import rather than absolute import, example in __init__.py, do not use: > import sale > But > from . import sale > > line 552

[Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico into lp:account-invoice-report

2014-02-28 Thread Nicola Malcontenti - Agile BG
Nicola Malcontenti - Agile BG has proposed merging lp:~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico into lp:account-invoice-report. Requested reviews: Account Core Editors (account-core-editors) Related bugs: Bug #1284049 in Account - Invoicing Reports: "serial numbe

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico into lp:account-invoice-report

2014-02-28 Thread Nicola Malcontenti - Agile BG
> LGTM. > > Is there any chance I could convince you to write an automated test for this? Sorry i forgot it, i'll made soon -- https://code.launchpad.net/~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico/+merge/208753 Your team OpenERP Community Reviewer/Maintainer is subscribed to branc

[Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoicing/7.0-bug-1287179-hurrinico into lp:account-invoicing

2014-03-04 Thread Nicola Malcontenti - Agile BG
Nicola Malcontenti - Agile BG has proposed merging lp:~agilebg/account-invoicing/7.0-bug-1287179-hurrinico into lp:account-invoicing. Requested reviews: Andrea Cometa (scigghia) For more details, see: https://code.launchpad.net/~agilebg/account-invoicing/7.0-bug-1287179-hurrinico/+merge

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoicing/7.0-bug-1287179-hurrinico into lp:account-invoicing

2014-03-04 Thread Nicola Malcontenti - Agile BG
> Whithin the _prepare_invoice method I see tabs and spaces mixed done -- https://code.launchpad.net/~agilebg/account-invoicing/7.0-bug-1287179-hurrinico/+merge/209207 Your team Account Core Editors is subscribed to branch lp:account-invoicing. -- Mailing list: https://launchpad.net/~openerp-com

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico into lp:account-invoice-report

2014-04-10 Thread Nicola Malcontenti - Agile BG
> LGTM. > > Is there any chance I could convince you to write an automated test for this? Hi Alexandre, Sorry For the late, i have write the automated test for checking the bug. Regards. -N. -- https://code.launchpad.net/~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico/+merge/208753 You

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico into lp:account-invoice-report

2014-04-16 Thread Nicola Malcontenti - Agile BG
Tests should be ready -- https://code.launchpad.net/~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico/+merge/208753 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post

[Openerp-community-reviewer] [Merge] lp:~agilebg/hotel-management-system/7.0-bug-1308639-hurrinico into lp:hotel-management-system/7.0

2014-04-17 Thread Nicola Malcontenti - Agile BG
Nicola Malcontenti - Agile BG has proposed merging lp:~agilebg/hotel-management-system/7.0-bug-1308639-hurrinico into lp:hotel-management-system/7.0. Requested reviews: Hotel Editors (hotel-core-editors) Related bugs: Bug #1308639 in Hotel Management System: "mx's import proble

[Openerp-community-reviewer] [Merge] lp:~agilebg/sale-reports/7_fix_1331541 into lp:sale-reports

2014-06-20 Thread Nicola Malcontenti - Agile BG
Nicola Malcontenti - Agile BG has proposed merging lp:~agilebg/sale-reports/7_fix_1331541 into lp:sale-reports. Requested reviews: Sale Core Editors (sale-core-editors) For more details, see: https://code.launchpad.net/~agilebg/sale-reports/7_fix_1331541/+merge/223871 In order to solve https

[Openerp-community-reviewer] [Merge] lp:~agilebg/stock-logistic-report/7_fix_1331543 into lp:stock-logistic-report

2014-06-20 Thread Nicola Malcontenti - Agile BG
Nicola Malcontenti - Agile BG has proposed merging lp:~agilebg/stock-logistic-report/7_fix_1331543 into lp:stock-logistic-report. Requested reviews: Stock and Logistic Core Editors (stock-logistic-core-editors) For more details, see: https://code.launchpad.net/~agilebg/stock-logistic-report

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-wkfl/imp_product_by_supplier into lp:~purchase-core-editors/purchase-wkfl/7.0

2014-08-20 Thread Nicola Malcontenti - Agile BG
> @hurrinco: this won't be merged on Launchpad, as the project is now managed on > github. Please migrate the MP to a github PR (cf. Pedro's comment above) I've made a mistake, it's already on github https://github.com/OCA/purchase-workflow/pull/16#issuecomment-52650828 -- https://code.launchpad.