Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-tools/allow_date_fy-sbi into lp:account-financial-tools

2014-04-25 Thread Guewen Baconnier @ Camptocamp
Review: Approve LGTM -- https://code.launchpad.net/~acsone-openerp/account-financial-tools/allow_date_fy-sbi/+merge/213644 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer

[Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-tools/allow_date_fy-sbi into lp:account-financial-tools

2014-04-01 Thread Acsone
Stéphane Bidoul (Acsone) has proposed merging lp:~acsone-openerp/account-financial-tools/allow_date_fy-sbi into lp:account-financial-tools. Requested reviews: Account Core Editors (account-core-editors) For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-tools/allow_date_fy-sbi into lp:account-financial-tools

2014-04-01 Thread Lorenzo Battistini - Agile BG
Review: Approve code review -- https://code.launchpad.net/~acsone-openerp/account-financial-tools/allow_date_fy-sbi/+merge/213644 Your team Account Core Editors is requested to review the proposed merge of lp:~acsone-openerp/account-financial-tools/allow_date_fy-sbi into

Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-tools/allow_date_fy-sbi into lp:account-financial-tools

2014-04-01 Thread Pedro Manuel Baeza
Review: Approve code review Hi, Stéphane, Thanks for the MP. I would name allow_date_fy variable as check_date_fy to better reflect the current behaviour, but that's not a blocking issue. Regards. --

Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-tools/allow_date_fy-sbi into lp:account-financial-tools

2014-04-01 Thread Acsone
Hi Pedro, Thanks for the review. I also considered that name but chose to name it after the field in the standard account module which is named allow_date. Since the two checks are closely related I decided to keep that name. -sbi On Tue, Apr 1, 2014 at 4:01 PM, Pedro Manuel Baeza

Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-tools/allow_date_fy-sbi into lp:account-financial-tools

2014-04-01 Thread Pedro Manuel Baeza
Thanks for explanation, Stéphane. It also makes sense. Regards. -- https://code.launchpad.net/~acsone-openerp/account-financial-tools/allow_date_fy-sbi/+merge/213644 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: