Review: Needs Fixing
Should be fix.
1. close button icon (check for usability)
2. company_id readonly when i double click on payslips from payslip run
3. payslips on payslip run readonly=true ? I am not sure about this.
4. 'name': fields.char('Name', size=256...) decrease the size.
5. on compute
Review: Resubmit
Hello,
I have made all the specified changes.
Thanks and regards,
Purnendu Singh
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-wizard_payslip_employee_category-wise-psi/+merge/58953
Your team OpenERP RD Team is subscribed to branch
Review: Approve
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-wizard_payslip_employee_category-wise-psi/+merge/58953
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-payroll.
___
The proposal to merge
lp:~openerp-dev/openobject-addons/trunk-payroll-wizard_payslip_employee_category-wise-psi
into lp:~openerp-dev/openobject-addons/trunk-payroll has been updated.
Status: Needs review = Merged
For more details, see:
Review: Resubmit
Hello,
Improve the code as specified above.
Add state on hr.payslip.run object.
Let me know if there is any change.
Thanks and regads,
Purnendu Singh
--
in hr_payroll/wizard/hr_payroll_payslips_by_employees.py, abuot lines 335-346:
the behavior seems really weird to me: you call the onchange with [] as ids,
then create the payslip, then create the input lines...
Hello,
In the compute_sheet method of this wizard i need to call the onchange
Review: Needs Fixing
in hr_payroll/wizard/hr_payroll_payslips_by_employees.py, abuot lines 335-346:
the behavior seems really weird to me: you call the onchange with [] as ids,
then create the payslip, then create the input lines...
you can do everything in one operation in you pass the good
Review: Needs Fixing
Payslip Run = Payslip Runs
Generate payslips wizard title should be improve
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-wizard_payslip_employee_category-wise-psi/+merge/58953
Your team OpenERP RD Team is subscribed to branch
Payslip Run = Payslips Run
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-wizard_payslip_employee_category-wise-psi/+merge/58953
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-payroll.
Review: Resubmit
hello sir,
renamed
Payslip Run = Payslips Run
thanks and regards,
Purnendu singh
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-wizard_payslip_employee_category-wise-psi/+merge/58953
Your team OpenERP RD Team is subscribed to branch
Review: Approve
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-wizard_payslip_employee_category-wise-psi/+merge/58953
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-payroll.
___
and yes if i double click on the payslips created on payslip run..and try to
modify note i can not its readonly here!
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-wizard_payslip_employee_category-wise-psi/+merge/58953
Your team OpenERP RD Team is subscribed to
Review: Resubmit
hello sir,
Renamed the class as well as view ids.
Thanks,
Purnendu singh
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-wizard_payslip_employee_category-wise-psi/+merge/58953
Your team OpenERP RD Team is subscribed to branch
Review: Needs Fixing
'payslip_group_id' = 'payslip_run_id'
field name=namehr.payslip.category.form/field = use proper name as class
name for xml id too
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-wizard_payslip_employee_category-wise-psi/+merge/58953
Your team
Review: Needs Fixing
field name=namehr.payslip.category.form/field = still not done ?
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-wizard_payslip_employee_category-wise-psi/+merge/58953
Your team OpenERP RD Team is subscribed to branch
Review: Resubmit
hello sir,
Renamed all views.
Thanks,
Purnendu Singh
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-wizard_payslip_employee_category-wise-psi/+merge/58953
Your team OpenERP RD Team is subscribed to branch
Review: Resubmit
Hello sir,
I made the changes as your suggestion as well as the changes specified on
Etherpad.
Thanks,
Purnendu Singh
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-wizard_payslip_employee_category-wise-psi/+merge/58953
Your team OpenERP RD Team
Review: Needs Fixing
wizard on payslip run: Can not use search view of many2many field on wizard.
AssertionError: Fields in 'groupby' must appear in the list of fields to read
(perhaps it's missing in the list view?)
Change the class name payslip.group to payslip.run.
thanks,
mra
--
Review: Needs Fixing
few points to correct:
1) [2011-04-28 15:14:35,238][payroll_avr_28] WARNING:init:object
hr.payslip.groups (hr.payslip.groups) has no access rules!
2) when selecting a category, i should search for employees in that category
but also for employees in a category child of
Review: Resubmit
Hello sir,
I have made all the changes as per your instructions.
Please tell me if there is any improvment
Thanks
Purnendu Singh
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-wizard_payslip_employee_category-wise-psi/+merge/58953
Your team OpenERP
Review: Needs Fixing
remove this code:
+ if old_slips:
228 + for id in context.get('active_ids'):
229 + slip_pool.write(cr, uid, old_slips, {'payslip_group_id': id},
context=context)
230 + slip_ids.extend(old_slips)
231 + else:
We will not link old payslips with new groups and
Purnendu Singh (OpenERP) has proposed merging
lp:~openerp-dev/openobject-addons/trunk-payroll-wizard_payslip_employee_category-wise-psi
into lp:~openerp-dev/openobject-addons/trunk-payroll.
Requested reviews:
OpenERP RD Team (openerp-dev)
For more details, see:
Review: Needs Fixing
to be improve/fix
1. Rename: Human Resources/Payroll/Payslips by Category = Payslips groups
2. Add search view of payslip group object
3. Generate payslip by category - Generate payslips
4. Generate payslip by category wizard = Add help/tooltips
5. Generate payslip by
23 matches
Mail list logo
