Review: Needs Fixing
67 + # avoid creating history records when writing on a reocrd that is
already an history record
68 + if record.temporal_parent_id:
69 + return False
replace the return False statement with continue
--
The proposal to merge
lp:~openerp-dev/openobject-server/trunk-temporal-db-read-search-unlink-ksa into
lp:~openerp-dev/openobject-server/trunk-temporal-db has been updated.
Status: Needs review = Work in progress
For more details, see:
Review: Resubmit
Hello Quentin,
I made the changes described you.
Thanks.
ksa
--
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-temporal-db-read-search-unlink-ksa/+merge/60367
Your team OpenERP RD Team is subscribed to branch
Review: Needs Fixing
1) line 21-22, context has to be removed as per previous comment
2) def set_date...
if this function is called for ids [1, 2] its finding for the recent child
records for 1 and 2 and assigns result to that ids, not to ids 1 and 2
3) def get_next_id_in_timeline..
Review: Needs Fixing
few comments, just by reading the diff:
line 21-22 of the diff are useless as context isn't used later in the code of
the function. Can be removed for better readability.
line 24: why this ids.reverse()? is it to treat the case where we have records
A,B,C respectively in
Kirti Savalia(OpenERP) has proposed merging
lp:~openerp-dev/openobject-server/trunk-temporal-db-read-search-unlink-ksa into
lp:~openerp-dev/openobject-server/trunk-temporal-db.
Requested reviews:
Rucha (Open ERP) (rpa-openerp)
For more details, see:
Kirti Savalia(OpenERP) has proposed merging
lp:~openerp-dev/openobject-server/trunk-temporal-db-read-search-unlink-ksa into
lp:~openerp-dev/openobject-server/trunk-temporal-db.
Requested reviews:
Rucha (Open ERP) (rpa-openerp)
For more details, see:
Review: Needs Fixing
1) Improve code:
On a fresh installation of DB i got following error:
[2011-04-28 18:45:49,596][readd] ERROR:web-services:[52]: return
super(orm_temporal, self).read(cr, uid, data, fields=original_fields,
context=context, load=load)
[2011-04-28 18:45:49,596][readd]
3) args.append(['temporal_date_from', '', context['temporal_date']] *and*
['temporal_date_to', '', context['temporal_date']])
is it working?
should be ['', (), ()]
--
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-temporal-db-read-search-unlink-ksa/+merge/59368
Your team
4) Another great idea by qdp, we don't need unlink method,
set ondelete=cascade on temporal_parent_id, its working cool
--
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-temporal-db-read-search-unlink-ksa/+merge/59368
Your team OpenERP RD Team is subscribed to branch
The proposal to merge
lp:~openerp-dev/openobject-server/trunk-temporal-db-read-search-unlink-ksa into
lp:~openerp-dev/openobject-server/trunk-temporal-db has been updated.
Status: Needs review = Merged
For more details, see:
11 matches
Mail list logo
