Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-728417-ara into lp:openobject-addons

2011-05-16 Thread Jay Vora (OpenERP)
Hello Ashwin, Thanks for the merge,but this doesn't solve the problem 100%, it hides the problem instead. Please be sure that when the method(of functional field) comes with a multi attribute, we have to return the respective values with it as a final result. Valencia has given me a patch,

[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-728417-ara into lp:openobject-addons

2011-03-29 Thread noreply
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-728417-ara into lp:openobject-addons has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-728417-ara/+merge/54839 --

[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-728417-ara into lp:openobject-addons

2011-03-25 Thread Ashvin Rathod (OpenERP)
Ashvin Rathod (OpenERP) has proposed merging lp:~openerp-dev/openobject-addons/trunk-bug-728417-ara into lp:openobject-addons. Requested reviews: OpenERP Core Team (openerp) Related bugs: Bug #728417 in OpenERP Addons: [6.0.1] Exception raised when setting an Account InActive

Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-728417-ara into lp:openobject-addons

2011-03-17 Thread qdp (OpenERP)
Review: Needs Fixing it's not working. I guess my suggestion wasn't good. Did you test at your side? -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-728417-ara/+merge/52660 Your team OpenERP RD Team is subscribed to branch

[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-728417-ara into lp:openobject-addons

2011-03-17 Thread qdp (OpenERP)
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-728417-ara into lp:openobject-addons has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-728417-ara/+merge/52660 --

Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-728417-ara into lp:openobject-addons

2011-03-14 Thread qdp (OpenERP)
Review: Needs Fixing seems really a weird fix... you should try by doing res = {} at the beginning of the function and doing -return res +return res at the end (decrease the indentation of last line of this function) --

[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-728417-ara into lp:openobject-addons

2011-03-09 Thread Ashvin Rathod (OpenERP)
Ashvin Rathod (OpenERP) has proposed merging lp:~openerp-dev/openobject-addons/trunk-bug-728417-ara into lp:openobject-addons. Requested reviews: OpenERP Core Team (openerp) Related bugs: #728417 [6.0.1] Exception raised when setting an Account InActive

Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-728417-ara into lp:openobject-addons

2011-03-09 Thread Mustufa Rangwala (Open ERP)
If we try to compute credit,debit,balance of the account which has no children + no moves + inactive. It times it will return blank list from _get_children_and_consol(...) method (It does not add its own id also because account is not active). so such situation assigning its own id in compute

Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-728417-ara into lp:openobject-addons

2011-03-09 Thread Mustufa Rangwala (Open ERP)
We can have else condition in compute method when we don't get children + account is inactive then return dictionary with null values. -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-728417-ara/+merge/52660 Your team OpenERP RD Team is subscribed to branch