Review: Needs Fixing
i do not agree: when you holiday request is refused, you want to know who
(which manager) refused it. So we need to save the user that press the refuse
button.
Moreover, previously it was saving the refusing manager always in the same
field whatever if it was already
Review: Resubmit
hello,
I have changed as you describe above.
Thanks,
ara
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-732419-ara/+merge/54314
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-732419-ara.
Review: Approve
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-732419-ara/+merge/54314
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-732419-ara.
___
Mailing list:
Review: Needs Fixing
when i refuse the leave first approval currently filling need to fix it
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-732419-ara/+merge/54314
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-732419-ara.
Review: Resubmit
hello,
I have changed as you describe above.
Thanks,
ara
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-732419-ara/+merge/54314
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-732419-ara.
Review: Needs Fixing
self.write(cr, uid, ids, {'manager_id2': manager}) = self.write(cr, uid,
record.id, {'manager_id2': manager}) or make list and append all record.id on
it and write all at once..
here write method comes in for loop its not good.
--
Ashvin Rathod (OpenERP) has proposed merging
lp:~openerp-dev/openobject-addons/trunk-bug-732419-ara into
lp:openobject-addons.
Requested reviews:
OpenERP Core Team (openerp)
Related bugs:
Bug #732419 in OpenERP Addons: [trunk] hr_holidays: Second validation
7 matches
Mail list logo
