Review: Needs Fixing
there is no need of 2 functions, 1 is enough.
i don't understand this line:
+ if voucher.pay_now == 'pay_later':
You should probably use the amount_residual field of account.move.line to test
if it's paid, it will save some code.
--
Review: Needs Fixing
the unit price is messing even without the second pricelist: i'm creating a
uom:pack of 2 units with bategory = unit, factor = 2 and rounding = 1.
Then when i want to encode a sale.order.line with
1 PCE of PC1 = 450 per unit
1 pack of 2 of PC1 = 1800 per pack instead of 900
Review: Approve
oops, sorry i was checking the wrong branch...
it's working as expected
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-742100-ron/+merge/55734
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-742100-ron.
Review: Needs Information
how could this work? what's that clause?? ('journal_id', '=', journal_id)
journal_id field doesn't exist in account.account ?!
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-752876-pso/+merge/56761
Your team OpenERP RD Team is subscribed to
Review: Needs Information
i don't get the same diff when trying to merge the branch in the main trunk
that here. Is it stacked on good repository?
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-hr_timesheet_fix_yml-ara/+merge/59775
Your team OpenERP RD Team is subscribed
Review: Needs Fixing
I just noticed that there was a company search criteria in tax codes and not
taxes. So for symmetry, the same search criteria should be added in
view_account_tax_search.
please do so
--
Review: Needs Fixing
:( this is not good at all. The generated payslip have to use the value we're
setting on the payslip run otherwise it's just useless
so
*make the date from and date to required on the payslip run
*add default value for those fields as they have on payslip
*in the wizard,
Review: Needs Fixing
use this instead of inheritency of InputLine:
+categories_dict = {}
+categories_obj = BrowsableObject(self.pool, cr, uid,
payslip.employee_id.id, categories_dict)
Then for the renaming of the variable localdict into categories_dict: i didn't
test but are
pad updated please check it in order to complete the merge proposal.
Thanks
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-account-remove-fields-mtr/+merge/61090
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-payroll.
Review: Needs Fixing
as discussed with mra, please change the field name too in order to make
input.SALEURO.amount insteead of .quantity
Also fix the typo in the help tooltip (quantity instead of qunatity)
thanks
--
Review: Needs Fixing
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-account-remove-fields-mtr/+merge/61090
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-payroll.
___
Mailing
Review: Needs Fixing
conflicting. Please resubmit
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-contribution-report-psi/+merge/61374
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-payroll.
Review: Needs Fixing
what?
something isn't good in hr_payroll/hr_payroll_report.xml. I see plenty of new
reports among some on removed object like hr.payroll.advice...
also in pyroll.py: remove the commented code you jsut added for contribution
register: bazaar is your historian.
please fix
Review: Needs Fixing
merge and solve conflicts please
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-account-asset-onchange-asset-account-bde/+merge/61209
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-account-asset.
Review: Needs Fixing
replace tabs and solve conflicts
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-account-asset-usability-bde/+merge/61218
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-account-asset.
i merged but you should improve to create the asset accordingly to the value of
depreciation fields of asset category selected = you have to run the onchange
on the asset to fill those fields
thanks
--
Review: Needs Fixing
I fixed that. Please have a look
1) did a case-insensitive str.replace
import re
pattern = re.compile(hello, re.IGNORECASE)
pattern.sub(bye, hello HeLLo HELLO)
2) already_id in def execute was unused
3) if i understand correctly what you've done, already_id in
The proposal to merge
lp:~openerp-dev/openobject-addons/trunk-payroll-change-label-mtr into
lp:~openerp-dev/openobject-addons/trunk-payroll has been updated.
Status: Needs review = Merged
For more details, see:
Review: Needs Fixing
report layout should be improved in order to:
*use same style as other reports
*display the selected dates of the wizard in header
*add a column quantity
*add a row for total
*display the payslip name and the rest of information on the same row
*row header for amount should be
Review: Needs Fixing
:(
no, what i meant by in the wizard is: while running the wizard. I see that
you've added those fields on the wizard.
so what we want is:
fields on the payslip run, when i run the wizard, i see only the list of
employee. When i select some and generate the payslip for the
Review: Needs Fixing
categories.BASIC + (categories.ALW or 0.0)
this rule doesn't work if there is no ALW category. Find a way to solve that.
also, as the change from localdict = category_dict is meaningless please
revert it
--
Review: Needs Fixing
btw, i'd like also that you apply the same layout for the depreciaiton method
and duration of asset than in asset category form view.
otherwise, for the feature improved here:
1) when we select 'ending period' as choice, the field during (interval)
should be set invisible
Review: Needs Fixing
please put the _check_date constraint into the attribute _constraints of
account.move.line.
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-783994-ara/+merge/61545
Your team OpenERP RD Team is subscribed to branch
FYI: i fixed the icon too (terp-go-home)
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-764855-aag/+merge/58276
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-764855-aag.
___
Review: Needs Fixing
0 is an acceptable value
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-777803-ron/+merge/60147
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-777803-ron.
___
i fixed
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-777803-ron/+merge/60147
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-777803-ron.
___
Mailing list:
next time, create a LP bug and link it to the merge prop.
thanks
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-hr-search-psi/+merge/59777
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-hr-search-psi.
Review: Needs Fixing
i don't think you can change the order = parent_left, it's used for the
hierarchy computation.. Need to check that
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-765559-ron/+merge/59498
Your team OpenERP RD Team is subscribed to branch
101 - 128 of 128 matches
Mail list logo
