Re: [PATCH v2] pxamci: add regulator support.

2009-05-07 Thread Daniel Ribeiro
Em Qui, 2009-05-07 às 16:37 +0100, Mark Brown escreveu: > No, it will return success. You can see the stub implementation in the > API header files. I looked at it, and kept pxamci_regulator_get() on v3 because of this. :) > > If both are supplied and config_regulator is set, then the regulator

Re: [PATCH v2] pxamci: add regulator support.

2009-05-07 Thread Mark Brown
On Thu, May 07, 2009 at 11:40:46AM -0300, Daniel Ribeiro wrote: > Em Qui, 2009-05-07 ??s 09:27 +0100, Mark Brown escreveu: > > regulator_get() and regulator_put() compile out if regulator is not > > defined, though you will get a dummy regulator back. > Will regulator_get() return an error case c

Re: [PATCH v2] pxamci: add regulator support.

2009-05-07 Thread Daniel Ribeiro
Em Qui, 2009-05-07 às 09:27 +0100, Mark Brown escreveu: > On Thu, May 07, 2009 at 04:13:53AM -0300, Daniel Ribeiro wrote: > > > +#else > > +static int pxamci_regulator_get(struct pxamci_host *host) > > +{ > > + return 0; > > +} > > +static void pxamci_regulator_put(struct pxamci_host *host) {} >

Re: [PATCH v2] pxamci: add regulator support.

2009-05-07 Thread Mark Brown
On Thu, May 07, 2009 at 04:13:53AM -0300, Daniel Ribeiro wrote: > +#else > +static int pxamci_regulator_get(struct pxamci_host *host) > +{ > + return 0; > +} > +static void pxamci_regulator_put(struct pxamci_host *host) {} regulator_get() and regulator_put() compile out if regulator is not de

Re: [PATCH v2] pxamci: add regulator support.

2009-05-07 Thread Daniel Ribeiro
Em Qui, 2009-05-07 às 14:12 +0800, Eric Miao escreveu: > From the coding style point of view, we might better keep the number > of those "#ifdef CONFIG_REGULATOR .. #endif" to a minimum, e.g. Thanks! Check this new version. Now releasing the regulator on exit too. Signed-off-by: Daniel Ribeiro -