Re: [PATCH v4] pxamci: add regulator support.

2009-05-18 Thread Eric Miao
On Sat, May 16, 2009 at 3:27 AM, Russell King - ARM Linux wrote: > On Thu, May 14, 2009 at 05:11:00PM +0800, Eric Miao wrote: >> +static void pxamci_set_power(struct pxamci_host *host, unsigned int vdd) >>  { > ... >> +       struct mmc_host *mmc = host->mmc; >> > ... >> +       if (host->pdata->s

Re: [PATCH v4] pxamci: add regulator support.

2009-05-15 Thread Russell King - ARM Linux
On Thu, May 14, 2009 at 05:11:00PM +0800, Eric Miao wrote: > +static void pxamci_set_power(struct pxamci_host *host, unsigned int vdd) > { ... > + struct mmc_host *mmc = host->mmc; > ... > + if (host->pdata->setpower) { > + host->pdata->setpower(host->dev, vdd); > +

Re: [PATCH v4] pxamci: add regulator support.

2009-05-14 Thread Eric Miao
On Fri, May 15, 2009 at 11:34 AM, Eric Miao wrote: > On Thu, May 14, 2009 at 5:31 PM, Daniel Ribeiro wrote: >> Em Qui, 2009-05-14 às 17:11 +0800, Eric Miao escreveu: >>> I'd rather it's implemented something like below (it's only for illustration >>> purpose): >> >> I dont think we can set ocr_av

Re: [PATCH v4] pxamci: add regulator support.

2009-05-14 Thread Eric Miao
On Thu, May 14, 2009 at 5:31 PM, Daniel Ribeiro wrote: > Em Qui, 2009-05-14 às 17:11 +0800, Eric Miao escreveu: >> I'd rather it's implemented something like below (it's only for illustration >> purpose): > > I dont think we can set ocr_avail on set_ios(). See mmc_power_up(). > Yes, so that's for

Re: [PATCH v4] pxamci: add regulator support.

2009-05-14 Thread Daniel Ribeiro
Em Qui, 2009-05-14 às 17:11 +0800, Eric Miao escreveu: > I'd rather it's implemented something like below (it's only for illustration > purpose): I dont think we can set ocr_avail on set_ios(). See mmc_power_up(). -- Daniel Ribeiro

Re: [PATCH v4] pxamci: add regulator support.

2009-05-14 Thread Eric Miao
I'd rather it's implemented something like below (it's only for illustration purpose): diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c index 793ab2a..6fa7a05 100644 --- a/drivers/mmc/host/pxamci.c +++ b/drivers/mmc/host/pxamci.c @@ -73,42 +73,28 @@ struct pxamci_host { }; #if

[PATCH v4] pxamci: add regulator support.

2009-05-14 Thread Daniel Ribeiro
Em Qua, 2009-05-13 às 21:51 +0200, Pierre Ossman escreveu: > What happened to the version with the warning? Sorry for the delay, here it is. Changes pxamci.c to use the regulator subsystem. Uses the regulator case CONFIG_REGULATOR is defined and a matching is regulator is provided, or falls back