Re: [openflowplugin-dev] [nic-dev] [release] [didm-dev] OFP getTableFeature() breakage in nic and didm

2016-06-06 Thread Thanh Ha
Any updates here? Are we any closer to getting a fix for this issue? Thanks, Thanh On 27 May 2016 at 10:00, Colin Dixon wrote: > Not to discourage discussing BUG-5954, but we still haven't seen a good > build of autorelease for Boron in more than a month: > https://jenkins.opendaylight.org/rele

Re: [openflowplugin-dev] [nic-dev] [release] [didm-dev] OFP getTableFeature() breakage in nic and didm

2016-05-27 Thread Colin Dixon
Not to discourage discussing BUG-5954, but we still haven't seen a good build of autorelease for Boron in more than a month: https://jenkins.opendaylight.org/releng/view/autorelease/ It looks like the last two failed for Jenkins reasons, but do we believe we've fixed everything? --Colin On Wed,

Re: [openflowplugin-dev] [nic-dev] [release] [didm-dev] OFP getTableFeature() breakage in nic and didm

2016-05-25 Thread Anil Vishnoi
Just a minor correct. Lithium plugin in master branch don't have a flag to disable it. We took an alternate solution to move table-features out of /"node/table" path. I think we should cherry-pick that patch to master as well for LIthium, if we want to disable table features by default. On Wed, Ma

Re: [openflowplugin-dev] [nic-dev] [release] [didm-dev] OFP getTableFeature() breakage in nic and didm

2016-05-25 Thread Tai, Hideyuki
I agree with Anil's and Abhijit's proposal. Hi Raphael and Renato, What do you think about this proposal from the point of view of NIC committers? Since you implemented PipelineManager which uses the table features, we need your opinions about if it is acceptable to NIC project or not

Re: [openflowplugin-dev] [nic-dev] [release] [didm-dev] OFP getTableFeature() breakage in nic and didm

2016-05-25 Thread Abhijit Kumbhare
Thanks for the good summary & analysis Anil. Having table features collection by default on will make the performance unacceptable with OVS 2.4 regardless of whether DIDM or NIC is being used or not. It might be possible for people to use OpenFlow Plugin without DIDM or NIC. Hence I think we should

Re: [openflowplugin-dev] [nic-dev] [release] [didm-dev] OFP getTableFeature() breakage in nic and didm

2016-05-25 Thread Hema Gopalkrishnan
: Abhijit Kumbhare Cc: openflowplugin-dev; Thanh Ha; rele...@lists.opendaylight.org; Robert Varga; Subhash Singh; nic-...@lists.opendaylight.org; didm-...@lists.opendaylight.org Subject: Re: [openflowplugin-dev] [nic-dev] [release] [didm-dev] OFP getTableFeature() breakage in nic and didm This patch

Re: [openflowplugin-dev] [nic-dev] [release] [didm-dev] OFP getTableFeature() breakage in nic and didm

2016-05-25 Thread Anil Vishnoi
This patch was for lithium plugin and we have a patch on the way for He plugin as well (https://git.opendaylight.org/gerrit/#/c/39150/6). With these both the patch, we provide uses to enable/disable the table features in stable/beryllium branch (after SR3). In lithium plugin we disabled the table

Re: [openflowplugin-dev] [nic-dev] [release] [didm-dev] OFP getTableFeature() breakage in nic and didm

2016-05-25 Thread Abhijit Kumbhare
No - but a smaller impact change ( https://git.opendaylight.org/gerrit/#/c/36506/) to allow turning the table features off was pushed. We had discussed at the OF Plugin meeting - and that was the least of the evils that was decided. On Wed, May 25, 2016 at 3:21 PM, Anil Vishnoi wrote: > I don't

Re: [openflowplugin-dev] [nic-dev] [release] [didm-dev] OFP getTableFeature() breakage in nic and didm

2016-05-25 Thread Anil Vishnoi
I don't think so this patch (https://git.opendaylight.org/gerrit/#/c/36559/) was pushed to stable beryllium. On Wed, May 25, 2016 at 8:16 AM, Abhijit Kumbhare wrote: > Yes. From what I remember - the model changes were not in the last > Beryllium SR (i.e. SR 2) - so the release note of SR3 shoul

Re: [openflowplugin-dev] [nic-dev] [release] [didm-dev] OFP getTableFeature() breakage in nic and didm

2016-05-25 Thread Abhijit Kumbhare
Yes. From what I remember - the model changes were not in the last Beryllium SR (i.e. SR 2) - so the release note of SR3 should have this. On Wed, May 25, 2016 at 1:09 AM, Robert Varga wrote: > On 05/25/2016 07:43 AM, Anil Vishnoi wrote: > > So looks like these yang model changes > > Hello, > >

Re: [openflowplugin-dev] [nic-dev] [release] [didm-dev] OFP getTableFeature() breakage in nic and didm

2016-05-25 Thread Robert Varga
On 05/25/2016 07:43 AM, Anil Vishnoi wrote: > So looks like these yang model changes Hello, This will need to be release-noted, as it is a change in public API. Bye, Robert signature.asc Description: OpenPGP digital signature ___ openflowplugin-dev

Re: [openflowplugin-dev] [nic-dev] [release] [didm-dev] OFP getTableFeature() breakage in nic and didm

2016-05-24 Thread Anil Vishnoi
So looks like these yang model changes happened and only lithium plugin was adapted to these changes. Helium plugin is still not adapted to these changes and that's why NIC/DIDM projects are probably not able to find the table features and failing. I am looking into it, and push the patch as soon a

Re: [openflowplugin-dev] [nic-dev] [release] [didm-dev] OFP getTableFeature() breakage in nic and didm

2016-05-24 Thread Abhijit Kumbhare
Did not see this thread before. Added Jozef & Michal. I believe Alexis has narrowed the breakage to: https://git.opendaylight.org/gerrit/#/c/36559/5/model/model-flow-service/src/main/yang/flow-node-inventory.yang On Tue, May 24, 2016 at 1:53 PM, Manikantan, Anandhi < anandhi.manikan...@hpe.com