[openib-general] [PATCH] OpenSM/ib_types.h: Pad ib_inform_info_record_t to be modulo 8 in size

2006-07-19 Thread Hal Rosenstock
OpenSM/ib_types.h: Pad ib_inform_info_record_t to be modulo 8 in size so that attribute offset is calculated properly Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: include/iba/ib_types.h === --- include/iba/ib_types.h

[openib-general] [PATCH][TRIVIAL]OpenSM/osm_sa_informinfo.c: Remove unneeded line of code in __osm_infr_rcv_respond

2006-07-19 Thread Hal Rosenstock
OpenSM/osm_sa_informinfo.c: Remove unneeded line of code in __osm_infr_rcv_respond Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: opensm/osm_sa_informinfo.c === --- opensm/osm_sa_informinfo.c (revision 8606) +++ opensm

[openib-general] [PATCH][TRIVIAL] OpenSM/osm_sa_class_port_info.c: Eliminate unneeded line of code in __osm_cpi_rcv_respond

2006-07-19 Thread Hal Rosenstock
OpenSM/osm_sa_class_port_info.c: Eliminate unneeded line of code in __osm_cpi_rcv_respond Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: opensm/osm_sa_class_port_info.c === --- opensm/osm_sa_class_port_info.c (revision

[openib-general] [PATCH] OpenSM/complib: Eliminate deprecated warnings

2006-07-18 Thread Hal Rosenstock
OpenSM/complib: Eliminate deprecated warnings Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: complib/Makefile.am === --- complib/Makefile.am (revision 8561) +++ complib/Makefile.am (working copy) @@ -10,7 +10,7 @@ else

[openib-general] [PATCH][TRIVIAL] OpenSM/osm_link_mgr.c: Eliminate duplicated line of code

2006-07-18 Thread Hal Rosenstock
OpenSM/osm_link_mgr.c: Eliminate duplicated line of code Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: opensm/osm_link_mgr.c === --- opensm/osm_link_mgr.c (revision 8572) +++ opensm/osm_link_mgr.c (working copy

Re: [openib-general] [PATCH 2/2] ib_cm: fix REJ due to invalid GID

2006-07-18 Thread Hal Rosenstock
On Tue, 2006-07-18 at 11:19, Michael S. Tsirkin wrote: [snip...] I also wander what should the status be if there are multiple errors in a REQ. The first one discovered, no? Or maybe the most severe one? The spec seems fuzzy in this respect ... There is no defined precedence of

[openib-general] [PATCH][MINOR]OpenSM/osm_sa_path_record.c: In __osm_pr_rcv_get_port_pair_paths, use ib_path_rec_num_path routine

2006-07-18 Thread Hal Rosenstock
OpenSM/osm_sa_path_record.c: In __osm_pr_rcv_get_port_pair_paths, use ib_path_rec_num_path routine Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: opensm/osm_sa_path_record.c === --- opensm/osm_sa_path_record.c (revision 8575

[openib-general] [PATCH] osmtest/osmtest.c: Exercise SA PathRecord multicast destination code

2006-07-18 Thread Hal Rosenstock
osmtest/osmtest.c: Exercise SA PathRecord multicast destination code Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: osmtest/osmtest.c === --- osmtest/osmtest.c (revision 8575) +++ osmtest/osmtest.c (working copy

[openib-general] [PATCH] OpenSM/doc: Add current-routing.txt

2006-07-18 Thread Hal Rosenstock
OpenSM/doc: Add current-routing.txt This document is a description of the current routing algorithms/methods implemented by OpenSM. Written with copious help from Eitan Zahavi and Sasha Khapyorsky Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: doc/current-routing.txt

[openib-general] [PATCH][MINOR] OpenSM/osm_sa_path_record.c: In __osm_pr_rcv_get_lid_pair_path, only get reversible path parameters if requested

2006-07-17 Thread Hal Rosenstock
OpenSM/osm_sa_path_record.c: In __osm_pr_rcv_get_lid_pair_path, only get reversible path parameters if requested Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: opensm/osm_sa_path_record.c === --- opensm/osm_sa_path_record.c

[openib-general] {PATCH][MINOR] OpenSM/osm_sa_path_record.c: In __osm_pr_rcv_get_path_parms, fix endian of port GUID and indicate port number in some osm_log messages

2006-07-17 Thread Hal Rosenstock
OpenSM/osm_sa_path_record.c: In __osm_pr_rcv_get_path_parms, fix endian of port GUID and indicate port number in some osm_log messages Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: opensm/osm_sa_path_record.c === --- opensm

[openib-general] [PATCH][MINOR] OpenSM/osm_sa_multipath_record.c: Fix endian of port GUID and indicate port number in some osm_log messages

2006-07-17 Thread Hal Rosenstock
OpenSM/osm_sa_multipath_record.c: Fix endian of port GUID and indicate port number in some osm_log messages Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: opensm/osm_sa_multipath_record.c === --- opensm

[openib-general] [PATCH] OpenSM/osm_sa_mcmember_record.c: In __mgrp_request_is_realizable, set default selectors to exactly

2006-07-17 Thread Hal Rosenstock
OpenSM/osm_sa_mcmember_record.c: In __mgrp_request_is_realizable, set default selectors to exactly Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: opensm/osm_sa_mcmember_record.c === --- opensm/osm_sa_mcmember_record.c

[openib-general] [PATCHv2] OpenSM/osm_sa_path_record.c: Support SL in PathRecord requests based on whether or not QoS is enabled

2006-07-14 Thread Hal Rosenstock
OpenSM/osm_sa_path_record.c: Support SL in PathRecord requests based on whether or not QoS is enabled Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: opensm/osm_sa_path_record.c === --- opensm/osm_sa_path_record.c (revision

[openib-general] [PATCHv2] OpenSM: Support configurable SL per partition

2006-07-14 Thread Hal Rosenstock
OpenSM: Support configurable SL per partition Signed-off-by: Sasha Khapyorsky [EMAIL PROTECTED] Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: include/opensm/osm_partition.h === --- include/opensm/osm_partition.h

Re: [openib-general] there are compilation warnings in complib

2006-07-13 Thread Hal Rosenstock
On Thu, 2006-07-13 at 03:58, Dotan Barak wrote: Hi. I noticed that there are warnings during the compilation of the gen2 driver. machine props: * Host Architecture : x86_64 Linux Distribution: Red Hat Enterprise Linux AS release

Re: [openib-general] there are compilation warnings in complib

2006-07-13 Thread Hal Rosenstock
On Thu, 2006-07-13 at 06:48, Dotan Barak wrote: On Thursday 13 July 2006 13:25, Hal Rosenstock wrote: ./../include/complib/cl_memtrack.h:99: warning: `cl_mem_tracker_t' is deprecated (declared at ./../include/complib/cl_memtrack.h:82) cl_memory.c:74: warning: `cl_mem_tracker_t

Re: [openib-general] there are compilation warnings in complib

2006-07-13 Thread Hal Rosenstock
On Thu, 2006-07-13 at 07:52, Michael S. Tsirkin wrote: Quoting r. Hal Rosenstock [EMAIL PROTECTED]: In file included from cl_memory.c:55: ./../include/complib/cl_memtrack.h:99: warning: `cl_mem_tracker_t' is deprecated (declared at ./../include/complib/cl_memtrack.h:82) cl_memory.c

[openib-general] IPoIB Path Rerequests and Compliance

2006-07-13 Thread Hal Rosenstock
Hi Roland, It appears to me that if for some reason IPoIB rerequests a path that has already been resolved, it has filled in values for fields in the request which are not to be honored by the SA as their component mask bits are not on. While the SA responds properly to this since it ignores

Re: [openib-general] openSM failover / failback issue?

2006-07-13 Thread Hal Rosenstock
On Wed, 2006-07-12 at 21:45, Hal Rosenstock wrote: [snip...] I don't know if this is an HCA firmware issues, switch issue, or openSM issue. I don't think it's related to my changes or osmtest at this point. I'll see if I can reproduce this tomorrow. I've followed your scenario

Re: [openib-general] [PATCH] OpenSM: Support configurable SL per partition

2006-07-12 Thread Hal Rosenstock
Hi Pat, On Tue, 2006-07-11 at 17:14, Patrick Mullaney wrote: This will avoid an invalid warning about service level value if sl=0 is used in the partition config file. Can you include something like it in your original patch? Yes, SL 0 is valid so this warning should not be output. I will

Re: [openib-general] [openfabrics-ewg] OFED 1.1 release - schedule and features

2006-07-12 Thread Hal Rosenstock
On Wed, 2006-07-12 at 01:53, Tziporet Koren wrote: Hi All, I wish to start the release process of OFED 1.1. I would like that we will have a meeting next Monday to review this proposal of the release features and schedule. If possible I wish to move the meeting hour from 9am PST to

Re: [openib-general] link to the ipoib charter page pointed by the kernel IB docs is broken

2006-07-12 Thread Hal Rosenstock
Hi Or, On Wed, 2006-07-12 at 03:13, Or Gerlitz wrote: Hi Hal, I think you were involved in setting/updating the pointers from the IPoIB kernel docs to the IETF website... I see now that the link pointed by drivers/infiniband/ulp/ipoib/Kconfig and Documentation/infiniband/ipoib is broken,

Re: [openib-general] [PATCH] validate MADs issued from userspace for spec compliance C13-18.1.1

2006-07-12 Thread Hal Rosenstock
On Tue, 2006-07-11 at 16:07, Sean Hefty wrote: [snip...] After further testing, this patch breaks osmtest as a result of modifying the TID for a SEND. What does the test do? Hmm... I just reran the test, and it worked now. Now I'm really confused as to what the problem was. The

Re: [openib-general] [PATCH] validate MADs issued from userspace for spec compliance C13-18.1.1

2006-07-12 Thread Hal Rosenstock
On Tue, 2006-07-11 at 18:55, Sean Hefty wrote: Other issues that I've been running into appear to be related to a combination of timing issues running the tests too quickly after starting opensm Yes, if opensm has not gotten far enough, osmtest will fail. The SM must initialize the subnet

Re: [openib-general] [PATCH] validate MADs issued from userspace for spec compliance C13-18.1.1

2006-07-12 Thread Hal Rosenstock
On Wed, 2006-07-12 at 07:13, Hal Rosenstock wrote: and running multiple copies of opensm on different systems. Not sure what that would fail. The other SMs should be standbys. I can't think of what would fail in osmtest off the top of my head but haven't tried this yet but am now about

Re: [openib-general] [openfabrics-ewg] OFED 1.1 release - schedule and features

2006-07-12 Thread Hal Rosenstock
On Wed, 2006-07-12 at 06:51, Tziporet Koren wrote: Hal Rosenstock wrote: • OSM: –Partition Manager (Pkey) Also, primitive QoS support. –Pre-computed routing load from file Also, diags: Add saquery tool Enhancement

Re: [openib-general] openSM - IS_SM capability mask problem

2006-07-12 Thread Hal Rosenstock
On Tue, 2006-07-11 at 09:27, yipee wrote: Hal Rosenstock halr at voltaire.com writes: [snip] It's not the setting which is failing. You are likely not using an SM which supports this (it is an enhanced capability defined in a 1.2 erratum). Are you running a recent OpenSM or something else

Re: [openib-general] [PATCH] OpenSM: Support configurable SL per partition

2006-07-12 Thread Hal Rosenstock
Hi again Pat, On Tue, 2006-07-11 at 17:14, Patrick Mullaney wrote: This will avoid an invalid warning about service level value if sl=0 is used in the partition config file. Can you include something like it in your original patch? Thanks. Pat

Re: [openib-general] openSM - IS_SM capability mask problem

2006-07-12 Thread Hal Rosenstock
On Wed, 2006-07-12 at 09:13, yipeeyipee yipeeyipee wrote: --- Hal Rosenstock [EMAIL PROTECTED] wrote: [snip] Should this IS_SM bit in port attributes be supported in the switch hardware? If you are running an SM on your switch, the IS_SM bit would be on for port 0. Otherwise not. Yes

Re: [openib-general] [PATCH] validate MADs issued from userspace for spec compliance C13-18.1.1

2006-07-12 Thread Hal Rosenstock
On Wed, 2006-07-12 at 12:41, Sean Hefty wrote: Hal Rosenstock wrote: and running multiple copies of opensm on different systems. Not sure what that would fail. The other SMs should be standbys. I can't think of what would fail in osmtest off the top of my head but haven't tried this yet

[openib-general] [PATCH] [MINOR] OpenSM/SA: Minor reordering of SA rcv_process functions to be more consistent

2006-07-12 Thread Hal Rosenstock
OpenSM/SA: Minor reordering of SA rcv_process functions to be more consistent Also, some cosmetic changes Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: opensm/osm_sa_guidinfo_record.c === --- opensm/osm_sa_guidinfo_record.c

Re: [openib-general] [PATCH] validate MADs issued from userspace for spec compliance C13-18.1.1

2006-07-12 Thread Hal Rosenstock
On Wed, 2006-07-12 at 13:58, Sean Hefty wrote: I was starting / stopping openSM on different systems soon before running the tests. Not sure I quite understand the sequencing. I was being somewhat random, just trying to stress things. How quickly will one SM take over for another

Re: [openib-general] openSM failover / failback issue?

2006-07-12 Thread Hal Rosenstock
On Wed, 2006-07-12 at 18:36, Sean Hefty wrote: Hal Rosenstock wrote: With the default sminfo_polling_timeout of 10 seconds and default polling_retry_number of 4, so the total handoff time should be around 40 seconds. I just did that experiment with 2 SMs and saw that as well. Okay - I

Re: [openib-general] ping problem with ammasso cards(iWARP interface)

2006-07-12 Thread Hal Rosenstock
Ravinandan, On Wed, 2006-07-12 at 19:39, Ravinandan Arakali wrote: Also, I am trying to run some of the iwarp bandwidth/latency tests (available under directory perftest). The first thing to do here is to run opensm. You don't need to run OpenSM for iWARP. When I run opensm (with debug

Re: [openib-general] openSM - IS_SM capability mask problem

2006-07-11 Thread Hal Rosenstock
On Tue, 2006-07-11 at 03:24, yipee wrote: Hi, On one of my IB setups I get the following error from openSM: osm_vendor_set_sm: ERR 5431: setting IS_SM capability mask failed; errno 2 what's this IS_SM capability mask? what might cause its setting to fail? It's not the setting which is

Re: [openib-general] [PATCH] libibmad: Support MFT and Notice/Trap fields

2006-07-11 Thread Hal Rosenstock
On Mon, 2006-07-10 at 17:50, Sean Hefty wrote: Hal Rosenstock wrote: +enum TRAP_NUM_ID { + IB_TRAP_128, + + IB_TRAP_LAST +}; Should TRAP_128 be defined as 0? Good catch. This is being removed from this include for now. -- Hal - Sean

[openib-general] [PATCH][TRIVIAL] libibmad: Remove recently added TRAP_NUM_ID enum

2006-07-11 Thread Hal Rosenstock
libibmad: Remove recently added TRAP_NUM_ID enum Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: include/infiniband/mad.h === --- include/infiniband/mad.h(revision 8488) +++ include/infiniband/mad.h(working copy

[openib-general] [PATCH] OpenSM/osm_vendor_sa_api.h: Add MCMemberRecord query result support

2006-07-10 Thread Hal Rosenstock
OpenSM/osm_vendor_sa_api.h: Add MCMemberRecord query result support Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: osm/include/vendor/osm_vendor_sa_api.h === --- osm/include/vendor/osm_vendor_sa_api.h (revision 8462

[openib-general] [PATCH] diags/saquery: Add support to query multicast groups

2006-07-10 Thread Hal Rosenstock
diags/saquery: Add support to query multicast groups Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: diags/src/saquery.c === --- diags/src/saquery.c (revision 8461) +++ diags/src/saquery.c (working copy) @@ -181,6 +181,26

[openib-general] [PATCH] OpenSM/SA client API: Support attribute modifer in user defined requests

2006-07-10 Thread Hal Rosenstock
OpenSM/SA client API: Support attribute modifer in user defined requests Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: include/vendor/osm_vendor_sa_api.h === --- include/vendor/osm_vendor_sa_api.h (revision 8461

[openib-general] [PATCH] diags/saquery: Add SA PortInfoRecord:CapabilityMask IsSM query

2006-07-10 Thread Hal Rosenstock
diags/saquery: Add SA PortInfoRecord:CapabilityMask IsSM query This patch is predicated on SA client API change for user defined queries supporting attribute modifier. Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: src/saquery.c

[openib-general] [PATCH] OpenSM/osm_sa_path_record.c: Support SL in PathRecord requests based on whether or not QoS is enabled

2006-07-10 Thread Hal Rosenstock
OpenSM/osm_sa_path_record.c: Support SL in PathRecord requests based on whether or not QoS is enabled Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: opensm/osm_sa_path_record.c === --- opensm/osm_sa_path_record.c (revision

[openib-general] [PATCH] OpenSM: Support configurable SL per partition

2006-07-10 Thread Hal Rosenstock
OpenSM: Support configurable SL per partition Signed-off-by: Sasha Khapyorsky [EMAIL PROTECTED] Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: include/opensm/osm_partition.h === --- include/opensm/osm_partition.h

Re: [openib-general] user_mad check question

2006-07-10 Thread Hal Rosenstock
On Fri, 2006-07-07 at 14:30, Sean Hefty wrote: The following check in user_mad is done when sending a MAD. /* * If userspace is generating a request that will generate a * response, we need to make sure the high-order part of the * transaction ID matches the agent

Re: [openib-general] user_mad check question

2006-07-10 Thread Hal Rosenstock
On Fri, 2006-07-07 at 16:59, Sean Hefty wrote: [snip...] Can sends ever be used with RMPP? There;s nothing that precludes this in the IBA although I do not believe this is currently used by any class. -- Hal ___ openib-general mailing list

[openib-general] [PATCH] OpenSM/osm_vendor_sa_api.h: Add InformInfoRecord query result support

2006-07-10 Thread Hal Rosenstock
OpenSM/osm_vendor_sa_api.h: Add InformInfoRecord query result support Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: include/vendor/osm_vendor_sa_api.h === --- include/vendor/osm_vendor_sa_api.h (revision 8475) +++ include

Re: [openib-general] [PATCH] opensm: ibnetdiscover: fix switch info size

2006-07-10 Thread Hal Rosenstock
On Mon, 2006-07-10 at 17:23, Sasha Khapyorsky wrote: This fixes overflow of buffer used for switchinfo in ibnetdiscover. Signed-off-by: Sasha Khapyorsky [EMAIL PROTECTED] Thanks. Applied. -- Hal ___ openib-general mailing list

[openib-general] [PATCH] libibmad: Support MFT and Notice/Trap fields

2006-07-10 Thread Hal Rosenstock
libibmad: Support MFT and Notice/Trap fields Signed-off-by: Sasha Khapyorsky [EMAIL PROTECTED] Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: include/infiniband/mad.h === --- include/infiniband/mad.h(revision 8361

[openib-general] [PATCH] [MINOR] OpenSM/osm_helper: Add support for SMInfoRecord dumping

2006-07-06 Thread Hal Rosenstock
OpenSM/osm_helper: Add support for SMInfoRecord dumping Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: include/opensm/osm_helper.h === --- include/opensm/osm_helper.h (revision 8419) +++ include/opensm/osm_helper.h (working

Re: [openib-general] node_guid and ports guid

2006-07-06 Thread Hal Rosenstock
On Thu, 2006-07-06 at 07:01, yipee wrote: Hi, Is there any defined relation between a node's guid and its ports' guid? On my HCA's I see that the 2 lsb bits of the node guids are always zero and port 1 's guid equals the node guid + 1. Does this always has to be the case? No, it is not an

[openib-general] [PATCH][MINOR] OpenSM/SA: Indicate unsupported method/attribute rather than invalid request in SA response

2006-07-05 Thread Hal Rosenstock
OpenSM/SA: Indicate unsupported method/attribute rather than invalid request in SA response When method/attribute is unsupported, indicate this error rather than more generic invalid request error. Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: opensm/osm_sa_guidinfo_record.c

[openib-general] [PATCH][MINOR] OpenSM/SA: Indicate unsupported method/attribute rather than invalid request in SA response

2006-07-05 Thread Hal Rosenstock
OpenSM/SA: Indicate unsupported method/attribute rather than invalid request in SA response When method/attribute is unsupported, indicate this error rather than more generic invalid request error. Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: opensm/osm_sa_guidinfo_record.c

[openib-general] [PATCH] osmtest/osmtest.c: Fix status decode in ib_get_mad_status_str

2006-07-05 Thread Hal Rosenstock
osmtest/osmtest.c: Fix status decode in ib_get_mad_status_str Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: osmtest/osmtest.c === --- osmtest/osmtest.c (revision 8370) +++ osmtest/osmtest.c (working copy) @@ -284,7

Re: [openib-general] [PATCH] RMPP: add Dual-sided RMPP support

2006-07-05 Thread Hal Rosenstock
On Fri, 2006-06-30 at 23:58, Sean Hefty wrote: Add support for dual-sided RMPP transfers. The implementation assumes that any RMPP request that requires a response uses DS RMPP. Based on the RMPP start-up scenarios defined by the spec, this should be a valid assumption. That is, there is

[openib-general] [PATCH] OpenSM/ib_types.h: Define component masks for SMInfo and InformInfo records

2006-07-05 Thread Hal Rosenstock
OpenSM/ib_types.h: Define component masks for SMInfo and InformInfo records Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: include/iba/ib_types.h === --- include/iba/ib_types.h (revision 8390) +++ include/iba/ib_types.h

[openib-general] [PATCH] osmtest/osmtest.c: Add SMInfo record test

2006-07-05 Thread Hal Rosenstock
osmtest/osmtest.c: Add SMInfo record test Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: osmtest/osmtest.c === --- osmtest/osmtest.c (revision 8390) +++ osmtest/osmtest.c (working copy) @@ -4667,6 +4667,84

[openib-general] [PATCH] OpenSM/osm_sa_sminfo_record.c: In osm_smir_rcv_process, move pkey match to be ahead of allocating response MAD which actually eliminates the leak of the response MAD on pkey n

2006-07-05 Thread Hal Rosenstock
OpenSM/osm_sa_sminfo_record.c: In osm_smir_rcv_process, move pkey match to be ahead of allocating response MAD which actually eliminates the leak of the response MAD on pkey not matching Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: opensm/osm_sa_sminfo_record.c

[openib-general] [PATCH] OpenSM/osm_sa_sminfo_record.c: In osm_smir_rcv_process, send response as RMPP if request was GetTable

2006-07-05 Thread Hal Rosenstock
OpenSM/osm_sa_sminfo_record.c: In osm_smir_rcv_process, send response as RMPP if request was GetTable Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: opensm/osm_sa_sminfo_record.c === --- opensm/osm_sa_sminfo_record.c

[openib-general] [PATCH] OpenSM: Support LMC 0 on enhanced switch port 0

2006-07-04 Thread Hal Rosenstock
for subnet for enhanced switch port 0 or set it to 0 even if a non zero LMC is configured for the subnet. The default is currently the latter option. Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: include/opensm/osm_subnet.h

Re: [openib-general] [PATCH] osm: pkey manager fail to clear unused peer block

2006-07-03 Thread Hal Rosenstock
Hi Eitan, On Sat, 2006-07-01 at 16:21, Eitan Zahavi wrote: Hi Hal Similar to the failure to clear HCA port pkey block if it was empty. The code for peer port does depend on the neighbor HCA block to exist. So the fix is very similar: use an empty block for comparing with the current peer

Re: [openib-general] [diags] compilation warning fix on 32 bit machines

2006-07-03 Thread Hal Rosenstock
On Mon, 2006-07-03 at 05:57, Dotan Barak wrote: Compilation warning on 32 bit machines was fixed. Signed-off-by: Dotan Barak [EMAIL PROTECTED] Thanks. Applied. -- Hal ___ openib-general mailing list openib-general@openib.org

[openib-general] [PATCH] OpenSM/osmtest: Fix display of key violation counters in osmtest_validate_port_data

2006-07-03 Thread Hal Rosenstock
OpenSM/osmtest: Fix display of key violation counters in osmtest_validate_port_data Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: osmtest/osmtest.c === --- osmtest/osmtest.c (revision 8335) +++ osmtest/osmtest.c

[openib-general] [PATCH] [TRIVIAL] OpenSM/osm_sm_mad_ctrl.c: Eliminate dead code in __osm_sm_mad_ctrl_process_get_resp

2006-07-03 Thread Hal Rosenstock
OpenSM/osm_sm_mad_ctrl.c: Eliminate dead code in __osm_sm_mad_ctrl_process_get_resp Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: opensm/osm_sm_mad_ctrl.c === --- opensm/osm_sm_mad_ctrl.c(revision 8341) +++ opensm

[openib-general] [PATCH] [MINOR] OpenSM/osm_helper: Add support for dump of SAInformInfoRecord

2006-07-03 Thread Hal Rosenstock
OpenSM/osm_helper: Add support for dump of SAInformInfoRecord Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: include/opensm/osm_helper.h === --- include/opensm/osm_helper.h (revision 8343) +++ include/opensm/osm_helper.h

Re: [openib-general] Reloading of partition policy

2006-07-01 Thread Hal Rosenstock
Hal Rosenstock wrote: On Thu, 2006-06-29 at 23:50, Hal Rosenstock wrote: On Thu, 2006-06-29 at 19:51, Venkatesh Babu wrote: I was reviewing partition-config.txt and OpenSM_PKey_Mgr.txt and had the following comment - If we need to add/delete a node to/from a partition we need

Re: [openib-general] [PATCHv2] OpenSM/osm_lid_mgr.c: Support enhanced switch port 0 forLMC 0

2006-06-30 Thread Hal Rosenstock
Hi Eitan, On Thu, 2006-06-29 at 15:54, Eitan Zahavi wrote: Hi Hal, I think the check for num lids is so similar it deserves an inline function. What do you say? Does the function need to be inlined ? -- Hal I refer to: +if (p_sw (p_si = osm_switch_get_si_ptr(p_sw)) +

[openib-general] [PATCHv3] OpenSM/osm_lid_mgr.c: Support enhanced switch port 0 for LMC 0

2006-06-30 Thread Hal Rosenstock
OpenSM/osm_lid_mgr.c: Support enhanced switch port 0 for LMC 0 Base port 0 is constrained to have an of LMC of 0 whereas enhanced switch port 0 is not. Support for enhanced switch port 0 is more like CA and router ports in terms of LMC. Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index

Re: [openib-general] Reloading of partition policy

2006-06-30 Thread Hal Rosenstock
On Thu, 2006-06-29 at 23:50, Hal Rosenstock wrote: On Thu, 2006-06-29 at 19:51, Venkatesh Babu wrote: I was reviewing partition-config.txt and OpenSM_PKey_Mgr.txt and had the following comment - If we need to add/delete a node to/from a partition we need to update the file /etc

[openib-general] [PATCH][MINOR] OpenSM/osm_inform.c: n __dump_all_informs, don't scan inform list unless logging has the debug level turned on

2006-06-29 Thread Hal Rosenstock
OpenSM/osm_inform.c: In __dump_all_informs, don't scan inform list unless logging has the debug level turned on Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: opensm/osm_inform.c === --- opensm/osm_inform.c (revision 8274

[openib-general] [PATCH] [TRIVIAL] OpenSM/Remote SM: Eliminate some unneeded status checking

2006-06-29 Thread Hal Rosenstock
OpenSM/Remote SM: Eliminate some unneeded status checking Since osm_remote_sm.c:osm_remote_sm_init cannot fail, don't return any status and don't check in an consumers of this API Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: include/opensm/osm_remote_sm.h

[openib-general] [PATCHv2] OpenSM/osm_lid_mgr.c: Support enhanced switch port 0 for LMC 0

2006-06-29 Thread Hal Rosenstock
OpenSM/osm_lid_mgr.c: Support enhanced switch port 0 for LMC 0 Base port 0 is constrained to have LMC of 0 whereas enhanced switch port 0 is not. Support enhanced switch port 0 is more like CA and router ports in terms of LMC. Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: opensm

[openib-general] [PATCH] OpenSM/osm_sa_portinfo_record.c: Support enhanced switch port 0 for LMC 0

2006-06-29 Thread Hal Rosenstock
OpenSM/osm_sa_portinfo_record.c: Support enhanced switch port 0 for LMC 0 In __osm_sa_pir_create, handle enhanced switch port 0 (and the possibility that it's LMC 0) Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: opensm/osm_sa_portinfo_record.c

[openib-general] [PATCH] OpenSM/SA: Eliminate some no longer needed code

2006-06-27 Thread Hal Rosenstock
, osm_get_port_by_base_lid uses cl_ptr_vector_get_at which does this check at the proper time. Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: opensm/osm_sa_pkey_record.c === --- opensm/osm_sa_pkey_record.c (revision 8236

[openib-general] [PATCH][TRIVIAL] OpenSM/osm_pkey_mgr.c: In pkey_mgr_get_physp_max_blocks, use routine rather than accessing structure member directly

2006-06-27 Thread Hal Rosenstock
OpenSM/osm_pkey_mgr.c: In pkey_mgr_get_physp_max_blocks, use routine rather than accessing structure member directly Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: opensm/osm_pkey_mgr.c === --- opensm/osm_pkey_mgr.c

[openib-general] [PATCH] OpenSM/osm_port_info_rcv.c: In __osm_pi_rcv_process_switch_port, better BSP0 handling

2006-06-27 Thread Hal Rosenstock
against an SMA which set this to LINK_DOWN. This makes the code for BSP0 more similar to how it originally was at the cost of an extra copy of the PortInfo attribute. Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: opensm/osm_port_info_rcv.c

Re: [openib-general] [PATCH] opensm: libibmad: match MAD TransactionID

2006-06-27 Thread Hal Rosenstock
On Tue, 2006-06-27 at 13:07, Sasha Khapyorsky wrote: Hi Eitan, On 09:48 Tue 27 Jun , Eitan Behave wrote: Hi Sasha Can you provide a little more info on the cause and impact of the issue you are solving with this patch? umad_recv() uses poll(), when it is timeouted umad_recv()

[openib-general] [PATCH]OpenSM/osm_lid_mgr.c: In __osm_lid_mgr_init_sweep, support enhanced switch port 0 for LMC 0

2006-06-27 Thread Hal Rosenstock
OpenSM/osm_lid_mgr.c: In __osm_lid_mgr_init_sweep, support enhanced switch port 0 for LMC 0 Base port 0 is constrained to have LMC of 0 whereas enhanced switch port 0 is not. Support enhanced switch port 0 is more like CA and router ports in terms of this. Signed-off-by: Hal Rosenstock [EMAIL

Re: [openib-general] [PATCHv2] osm: pkey manager fail to clear unused block

2006-06-26 Thread Hal Rosenstock
Hi Eitan, On Mon, 2006-06-26 at 03:00, Eitan Zahavi wrote: Hi Hal Had some second thought (slept on it) about this patch. It has a problem as it would continuously set a block if it is all empty (since the new block does not exist) The new patch fixes it by catching the case of null

Re: [openib-general] [PATCH] opensm: libibmad: match MAD TransactionID

2006-06-26 Thread Hal Rosenstock
On Mon, 2006-06-26 at 11:35, Sasha Khapyorsky wrote: Match MAD TransactionID on receiving. This prevents request/response MADs mixing - reproducible when poll() (in libibumad) returns timeout. Signed-off-by: Sasha Khapyorsky [EMAIL PROTECTED] Thanks. Applied. -- Hal

Re: [openib-general] mckey program

2006-06-24 Thread Hal Rosenstock
On Fri, 2006-06-23 at 19:33, Sean Hefty wrote: I was checking the mckey.c program for IB. I did some quick check and found that the rdma_resolve_addr function is invoking the cma_handler with erroneous event. mckey: event: 1, error: -19 Is there any easy way to check what might be

Re: [openib-general] [PATCH][TRIVIAL] librdmacm/examples/udaddy.c: Fix example name in messages

2006-06-23 Thread Hal Rosenstock
On Fri, 2006-06-23 at 07:52, Sean Hefty wrote: librdmacm/examples/udaddy.c: Fix example name in messages Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Thanks - if you haven't, can you commit this as well? (My connection is _really_ slow at the moment...) Sure; committed in r8187

Re: [openib-general] [openfabrics-ewg] Stopping Infiniband kernel modules from loading at system boot

2006-06-23 Thread Hal Rosenstock
Hi Doug, On Fri, 2006-06-23 at 14:44, Doug Ledford wrote: On Fri, 2006-06-23 at 10:14 -0700, [EMAIL PROTECTED] wrote: Short of uninstalling the OFED-1.0 release, how can I stop the Infiniband related kernel modules from loading at system boot? I am trying to debug a problem with

Re: [openib-general] [PATCH] [TRIVIAL] librdmacm/examples/mckey.c: Fix example name in messages

2006-06-22 Thread Hal Rosenstock
On Wed, 2006-06-21 at 18:38, Sean Hefty wrote: librdmacm/examples/mckey.c: Fix example name in messages Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Thanks, Hal. Do you mind committing this change? Sure; committed in r8170. -- Hal - Sean

Re: [openib-general] [PATCH] opensm: osm_pkey_tbl_make_block_pair() removal

2006-06-22 Thread Hal Rosenstock
On Wed, 2006-06-21 at 09:52, Sasha Khapyorsky wrote: Since 'blocks' pkey vector is updated only by receiver, remove it from osm_pkey_tbl_set_new_entry(), as well as osm_pkey_tbl_make_block_pair(). Signed-off-by: Sasha Khapyorsky [EMAIL PROTECTED] Thanks. Applied. -- Hal

[openib-general] [PATCH][MINOR] OpenSM/SA client: In osm_vendor_ibumad_sa.c:osmv_query_sa, eliminate redundant code

2006-06-22 Thread Hal Rosenstock
OpenSM/SA client: In osm_vendor_ibumad_sa.c:osmv_query_sa, eliminate redundant code Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: libvendor/osm_vendor_ibumad_sa.c === --- libvendor/osm_vendor_ibumad_sa.c(revision 8174

[openib-general] [PATCH][TRIVIAL] librdmacm/examples/udaddy.c: Fix example name in messages

2006-06-22 Thread Hal Rosenstock
librdmacm/examples/udaddy.c: Fix example name in messages Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: ../../librdmacm/examples/udaddy.c === --- ../../librdmacm/examples/udaddy.c (revision 8166) +++ ../../librdmacm

Re: [openib-general] [PATCHv5] osm: partition manager force policy

2006-06-21 Thread Hal Rosenstock
Hi Eitan, On Wed, 2006-06-21 at 02:10, Eitan Zahavi wrote: Hi Hal, Thanks for applying the patch. Regarding the issues : Hal Rosenstock wrote: + + CL_ASSERT( p_pkey_tbl ); Should the other routines also assert on this or should this be consistent with the others ? Yes

Re: [openib-general] [PATCH] osm: add release notes to doc dir

2006-06-21 Thread Hal Rosenstock
Hi Eitan, On Wed, 2006-06-21 at 03:34, Eitan Zahavi wrote: Hi Hal Following the OFED 1.0 release I think it will be very handy to user to see OpenSM release notes accumulate in the doc dir. Sure; that seems reasonable. As release notes always refer back to old releases - by not

Re: [openib-general] [PATCH] opensm: add check for not intialized pkey blocks

2006-06-21 Thread Hal Rosenstock
Hi Sasha, On Wed, 2006-06-21 at 08:49, Sasha Khapyorsky wrote: Hi Hal, The lower block of pkey tables' 'blocks' vector may be not initialized due to lost MADs. We need to check it for NULL. Some duplicated code removal as well. Signed-off-by: Sasha Khapyorsky [EMAIL PROTECTED] Thanks.

Re: [openib-general] [librdmacm] compile error

2006-06-21 Thread Hal Rosenstock
Hi Amith, On Wed, 2006-06-21 at 10:07, amith rajith mamidala wrote: Hi, I have a quick question. I updated the infiniband kernel modules and while compiling them got this error. (Redhat AS 4, linux-2.6.16.20 on IA-32 platform ) drivers/infiniband/ulp/ipoib/ipoib_main.c: In function

Re: [openib-general] [PATCH] osm: add release notes to doc dir

2006-06-21 Thread Hal Rosenstock
On Wed, 2006-06-21 at 10:27, Eitan Zahavi wrote: This patch adds the two latest releases notes. One from Jan 2006 and one from Jun 2006. What was the Jan 2006 release ? [EZ] That was the first gen2 distribution. As I mentioned in the previous email on this, my preference would be to

Re: [openib-general] [PATCH] osm: add release notes to doc dir

2006-06-21 Thread Hal Rosenstock
Hi Eitan, On Wed, 2006-06-21 at 03:34, Eitan Zahavi wrote: Hi Hal Following the OFED 1.0 release I think it will be very handy to user to see OpenSM release notes accumulate in the doc dir. As release notes always refer back to old releases - by not specifying all features just new

[openib-general] [PATCH] [TRIVIAL] librdmacm/examples/mckey.c: Fix example name in messages

2006-06-21 Thread Hal Rosenstock
librdmacm/examples/mckey.c: Fix example name in messages Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: ../../librdmacm/examples/mckey.c === --- ../../librdmacm/examples/mckey.c(revision 8166) +++ ../../librdmacm

Re: [openib-general] ib_gid lookup

2006-06-20 Thread Hal Rosenstock
Hi Amit, On Mon, 2006-06-19 at 20:36, Amit Byron wrote: hello, i'm trying to find whether i can do a lookup of ib_gid by either node name or node's ip address. is this information available from the subnet manager? The SM doesn't know the node name but you might be able to do this by

Re: [openib-general] [PATCHv5] osm: partition manager force policy

2006-06-20 Thread Hal Rosenstock
On Mon, 2006-06-19 at 15:05, Eitan Zahavi wrote: Hi Hal This is a 5th take after incorporating Sasha's last reported bug on bad assignment of the used_blocks. This code was run again through my verification flow and also Sasha had run some tests too. Eitan Signed-off-by: Eitan

[openib-general] [PATCH] OpenSM/SA:

2006-06-20 Thread Hal Rosenstock
and not with any masked LIDs. Furthermore, if a query comes in on a non base LID, the LID in the RID returned is only with the base LID. Also, fixed some error handling for SA GetTable requests in these SA records. Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: opensm

Re: [openib-general] ib_gid lookup

2006-06-20 Thread Hal Rosenstock
Hi again Amit, On Tue, 2006-06-20 at 12:27, amit byron wrote: Hal Rosenstock halr at voltaire.com writes: Hi Amit, On Mon, 2006-06-19 at 20:36, Amit Byron wrote: hello, i'm trying to find whether i can do a lookup of ib_gid by either node name or node's ip address

Re: [openib-general] ib_gid lookup

2006-06-20 Thread Hal Rosenstock
Hi again Amit, On Tue, 2006-06-20 at 06:08, Hal Rosenstock wrote: Hi Amit, On Mon, 2006-06-19 at 20:36, Amit Byron wrote: hello, i'm trying to find whether i can do a lookup of ib_gid by either node name or node's ip address. is this information available from the subnet manager

[openib-general] [PATCH] OpenSM/SA: In some SA records, send ERR_REQ_INVALID response on LID out of range error

2006-06-19 Thread Hal Rosenstock
OpenSM/SA: In some SA records, send ERR_REQ_INVALID response on LID out of range error Signed-off-by: Hal Rosenstock [EMAIL PROTECTED] Index: opensm/osm_sa_vlarb_record.c === --- opensm/osm_sa_vlarb_record.c(revision 8105

<    1   2   3   4   5   6   7   8   9   10   >