[ofa-general] [PATCH] osm: Trivial changes for compilation on windows

Hi Hal. This patch has trivial data types changes and redefining a macro. BTW, Sasha, do we still need this macro (NOISE_L in osm_ucast_updn.c)? Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> --- osm/include/opensm/osm_switch.h |4 ++-- osm/opensm/osm_ucast_mgr.c |2 +

[openib-general] [PATCH] osm: trivial data type change to remove compilation warning

Hi Hal Trivial data type change to remove compilation warning. Please apply to the trunk and to the 1.2 branch. Thanks. Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> --- osm/opensm/osm_ucast_updn.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/osm/

Re: [openib-general] [PATCH] osm: Flushing log file after OSM_SYS_LOG message

Sasha Khapyorsky wrote: > On 16:23 Sun 25 Feb , Yevgeny Kliteynik wrote: >> Hi Hal, >> >> OSM log should be flushed when OSM_SYS_LOG message is >> printed. We had this once, but somehow it has disappeared. >> >> This fix has to go both to trunk an

[openib-general] [PATCH] osm: Flushing log file after OSM_SYS_LOG message

Hi Hal, OSM log should be flushed when OSM_SYS_LOG message is printed. We had this once, but somehow it has disappeared. This fix has to go both to trunk and to 1.2. Thanks, --Yevgeny Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> --- osm/opensm/osm_log.c |3 ++- 1 files chan

[openib-general] OSM QoS policy file

Hi Hal. I added osm/doc/qos-policy.txt file with the description of the QoS policy file, and an example of such file (with more comments inside). I'm sure you'll have questions and corrections regarding this file, so for now, to make our work easier, I'm not sending it as patch, but just as text.

Re: [openib-general] [PATCH 10/10] osm: QoS in OpenSM

Hi Hal, Hal Rosenstock wrote: > Hi again Yevgeny, > > On Wed, 2007-01-31 at 17:19, Yevgeny Kliteynik wrote: > > [snip...] > >>>> + for (i = 0; i < IB_MAX_NUM_VLS; i++) >>>> + { >>>> + if (valid_sls[i]) >>

[openib-general] [PATCH] osm: some trivial chages in the osm_ucast_lash for compilation on windows

Hi Hal, This patch has some trivial changes in the osm_ucast_lash.c for compilation on windows. In general, this file needs a major cosmetic (and not only) patch to fit better into the OSM code. Will get back to it at some point in the future. -- Yevgeny Signed-off-by: Yevgeny Kliteynik

[openib-general] [PATCH] osm: trivial casting for compilation on windows

Trivial casting for compilation on windows Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> --- osm/opensm/osm_subnet.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/osm/opensm/osm_subnet.c b/osm/opensm/osm_subnet.c index f2e909b..e4e69c0 100644 --- a/osm/

Re: [openib-general] [PATCH 10/10] osm: QoS in OpenSM

Hi Sasha, Sasha Khapyorsky wrote: > On 17:33 Tue 30 Jan , Yevgeny Kliteynik wrote: >> Checking PathRecord query for QoS constraints >> >> The QoS-aware path selection logic is implemented in a >> separate function that is called only when QoS in OpenSM &g

Re: [openib-general] [PATCH 0/10] osm: QoS in OpenSM

Hi Hal, Hal Rosenstock wrote: > Hi Yevgeny, > > On Tue, 2007-01-30 at 09:51, Yevgeny Kliteynik wrote: >> Hi Hal. >> >> The following is a series of 10 patches: >> 1. QoS policy file parser Yacc file >> 2. QoS policy file parser Lex file >> 3. QoS

Re: [openib-general] [PATCH 10/10] osm: QoS in OpenSM

Hi Hal, Hal Rosenstock wrote: > Hi Yevgeny, > > On Tue, 2007-01-30 at 10:33, Yevgeny Kliteynik wrote: >> Checking PathRecord query for QoS constraints >> >> The QoS-aware path selection logic is implemented in a >> separate function that is called only when QoS i

[openib-general] Bugzilla Bug 329: HCA_FATAL_EVENT cause to OpenSM to stop functioning

Hi Hal. I noticed the following bug in Bugzilla: Bugzilla Bug 329: HCA_FATAL_EVENT cause to opensm to stop functioning https://bugs.openfabrics.org/show_bug.cgi?id=329 When there is a HCA fatal event on the host that opensm is running on it, the opensm stop to

[openib-general] [PATCH 9/10] osm: QoS in OpenSM

Added new command line option for OSM: '-Y' or '--qos_policy_file' Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> --- osm/include/opensm/osm_subnet.h |4 osm/opensm/main.c | 10 +- osm/opensm/osm_opensm.c | 10 +

[openib-general] [PATCH 10/10] osm: QoS in OpenSM

function (the old path selection and the new QoS-aware path selection) will be merged into a single function. Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> --- osm/opensm/osm_sa_path_record.c | 822 ++- 1 files changed, 816 insertions(+), 6 deletions(-)

[openib-general] [PATCH 8/10] osm: QoS in OpenSM

Added QoS class and service id fields to the path record Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> --- diags/src/saquery.c |6 +- osm/include/iba/ib_types.h | 148 +++--- osm/opensm/osm_helper.c |8 +

[openib-general] [PATCH 7/10] osm: QoS in OpenSM

Renamed static function find_prtn_by_name() to non-static osm_prtn_find_by_name() This function will be used later by the PathRecord logic. Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> --- osm/include/opensm/osm_partition.h | 29 + osm/opensm/osm_

[openib-general] [PATCH 6/10] osm: QoS in OpenSM

Compilation changes for QoS policy file parser - Added new files to makefiles. - Introduced new configuration switch '--enable-maintainer-mode', which will run Lex & Yacc instead of just using the generated files. Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]&

[openib-general] [PATCH 5/10] osm: QoS in OpenSM

QoS policy file parser C file with auxiliary functions Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> --- osm/opensm/osm_qos_parser.c | 548 +++ 1 files changed, 548 insertions(+), 0 deletions(-) diff --git a/osm/opensm/osm_qos_parser.c

[openib-general] [PATCH 4/10] osm: QoS in OpenSM

QoS policy file parser header file Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> --- osm/include/opensm/osm_qos_parser.h | 218 +++ 1 files changed, 218 insertions(+), 0 deletions(-) diff --git a/osm/include/opensm/osm_qos_parser.h b/osm/include/

[openib-general] [PATCH 2/10] osm: QoS in OpenSM

QoS policy file parser Lex file Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> --- osm/opensm/osm_qos_parser.l | 253 +++ 1 files changed, 253 insertions(+), 0 deletions(-) diff --git a/osm/opensm/osm_qos_parser.l b/osm/opensm/osm_qos_parser

[openib-general] [PATCH 0/10] osm: QoS in OpenSM

) This function will be used later by the PathRecord logic. 8. Added QoS class and service id fields to the path record. 9. Added new command line option for OSM: '-Y' or '--qos_policy_file' 10.Checking PathRecord query for QoS constraints. -- Yevgeny Signed-off-by

[openib-general] QoS in OSM

: > Hi again Yevgeny, > > On Thu, 2007-01-25 at 11:53, Yevgeny Kliteynik wrote: >> Hi Hal. >> >> Hal Rosenstock wrote: >>> Hi Yevgeny, >>> >>> On Wed, 2007-01-24 at 09:10, Yevgeny Kliteynik wrote: >>>> Hi Hal, Sasha. >>>> >&

Re: [openib-general] [PATCH 0/6] osm: QoS policy parser

Hi Hal. Hal Rosenstock wrote: > Hi Yevgeny, > > On Wed, 2007-01-24 at 09:10, Yevgeny Kliteynik wrote: >> Hi Hal, Sasha. >> >> Here's a description of the QoS policy file, and an >> example of such file (with more comments inside). > > This makes the

Re: [openib-general] [PATCH 0/6] osm: QoS policy parser

Hi Hal, Hal Rosenstock wrote: > Hi Yevgeny, > > On Wed, 2007-01-24 at 19:34, Yevgeny Kliteynik wrote: >> Hi Hal, >> >> Hal Rosenstock wrote: >>> Hi Yevgeny, >>> >>> On Wed, 2007-01-24 at 09:15, Yevgeny Kliteynik wrote: >>> >&

Re: [openib-general] [PATCH 0/6] osm: QoS policy parser

Hi Hal, Hal Rosenstock wrote: > Hi Yevgeny, > > On Wed, 2007-01-24 at 09:15, Yevgeny Kliteynik wrote: > > [snip...] > >>> I also have some questions about the patches >> Shoot > > First, as I understand it, this higher level QoS is not yet an appr

[openib-general] [PATCH v2] osm: QoS: added qos class and service id to the path record

Hi Hal [V2] QoS patch: added qos class and service id to the path record Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> --- osm/include/iba/ib_types.h | 148 ++--- osm/opensm/osm_helper.c |8 +- osm/opensm/osm_sa_multipath_re

Re: [openib-general] win related [was: Re: [PATCH 1/2] opensm: sigusr1: syslog() fixes]

Hi Hal, Hal Rosenstock wrote: > Hi Yevgeny, > > On Wed, 2007-01-24 at 01:26, Yevgeny Kliteynik wrote: >> Hi Hal, >> >> Hal Rosenstock wrote: >>> Hi again Yevgeny, >>> >>> On Tue, 2007-01-23 at 11:20, Yevgeny Kliteynik wrote: >>

Re: [openib-general] [PATCH 0/6] osm: QoS policy parser

Hi Hal, Hal Rosenstock wrote: > Hi Yevgeny, > > On Sun, 2007-01-21 at 03:46, Yevgeny Kliteynik wrote: >> Hi Sasha. >> >> Sasha Khapyorsky wrote: >>> Hi Yevgeny, >>> >>> On 17:01 Wed 17 Jan , Yevgeny Kliteynik wrote: >>>> H

Re: [openib-general] [PATCH 0/6] osm: QoS policy parser

ny Yevgeny Kliteynik wrote: > Hi Sasha, > > Sasha Khapyorsky wrote: >> On 10:46 Sun 21 Jan , Yevgeny Kliteynik wrote: >>> Hi Sasha. >>> >>> Sasha Khapyorsky wrote: >>>> Hi Yevgeny, >>>> >>>> On 17:01 Wed 17 Jan

Re: [openib-general] [PATCH 0/6] osm: QoS policy parser

ny Yevgeny Kliteynik wrote: > Hi Sasha, > > Sasha Khapyorsky wrote: >> On 10:46 Sun 21 Jan , Yevgeny Kliteynik wrote: >>> Hi Sasha. >>> >>> Sasha Khapyorsky wrote: >>>> Hi Yevgeny, >>>> >>>> On 17:01 Wed 17 Jan

Re: [openib-general] win related [was: Re: [PATCH 1/2] opensm: sigusr1: syslog() fixes]

Hi Hal, Hal Rosenstock wrote: > Hi again Yevgeny, > > On Tue, 2007-01-23 at 11:20, Yevgeny Kliteynik wrote: >> Hi Hal, >> >> Hal Rosenstock wrote: >>> Hi Yevgeny, >>> >>> On Sun, 2007-01-21 at 04:17, Yevgeny Kliteynik wrote: >>>&g

Re: [openib-general] [PATCH 0/6] osm: QoS policy parser

Hi Sasha, Sasha Khapyorsky wrote: > On 10:46 Sun 21 Jan , Yevgeny Kliteynik wrote: >> Hi Sasha. >> >> Sasha Khapyorsky wrote: >>> Hi Yevgeny, >>> >>> On 17:01 Wed 17 Jan , Yevgeny Kliteynik wrote: >>>> Hi Hal >>>> &g

Re: [openib-general] win related [was: Re: [PATCH 1/2] opensm: sigusr1: syslog() fixes]

Hi Hal, Hal Rosenstock wrote: > Hi Yevgeny, > > On Sun, 2007-01-21 at 04:17, Yevgeny Kliteynik wrote: >> Sasha Khapyorsky wrote: >>> On 18:24 Thu 11 Jan , Yevgeny Kliteynik wrote: >>>> As for the mailing list it's [EMAIL PROTECTED] You can access

Re: [openib-general] [PATCH] osm: QoS: added qos class and service id to the path record

Sasha Khapyorsky wrote: > Hi Yevgeny, > > On 18:05 Mon 22 Jan , Yevgeny Kliteynik wrote: >> Hi Hal >> >> QoS patch: added qos class and service id to the path record >> >> Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> > > Couple of c

[openib-general] [PATCH] osm: QoS: added qos class and service id to the path record

Hi Hal QoS patch: added qos class and service id to the path record Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> --- osm/include/iba/ib_types.h | 149 +++--- osm/opensm/osm_helper.c |8 +- osm/opensm/osm_sa_multipath_re

[openib-general] [PATCH] osm: bug in PathRecord.HopLimit access function

Hi Hal Fixing bug in PathRecord.HopLimit access function. Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> --- osm/include/iba/ib_types.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/osm/include/iba/ib_types.h b/osm/include/iba/ib_types.h index 26727df..2

[openib-general] [Fwd: Re: win related [was: Re: [PATCH 1/2] opensm: sigusr1: syslog() fixes]]

Khapyorsky <[EMAIL PROTECTED]> To: Michael S. Tsirkin <[EMAIL PROTECTED]> CC: Yevgeny Kliteynik <[EMAIL PROTECTED]>,OPENIB References: <[EMAIL PROTECTED]> <[EMAIL PROTECTED]> On 23:50 Thu 18 Jan , Michael S. Tsirkin wrote: > > Quoting Sasha Khapyorsky

Re: [openib-general] win related [was: Re: [PATCH 1/2] opensm: sigusr1: syslog() fixes]

Sasha Khapyorsky wrote: > On 18:24 Thu 11 Jan , Yevgeny Kliteynik wrote: >> As for the mailing list it's [EMAIL PROTECTED] You can access >> it here: http://openib.org/mailman/listinfo/openib-windows > > I found only references to svn://windows.openib

Re: [openib-general] [PATCH 0/6] osm: QoS policy parser

Hi Sasha. Sasha Khapyorsky wrote: > Hi Yevgeny, > > On 17:01 Wed 17 Jan , Yevgeny Kliteynik wrote: >> Hi Hal >> >> The following series of six patches implements QoS policy file parser: >> >> 1. QoS parser Lex file >> 2. QoS parser Lex-generate

[openib-general] [PATCH 6/6] osm: Compiling new QoS parser files

Hi Hal Patch for compiling new QoS parser files. Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> --- osm/include/Makefile.am |2 ++ osm/opensm/Makefile.am | 16 +++- osm/opensm/configure.in |4 3 files changed, 21 insertions(+), 1 deletions(-) diff --git

[openib-general] [PATCH 5/6] osm: QoS parser header file that defines parse tree data structures

Hi Hal This patch is a QoS parser header file that defines parse tree data structures. Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> --- osm/include/opensm/osm_qos_parser.h | 172 +++ 1 files changed, 172 insertions(+), 0 deletions(-) diff --git

[openib-general] [PATCH 1/6] osm: QoS parser Lex file

Hi Hal. This patch is QoS parser Lex file Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> --- osm/opensm/osm_qos_parser.l | 245 +++ 1 files changed, 245 insertions(+), 0 deletions(-) diff --git a/osm/opensm/osm_qos_parser.l b/osm/

[openib-general] [PATCH 0/6] osm: QoS policy parser

. Changes in makefiles and configure.in file for compiling QoS parser files -- Yevgeny Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-gener

Re: [openib-general] win related [was: Re: [PATCH 1/2] opensm: sigusr1: syslog() fixes]

Hi Sasha, Sasha Khapyorsky wrote: > Hi Yevgeny, > > On 09:47 Wed 10 Jan , Yevgeny Kliteynik wrote: >> Hi Sasha, >> >> Sasha Khapyorsky wrote: >>> Hi Yevgeny, >>> >>> On 12:05 Tue 09 Jan , Yevgeny Kliteynik wrote: >>>>

Re: [openib-general] win related [was: Re: [PATCH 1/2] opensm: sigusr1: syslog() fixes]

Hi Hal. Hal Rosenstock wrote: > Hi Yevgeny, > > On Wed, 2007-01-10 at 02:47, Yevgeny Kliteynik wrote: >> Hi Sasha, >> >> Sasha Khapyorsky wrote: >>> Hi Yevgeny, >>> >>> On 12:05 Tue 09 Jan , Yevgeny Kliteynik wrote: >>>>

Re: [openib-general] win related [was: Re: [PATCH 1/2] opensm: sigusr1: syslog() fixes]

Hi Sasha, Sasha Khapyorsky wrote: > Hi Yevgeny, > > On 12:05 Tue 09 Jan , Yevgeny Kliteynik wrote: >> Hi Sasha. >> Thanks for spotting this issue - I missed it when I reviewed the patch. >> Here's how things look in windows: >> * openlog() and closelog

Re: [openib-general] nightly osm_sim report 2007-01-06:normal completion

Eitan, I found this in the simulation log: -E- ibdiagnet failed with status: do_ypcall: clnt_call: RPC: Timed out YPBINDPROC_DOMAIN: Domain not bound All the logs look ok, including the ibdiagnet.log -- Yevgeny Eitan Zahavi wrote: > OSM Simulation Regression Summary > Open

[openib-general] [PATCH v2] osm: comparing InformInfo records

Hi Hal Here's the fixed InformInfo patch Yevgeny Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> Index: opensm/osm_inform.c === --- opensm/osm_inform.c (revision 10100) +++ opensm/osm_inform.c (working copy)

Re: [openib-general] [PATCH] osm: comparing InformInfo records

Hal Rosenstock wrote: > Hi Yevgeny, > > On Mon, 2006-11-06 at 02:00, Yevgeny Kliteynik wrote: >> Hi Hal >> >> [From Vu Pham] >> 1. sending InformInfo set subscribe for trap 64,65,144 - this works; >> however, osm.log outputs wrong value for "

[openib-general] [PATCH] osm: comparing InformInfo records

e memory allocated for it, including reserved fields. Fixed to compare more selectively. Yevgeny Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> Index: opensm/osm_sa_informinfo.c === --- opensm/osm_sa_informinfo

Re: [openib-general] [PATCH v2] opensm: strict osm_log arguments/format check

Looks ok, great. -- Yevgeny Sasha Khapyorsky wrote: > This adds gcc attribute to osm_log() which causes the compiler to check > argument types against a format string. And also there are related fixes > in osm_log() usage. > > Signed-off-by: Sasha Khapyorsky <[EMAIL PROTECTED]> > --- > osm/incl

Re: [openib-general] {PATCH] OpenSM: Add option for force SDR link speed

Looks good, thanks. -- Yevgeny Hal Rosenstock wrote: > OpenSM: Add option for force SDR link speed > > Add option to opensm.opts to force link speed. Currently, only forcing > to SDR link speed is supported. > > Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> > > Index: include/opensm/osm_su

Re: [openib-general] [PATCH] opensm: strict osm_log arguments/format check

Hi Sasha. Good catch with those missing arguments. One question: in several places you used cl_hton64() to print guid. Shouldn't there be cl_ntoh64() instead? ...and yes, I know that these two functions are actually the same macro :) Thanks -- Yevgeny Sasha Khapyorsky wrote: > This adds gcc

Re: [openib-general] [PATCH v2] opensm: remove obsolete p_report_buf

Hi Sasha. Looks good, thanks. -- Yevgeny Sasha Khapyorsky wrote: > This removes obsolete now shared sm->p_report_buf buffer and cleans > up related code. And also introduces new log function osm_log_printf() > which currently trivially sends formatted output to stdout. > > Signed-off-by: Sasha K

[openib-general] [PATCH] osm: fixing broken compilation on Windows

Fixing a broken compilation on windows (problems with data types). Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> Index: opensm/osm_ucast_file.c === --- opensm/osm_ucast_file.c (revision 10009) +++ opensm/osm_ucast_

[openib-general] [PATCH] osm: Trivial fix in osmtest

Fixing signed/unsigned data types problem (discovered on Windows) -- Yevgeny Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> Index: osmtest/osmt_multicast.c === --- osmtest/osmt_multicast.c(revision 9948) +++ o

Re: [openib-general] [PATCH] OpenSM/osm_ucast_updn.h: Eliminate superfluous header file

Looks good, thanks. -- Yevgeny > > OpenSM/osm_ucast_updn.h: Eliminate superfluous header file > > Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED] > > > Index: include/opensm/osm_ucast_updn.h > === > --- i

Re: [openib-general] [PATCH] opensm: remove obsolete p_report_buf

Sasha Khapyorsky wrote: > On 09:02 Mon 23 Oct , Yevgeny Kliteynik wrote: >> Hi Sasha. >> >> The removal of the sm->p_report_buf is a good idea. >> However, I do have one comment: >> In several cases this buffer was printed using the osm_log_raw() >&

[openib-general] [PATCH] osm: port to WinIB stack - osm_log.c

Hi Hal Fixing something that got lost in the porting - osm_log reports state for windows service. -- Yevgeny Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> Index: osm_log.c === --- osm_log.c (revision 9941) +++ osm

Re: [openib-general] [PATCH] opensm: remove obsolete p_report_buf

Hi Sasha. The removal of the sm->p_report_buf is a good idea. However, I do have one comment: In several cases this buffer was printed using the osm_log_raw() function, and you replaced this with a plain fprintf(stdout,...). Right now the osm_log_raw function just prints to stdout too, but this

Re: [openib-general] [PATCH] opensm: updn: make local functions static + local types

Hi Sasha. One small comments: [snip] > osm_updn_find_root_nodes_by_min_hop(OUT updn_t *p_updn); > ... > osm_updn_find_root_nodes_by_min_hop( > ... > osm_subn_set_up_down_min_hop_table( > ... > osm_subn_calc_up_down_min_hop_table( > ... Please add the "__" prefix to the static function

Re: [openib-general] [PATCH][TRIVIAL] osmtest/osmt_multicast.c: Eliminate superfluous clearing of some variables

Looks good, thanks. -- Yevgeny Hal Rosenstock wrote: > osmtest/osmt_multicast.c: Eliminate superfluous clearing of some > variables > > Also, some other cosmetic changes > > Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> > > Index: osmtest/osmt_multicast.c >

[openib-general] [PATCH] osm: reviewing osmtest - osmt_multicast.c

In case osmtest failed to remove some MC group, dumping all the MC groups that still remain, and their member. -- Yevgeny Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> Index: osmtest/osmt_multicast.c === --- o

Re: [openib-general] [PATCH] [TRIVIAL] OpenSM/osm_port_info_rcv.c: Remove duplicate dump of received PortInfo

Looks good. -- Yevgeny Hal Rosenstock wrote: > OpenSM/osm_port_info_rcv.c: Remove duplicate dump of received PortInfo > in osm_pi_rcv_process > > Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> > > Index: opensm/osm_port_info_rcv.c > ===

[openib-general] [PATCH] osm: port to WinIB stack - moving win-specific to config.h

Hi Hal As we discussed previously, I've added config.h in windows, and removed windows-specific defines from the common OSM files: opensm/osm_log.c opensm/osm_prtn.c opensm/osm_subnet.c -- Yevgeny Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> In

Re: [openib-general] [PATCH] osm: reviewing osmtest - osmt_multicast.c

Hal Rosenstock wrote: > On Tue, 2006-10-17 at 12:07, Yevgeny Kliteynik wrote: >> Hi Hal >> >> Fixing more things in the multicast test flow. >> >> Still have things to do in case when multicast group removal >> fails, and have to add some

[openib-general] [PATCH] osm: reviewing osmtest - osmt_multicast.c

Hi Hal Fixing more things in the multicast test flow. Still have things to do in case when multicast group removal fails, and have to add some cleanup (as we've discussed previously). -- Yevgeny Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> Index: osmtest/osmt_

[openib-general] [PATCHv2] osm: fixing OSM_LOG_DIR and OSM_CACHE_DIR treatment

Hi Hal. [snip] > > So will you supply another patch with this approach ? > > -- Hal Here it is. -- Yevgeny Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> Index: opensm/osm_db_files.c === --- ope

Re: [openib-general] [PATCH] osm: fixing OSM_LOG_DIR and OSM_CACHE_DIR treatment

Hal Rosenstock wrote: > On Mon, 2006-10-16 at 18:15, Yevgeny Kliteynik wrote: >> Sasha Khapyorsky wrote: >>> On 11:47 Mon 16 Oct , Yevgeny Kliteynik wrote: >>>> Hi Hal >>>> >>>> Leaving OSM_LOG_DIR or OSM_CACHE_DIR environment variables

Re: [openib-general] [PATCH] osm: fixing OSM_LOG_DIR and OSM_CACHE_DIR treatment

Sasha Khapyorsky wrote: > On 11:47 Mon 16 Oct , Yevgeny Kliteynik wrote: >> Hi Hal >> >> Leaving OSM_LOG_DIR or OSM_CACHE_DIR environment variables >> empty will cause OSM to wright log or cache files to / >> since OSM runs as root process. >> >&g

[openib-general] [PATCH] osm: fixing OSM_LOG_DIR and OSM_CACHE_DIR treatment

mistake on my machine), empty variable should be treated as if it is not set. If a user wants the SM to write something to /, he should specify this explicitly by setting "/" as an env. variable value. -- Yevgeny Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> Index: opens

Re: [openib-general] [PATCH] opensm: mcast tables dump improvement

Hi Sasha. Looks good. One remark though: all the static functions should have the "__osm_" prefix in their names. -- Yevgeny Sasha Khapyorsky wrote: > This improves switch's mcast tables dumping and eliminates multiple file > open/seek/close sequences. In one word - cleanup. > > Signed-off-by

Re: [openib-general] [PATCH] osm: port to WinIB stack - 64 bits

Sasha Khapyorsky wrote: > On 17:45 Sun 15 Oct , Yevgeny Kliteynik wrote: >> Hi Sasha, >> >> Sasha Khapyorsky wrote: >>> Hi Evgeny, >>> >>> On 16:31 Sun 15 Oct , Yevgeny Kliteynik wrote: >>>> Hi Hal >>>> >>

Re: [openib-general] [PATCH] osm: port to WinIB stack - 64 bits

Hi Sasha, Sasha Khapyorsky wrote: > Hi Evgeny, > > On 16:31 Sun 15 Oct , Yevgeny Kliteynik wrote: >> Hi Hal >> >> This patch fixes a few data type problems with OSM on >> 64-bit Windows machines. > > Could you explain what those problems are? Basica

Re: [openib-general] [PATCH] OpenSM/osmtest.c: Fix float calculation in osmtest_stress_large_rmpp_pr

Good catch, thanks. -- Yevgeny Hal Rosenstock wrote: > OpenSM/osmtest.c: Fix float calculation in osmtest_stress_large_rmpp_pr > > Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> > --- > Index: osmtest/osmtest.c > === > --- osmtes

Re: [openib-general] [PATCH] osm: reviewing osmtest - osmt_multicast.c

Hal Rosenstock wrote: > On Wed, 2006-10-11 at 06:23, Yevgeny Kliteynik wrote: >> Hi Hal >> >> Fixing a few problems in the multicast test flow, >> plus some cosmetics. >> >> Yevgeny >> >> Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]>

[openib-general] [PATCH] osm: port to WinIB stack - 64 bits

, or index in string, so it's ok to 'downcast' the value. The patch is for trunk only. Yevgeny Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> Index: opensm/osm_prtn_config.c === --- opensm/osm_prtn_confi

Re: [openib-general] [PATCHv2 7/13] osm: port to WinIB stack : opensm/osm_ucast_file.c

Hi Hal. Hal Rosenstock wrote: > On Tue, 2006-10-10 at 02:16, Yevgeny Kliteynik wrote: >> Great, thanks. >> >> Now only one patch left > > I think there was one more in addition that was agreed to: > Add Windows defines to config.h and remove from various opensm file

[openib-general] [PATCH] osm: reviewing osmtest - osmt_multicast.c

Hi Hal Fixing a few problems in the multicast test flow, plus some cosmetics. Yevgeny Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> Index: osmt_multicast.c === --- osmt_multicast.c(revision 9776) +++ osmt_multi

[openib-general] [PATCH] osm: reviewing osmtest - osmtest.c

ned-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> Index: osmtest.c === --- osmtest.c (revision 9776) +++ osmtest.c (working copy) @@ -582,12 +582,9 @@ osmtest_query_res_cb( IN osmv_query_res_ if( p_rec->status != IB_SUC

[openib-general] [PATCHv2 2/13] osm: port to WinIB stack : opensm/osm_prtn_config.c

Hi Hal This is the re-submission of the patch that was originally sibmitted by Eitan - avoiding varargs macros not supported by Windows. Yevgeny Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> Index: osm_prtn_co

Re: [openib-general] [PATCHv2 7/13] osm: port to WinIB stack : opensm/osm_ucast_file.c

Sun, 2006-10-08 at 11:42, Yevgeny Kliteynik wrote: >> Hi Hal >> >> This is the re-submission of the patch that was >> originally sibmitted by Eitan - just removing some >> cosmetic changes from the patch and re-diffing it >> with the trunk: >> >> 1.

[openib-general] [PATCHv2 7/13] osm: port to WinIB stack : opensm/osm_ucast_file.c

: Yevgeny Kliteynik <[EMAIL PROTECTED]> Index: opensm/osm_ucast_file.c === --- opensm/osm_ucast_file.c (revision 9738) +++ opensm/osm_ucast_file.c (working copy) @@ -52,18 +52,11 @@ #include #include +#include #i

Re: [openib-general] [PATCH 7/13] osm: port to WinIB stack : opensm/osm_ucast_file.c

Hi Sasha [snip] >> --- opensm/osm_ucast_file.c (revision 9502) >> +++ opensm/osm_ucast_file.c (working copy) >> @@ -52,18 +52,11 @@ >> >> #include >> #include >> +#include > > Why this? This is where PRIx64 is defined in Windows. [snip] >> #include >> #include >> #include >> >>

[openib-general] [PATCH] osm: fixing some comments

Hi Hal Just a couple of wrong comments that I found while reading the code. Yevgeny Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> Index: include/opensm/osm_port.h === --- include/opensm/osm_port.h (revisio

[openib-general] [PATCH 2/2] osm: osmtest ignores error status

Hi Hal. This patch takes care of several cases where osmtest ignored error status (plus some cosmetics). Yevgeny Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> Index: osmt_service.c === --- osmt_service.c (re

[openib-general] [PATCH 1/2] osm: osmtest ignores error status

Hi Hal. This patch takes care of several cases where osmtest ignored error status. Yevgeny Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> Index: osmt_slvl_vl_arb.c === --- osmt_slvl_vl_arb.c (revisio

[openib-general] [PATCH] osm: cosmetic changes in osmtest multicast flow

Hi Hal This patch is all about cosmetics - it improves the osmtest log readability, and it also has some cosmetic additions in the code. Yevgeny Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> Index: osmtest/osmt_multi

Re: [openib-general] [PATCH] OpenSM/osm_sa_mcmember_record.c: In osm_mcmr_rcv_create_new_mgrp, fix exactly selectors in response

Hi Hal. The patch looks ok. A few remarks thought: It appears that the multicast group mtu/rate selectors are actually not referenced by anyone - the SM/SA code implicitly assumes that they should be 'exact', and acts accordingly. Same goes for the response - the selectors that are filled in ar

Re: [openib-general] [PATCH][TRIVIAL]OpenSM/osm_node_info_rcv.c: Eliminate superfluous call level

Hi Hal. The patch looks OK. Regards, -- Yevgeny On Tue, 2006-09-19 at 09:25 -0400, Hal Rosenstock wrote: OpenSM/osm_node_info_rcv.c: Eliminate superfluous call level Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> Index: opensm/osm_node_info_rcv.c ===

[openib-general] [PATCHv2] osm: fixing bugs in osmtest

Hi Hal It appears that each mailer is messing with white spaces in its own very special way... Anyway, this time it is ok for sure. Yevgeny Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> Index: osmtest/include/osm

[openib-general] [PATCH] osm: fixing bugs in osmtest

e and osmtest log readability. More patches expected. This patch is for trunk only. I tested applying this patch before sending it. If you get the patch rejected again - let me know. Thanks. Yevgeny Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> Index: osmtest/includ

Re: [openib-general] [PATCH] osm: bug in OpenSM on broken fabrics

Hi Hal. Please apply this patch both to trunk and 1.1. Thanks. -- Yevgeny > Hi Yevgeny, > > On Mon, 2006-09-18 at 14:52, Yevgeny Kliteynik wrote: > > Hi Hal > > > > This patch fixes a bug in opensm that was discovered on > > a 'broken&

[openib-general] [PATCH] osm: bug in OpenSM on broken fabrics

Hi Hal This patch fixes a bug in opensm that was discovered on a 'broken' fabrics when opensm was executed with --stay_on_fatal. Replacing assert with a real check. Yevgeny Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> Index: opensm/osm

[openib-general] [PATCH] osm: bug in __osmv_send_sa_req

Hi Hal This patch fixes a bug is __osmv_send_sa_req in libvendor. After sending a MAD, the status of the responce was ignored. Yevgeny Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> Index: libvendor/osm_vendor_ibuma

[openib-general] [PATCH] osm: OSM bug fix with --run-once option

: Yevgeny Kliteynik <[EMAIL PROTECTED]> Index: opensm/main.c === --- opensm/main.c (revision 9354) +++ opensm/main.c (working copy) @@ -908,9 +908,13 @@ main( if( run_once_flag == TRUE ) { -

[openib-general] [PATCH] osm: TRIVIAL fix in usage message

Hi Hal. This patch is just fixing some error in the OSM usage message. Instead of old '-vf' option, there should be '-D'. Thanks. Yevgeny Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> Index: osm/opensm/main.c =

[openib-general] [PATCH] osm: TRIVIAL code cleanup

: Yevgeny Kliteynik <[EMAIL PROTECTED]> Index: include/opensm/osm_sa_mcmember_record.h === --- include/opensm/osm_sa_mcmember_record.h (revision 9107) +++ include/opensm/osm_sa_mcmember_record.h (working copy) @@ -374,12 +

[openib-general] [PATCHv2] osm: Dynamic verbosity control per file

Hi Hal. This is a resubmission of the patch that addresses the comments that I got on the first version - using osm-log.conf file instead of opensmlog.conf and osm man page update. Yevgeny Signed-off-by: Yevgeny Kliteynik <[EMAIL PROTECTED]> Index: include/opensm/osm_su

Re: [openib-general] [PATCH] osm: Dynamic verbosity control per file

e verbosity configuration file. > > > > > > 2. Logging source code filename and line number > > --- > > > > If command line option -S or --log_source_info is specified, > > OSM will add source code file

  1   2   >