Thanks for the feedback.
On Tue, 28 Sep 2004 13:21:51 -0700 (PDT)
Krishna Kumar <[EMAIL PROTECTED]> wrote:
> In cancel_mads() :
> > if (mad_send_wr->refcount <= 0) {
>
> If there is no good reason for the refcount to drop below zero, it is
> better to put BUG_ON for such code to catch potential b
On Tue, 28 Sep 2004 12:50:52 -0700
Roland Dreier <[EMAIL PROTECTED]> wrote:
> It looks OK for current functionality but I think it will have to
> change to support cancelling sends. (Cancelling sends is required
> for consumers that start a query with a long timeout and then want to
> unload or s
Sean,
I have a couple of questions regarding your patch, not real problems :-)
In cancel_mads() :
> if (mad_send_wr->refcount <= 0) {
If there is no good reason for the refcount to drop below zero, it is
better to put BUG_ON for such code to catch potential bugs much earlier,
while keeping the c
Sean> This patch should allow canceling of sent MADs when
Sean> deregistration occurs. This seemed a little trickier (to
Sean> keep simple anyway) than I thought at first, so comments are
Sean> welcome.
It looks OK for current functionality but I think it will have to
change to su
This patch should allow canceling of sent MADs when deregistration occurs. This
seemed a little trickier (to keep simple anyway) than I thought at first, so comments
are welcome.
- Sean
--
Index: access/ib_mad_priv.h
===
--- acce
