Re: [openib-general] [PATCH] for OFED 1.2

2007-02-27 Thread Michael S. Tsirkin
> Quoting Sasha Khapyorsky <[EMAIL PROTECTED]>: > Subject: Re: [PATCH] for OFED 1.2 > > On 19:44 Tue 27 Feb , Michael S. Tsirkin wrote: > > > Quoting Sean Hefty <[EMAIL PROTECTED]>: > > > Subject: Re: [PATCH] for OFED 1.2 > > > > > > >I think with stacked git or just git and rebasing at key t

Re: [openib-general] [PATCH] for OFED 1.2

2007-02-27 Thread Sasha Khapyorsky
On 19:44 Tue 27 Feb , Michael S. Tsirkin wrote: > > Quoting Sean Hefty <[EMAIL PROTECTED]>: > > Subject: Re: [PATCH] for OFED 1.2 > > > > >I think with stacked git or just git and rebasing at key times, you > > >could keep an ofed_1_2 tree that folks can easily apply patches to... > > > > > >I

Re: [openib-general] [PATCH] for OFED 1.2

2007-02-27 Thread Sean Hefty
> I think it'll be much more work to maintain all these branches. > And again, there will be conflicts, and it's too easy to get confused when > resolving a conflict. Storing patches in a directory seems confusing to me. They must be applied in a specific order for everything to work, and that

Re: [openib-general] [PATCH] for OFED 1.2

2007-02-27 Thread Michael S. Tsirkin
> Quoting Sean Hefty <[EMAIL PROTECTED]>: > Subject: RE: [PATCH] for OFED 1.2 > > >But you cannot keep a stack for more than one backport pushed, right? > >So you still need to be slapping the stacks of patches around for each > >backport. > > Why not have separate branches for each kernels too?

Re: [openib-general] [PATCH] for OFED 1.2

2007-02-27 Thread Michael S. Tsirkin
> Quoting Steve Wise <[EMAIL PROTECTED]>: > Subject: Re: [PATCH] for OFED 1.2 > > > > > > > > > Sean, please install quilt and try using it for working with the system. > > > > Adding new patch is usually done in this way > > > > quilt new > > > > quilt add > > > > edit > > > > quilt refresh >

Re: [openib-general] [PATCH] for OFED 1.2

2007-02-27 Thread Sean Hefty
>But you cannot keep a stack for more than one backport pushed, right? >So you still need to be slapping the stacks of patches around for each >backport. Why not have separate branches for each kernels too? ___ openib-general mailing list openib-general

Re: [openib-general] [PATCH] for OFED 1.2

2007-02-27 Thread Steve Wise
> > > > > > Sean, please install quilt and try using it for working with the system. > > > Adding new patch is usually done in this way > > > quilt new > > > quilt add > > > edit > > > quilt refresh > > > > > > cp patches/ kernel_patches/fixes/ > > > git add kernel_patches/fixes/ > > > git comm

Re: [openib-general] [PATCH] for OFED 1.2

2007-02-27 Thread Michael S. Tsirkin
> > Lot's of stuff *is* in wiki already - did you look at pages Vlad > > created? > > A search for "quilt" on the wiki turns up nothing (I checked before I > posted :-) ). > > And yes, I have [thoroughly] read the pages Vlad created. But the > very fact that this conversation is occurring

Re: [openib-general] [PATCH] for OFED 1.2

2007-02-27 Thread Michael S. Tsirkin
> > This is just my $0.01... > > It buys very little, if anything. In fact, a whole $0.02 also buys > very little, if anything. So take my comments for what they're worth. Oh, good, I thought deflation is getting out of hand ... -- MST ___ op

Re: [openib-general] [PATCH] for OFED 1.2

2007-02-27 Thread Michael S. Tsirkin
> Quoting Steve Wise <[EMAIL PROTECTED]>: > Subject: Re: [PATCH] for OFED 1.2 > > On Tue, 2007-02-27 at 19:44 +0200, Michael S. Tsirkin wrote: > > > Quoting Sean Hefty <[EMAIL PROTECTED]>: > > > Subject: Re: [PATCH] for OFED 1.2 > > > > > > >I think with stacked git or just git and rebasing at ke

Re: [openib-general] [PATCH] for OFED 1.2

2007-02-27 Thread Jeff Squyres
On Feb 27, 2007, at 12:45 PM, Michael S. Tsirkin wrote: > Lot's of stuff *is* in wiki already - did you look at pages Vlad > created? A search for "quilt" on the wiki turns up nothing (I checked before I posted :-) ). And yes, I have [thoroughly] read the pages Vlad created. But the very

Re: [openib-general] [PATCH] for OFED 1.2

2007-02-27 Thread Steve Wise
On Tue, 2007-02-27 at 19:44 +0200, Michael S. Tsirkin wrote: > > Quoting Sean Hefty <[EMAIL PROTECTED]>: > > Subject: Re: [PATCH] for OFED 1.2 > > > > >I think with stacked git or just git and rebasing at key times, you > > >could keep an ofed_1_2 tree that folks can easily apply patches to... > >

Re: [openib-general] [PATCH] for OFED 1.2

2007-02-27 Thread Michael S. Tsirkin
> This is just my $0.01... Thanks for the suggestions, but what does $0.01 buy one in US today? -- MST ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit ht

Re: [openib-general] [PATCH] for OFED 1.2

2007-02-27 Thread Michael S. Tsirkin
s that are helpful for OFA/ OFED development, they should be detailed on the wiki. The wiki is where all permanent knowledge should be posted. This is just my $0.01... On Feb 27, 2007, at 12:31 PM, Michael S. Tsirkin wrote: >> Quoting Steve Wise <[EMAIL PROTECTED]>: >> Su

Re: [openib-general] [PATCH] for OFED 1.2

2007-02-27 Thread Michael S. Tsirkin
> Quoting Sean Hefty <[EMAIL PROTECTED]>: > Subject: Re: [PATCH] for OFED 1.2 > > >I think with stacked git or just git and rebasing at key times, you > >could keep an ofed_1_2 tree that folks can easily apply patches to... > > > >Its too late to change this for 1.2, but you might want to reconsid

Re: [openib-general] [PATCH] for OFED 1.2

2007-02-27 Thread Jeff Squyres
. Tsirkin wrote: >> Quoting Steve Wise <[EMAIL PROTECTED]>: >> Subject: Re: [openib-general] [PATCH] for OFED 1.2 >> >> On Tue, 2007-02-27 at 18:55 +0200, Michael S. Tsirkin wrote: >>>> Quoting Sean Hefty <[EMAIL PROTECTED]>: >>>> Subject: Re

Re: [openib-general] [PATCH] for OFED 1.2

2007-02-27 Thread Sean Hefty
>I think with stacked git or just git and rebasing at key times, you >could keep an ofed_1_2 tree that folks can easily apply patches to... > >Its too late to change this for 1.2, but you might want to reconsider >the design for 1.3. Can't we just create a new branch (ofed_1_2_patched) with these

Re: [openib-general] [PATCH] for OFED 1.2

2007-02-27 Thread Michael S. Tsirkin
> Quoting Steve Wise <[EMAIL PROTECTED]>: > Subject: Re: [openib-general] [PATCH] for OFED 1.2 > > On Tue, 2007-02-27 at 18:55 +0200, Michael S. Tsirkin wrote: > > > Quoting Sean Hefty <[EMAIL PROTECTED]>: > > > Subject: Re: [PATCH] for OFED 1.2 >

Re: [openib-general] [PATCH] for OFED 1.2

2007-02-27 Thread Steve Wise
On Tue, 2007-02-27 at 18:55 +0200, Michael S. Tsirkin wrote: > > Quoting Sean Hefty <[EMAIL PROTECTED]>: > > Subject: Re: [PATCH] for OFED 1.2 > > > > >Please send patches that will be added to kernel_patches/fixes. > > > > > >Please update your git tree from > > >git://git.openfabrics.org/~vlad/o

Re: [openib-general] [PATCH] for OFED 1.2

2007-02-27 Thread Michael S. Tsirkin
> Quoting Sean Hefty <[EMAIL PROTECTED]>: > Subject: Re: [PATCH] for OFED 1.2 > > >Yes, actual patches should be created under kernel_patches/fixes. > > > >Please update your git tree because the following patch fails: > > Can you explain how the patch fails? I don't see how putting the patch in

Re: [openib-general] [PATCH] for OFED 1.2

2007-02-27 Thread Sean Hefty
>Yes, actual patches should be created under kernel_patches/fixes. > >Please update your git tree because the following patch fails: Can you explain how the patch fails? I don't see how putting the patch into a file helps. >> Why not apply the patches directly? >> >To be consistent with 2.6.20 k

Re: [openib-general] [PATCH] for OFED 1.2

2007-02-27 Thread Michael S. Tsirkin
> Quoting Sean Hefty <[EMAIL PROTECTED]>: > Subject: Re: [PATCH] for OFED 1.2 > > >Please send patches that will be added to kernel_patches/fixes. > > > >Please update your git tree from > >git://git.openfabrics.org/~vlad/ofed_1_2/.git ofed_1_2 > > You want me to create a patch that adds a file

Re: [openib-general] [PATCH] for OFED 1.2

2007-02-27 Thread Vladimir Sokolovsky
On Tue, 2007-02-27 at 08:45 -0800, Sean Hefty wrote: > >Please send patches that will be added to kernel_patches/fixes. > > > >Please update your git tree from > >git://git.openfabrics.org/~vlad/ofed_1_2/.git ofed_1_2 > > You want me to create a patch that adds a file that contains the actual >

Re: [openib-general] [PATCH] for OFED 1.2

2007-02-27 Thread Sean Hefty
>Please send patches that will be added to kernel_patches/fixes. > >Please update your git tree from >git://git.openfabrics.org/~vlad/ofed_1_2/.git ofed_1_2 You want me to create a patch that adds a file that contains the actual patches? Why not apply the patches directly? _

Re: [openib-general] [PATCH] for OFED 1.2

2007-02-27 Thread Vladimir Sokolovsky
On Mon, 2007-02-26 at 09:46 -0800, Sean Hefty wrote: > Vladimir Sokolovsky wrote: > > On Fri, 2007-02-23 at 12:15 -0800, Sean Hefty wrote: > > > I would like these fixes in OFED 1.2 as well. What git tree / branch > > do I > > > generate a patch against? > > > > > > - Sean > > > > git://git.

Re: [openib-general] [PATCH] for OFED 1.2

2007-02-26 Thread Sean Hefty
Vladimir Sokolovsky wrote: > On Fri, 2007-02-23 at 12:15 -0800, Sean Hefty wrote: > > I would like these fixes in OFED 1.2 as well. What git tree / branch > do I > > generate a patch against? > > > > - Sean > > git://git.openfabrics.org/~vlad/ofed_1_2/.git > branch: ofed_1_2 Can you try pul

Re: [openib-general] [PATCH] for OFED 1.2

2007-02-25 Thread Vladimir Sokolovsky
On Fri, 2007-02-23 at 12:15 -0800, Sean Hefty wrote: > I would like these fixes in OFED 1.2 as well. What git tree / branch do I > generate a patch against? > > - Sean git://git.openfabrics.org/~vlad/ofed_1_2/.git branch: ofed_1_2 - Vladimir > > --- > > rdma_cm: remove unused node_guid from

[openib-general] [PATCH] for OFED 1.2

2007-02-23 Thread Sean Hefty
I would like these fixes in OFED 1.2 as well. What git tree / branch do I generate a patch against? - Sean --- rdma_cm: remove unused node_guid from cma_device structure. ib_cm: remove ca_guid from cm_device structure. rdma_cm: request reversible paths only. ib_core: Set hop limit in ib_init_ah