Re: [openib-general] [RFC] [PATCH v2] IB/ipoib: Add bonding support to IPoIB

2007-02-27 Thread Michael S. Tsirkin
> Quoting Moni Shoua <[EMAIL PROTECTED]>: > Subject: Re: [RFC] [PATCH v2] IB/ipoib: Add bonding support to IPoIB > > > Thanks for the comments > > >> To fix it, this patch adds a dev field to struct ipoib_neigh which is used > >> instead of the struct neighbour dev one. > > > > It seems that i

Re: [openib-general] [RFC] [PATCH v2] IB/ipoib: Add bonding support to IPoIB

2007-02-27 Thread Moni Shoua
Thanks for the comments >> To fix it, this patch adds a dev field to struct ipoib_neigh which is used >> instead of the struct neighbour dev one. > > It seems that in this design, if multiple ipoib interfaces are present, we > might > get an skb such that skb->dev will be different from the ne

Re: [openib-general] [RFC] [PATCH v2] IB/ipoib: Add bonding support to IPoIB

2007-02-26 Thread Michael S. Tsirkin
> When using the bonding driver, neighbours are created by the net stack on > behalf > of the bonding (master) device. On the tx flow the bonding code gets an skb > such > that skb->dev points to the master device, it changes this skb to point on the > slave device and calls the slave hard_start_

Re: [openib-general] [RFC] [PATCH v2] IB/ipoib: Add bonding support to IPoIB

2007-02-26 Thread Michael S. Tsirkin
> > During my tests I found that when running > > 1. modprobe -r ib_mthca (to delete IPoIB interfaces) > 2. ping somewhere on the subnet of bond0 > > I get this stack dump (which ends with kernel death) >[] skb_under_panic+0x5c/0x60 >[] :ib_ipoib:ipoib_hard_header+0x

[openib-general] [RFC] [PATCH v2] IB/ipoib: Add bonding support to IPoIB

2007-02-26 Thread Moni Shoua
Hi, This post follows a previous one, regarding required changes to IPoIB to enable it to work with bonding. Please find it here: http://openib.org/pipermail/openib-general/2007-February/032598.html This patch version adds fixes to the comments from Michael Tsirkin from the last post. IPoIB us