[openib-general] Re: [PATCH] request/response matching in MAD code

2004-10-04 Thread Sean Hefty
On Mon, 04 Oct 2004 11:53:21 -0400 Hal Rosenstock <[EMAIL PROTECTED]> wrote: > It is a minor efficiency gain. The downside is the following: > If the client sets the hi_tid wrong (not corresponding to the mad_agent > supplied), the response either gets thrown away (if there is no hi_tid > match) o

[openib-general] Re: [PATCH] request/response matching in MAD code

2004-10-04 Thread Hal Rosenstock
On Fri, 2004-10-01 at 12:41, Sean Hefty wrote: > On Fri, 01 Oct 2004 12:33:44 -0400 > Hal Rosenstock <[EMAIL PROTECTED]> wrote: > > Also, should the TID be overwritten in the high 32 bits or do we trust > > the client to set this properly ? > > Based on our previous discussions on this, clients ar

[openib-general] Re: [PATCH] request/response matching in MAD code

2004-10-02 Thread Hal Rosenstock
On Fri, 2004-10-01 at 12:41, Sean Hefty wrote: > On Fri, 01 Oct 2004 12:33:44 -0400 > Hal Rosenstock <[EMAIL PROTECTED]> wrote: > > 2. Added the following to reassemble_recv (it was eliminated from > > ib_mad_recv_done_handler): > > > > INIT_LIST_HEAD(&recv->header.recv_buf.list); > > I w

[openib-general] Re: [PATCH] request/response matching in MAD code

2004-10-01 Thread Sean Hefty
On Fri, 01 Oct 2004 12:33:44 -0400 Hal Rosenstock <[EMAIL PROTECTED]> wrote: > mad_send_wr->tid = ((struct ib_mad_hdr*) > bus_to_virt(cur_send_wr->sg_list->addr))->tid; Thanks - good catch. > 2. Added the following to reassemble_recv (it was elimi

[openib-general] Re: [PATCH] request/response matching in MAD code

2004-10-01 Thread Hal Rosenstock
On Thu, 2004-09-30 at 15:16, Sean Hefty wrote: > The following patch should match response MADs with the corresponding request. A > response without a matching request is discarded, and responses are reported before > requests. > > Timeouts of request MADs are not yet handled. Thanks! Applied