OK, I pulled this in to my for-2.6.21 branch and I will ask Linus to
pull later today.
Thanks.
- R.
___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general
To unsubscribe, please visit
Roland Dreier wrote:
OK, I pulled this in to my for-2.6.21 branch and I will ask Linus to
pull later today.
Thanks for the review.
___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general
To
Or Gerlitz wrote:
Roland Dreier wrote:
I merged the increment port number and remove redundant '_wq'
patches from git.openfabrics.org/~shefty/scm/rdma-dev.git for-roland
I plan to review to multicast stuff next week and I hope to merge it
for 2.6.21. Or, have you or anyone else at Voltaire
Roland Dreier wrote:
I merged the increment port number and remove redundant '_wq'
patches from git.openfabrics.org/~shefty/scm/rdma-dev.git for-roland
I plan to review to multicast stuff next week and I hope to merge it
for 2.6.21. Or, have you or anyone else at Voltaire read over the
+
It seems same goes for
+ mc = kzalloc(sizeof(*mc), GFP_KERNEL);
+ if (!mc)
+ return NULL;
We would need to set events_reported.
IMO, probably worth it to init just this one field rather than use up
initialized memory - and I think it's clearer.
--
IMO, probably worth it to init just this one field rather than use up
initialized memory - and I think it's clearer.
What do you mean by using up initialized memory? kzalloc() just does
a memset(0), and it's not like there's a limit on the number of times
we're allowed to call memset().
-
Quoting Roland Dreier [EMAIL PROTECTED]:
Subject: Re: please pull for 2.6.21: fix + add IB multicast support
I merged the increment port number and remove redundant '_wq'
patches from git.openfabrics.org/~shefty/scm/rdma-dev.git for-roland
I plan to review to multicast stuff next week and
On 2/9/07, Roland Dreier [EMAIL PROTECTED] wrote:
I plan to review to multicast stuff next week and I hope to merge it for
2.6.21
thanks, good news!
Or, have you or anyone else at Voltaire read over the
code in addition to using it? Do you see anything that should be
cleaned up?
OK, I
Or, have you or anyone else at Voltaire read over the
code in addition to using it? Do you see anything that should be
cleaned up?
OK, I most the the review i did (and interaction with Sean to add changes) was
on the rdma_cm: add multicast communication support patch, and i was
less
+ member = kzalloc(sizeof *member, gfp_mask);
+ if (!member)
+ return ERR_PTR(-ENOMEM);
This appears okay to replace with kmalloc.
+ group = kzalloc(sizeof *group, gfp_mask);
+ if (!group)
+ return NULL;
+
We would need additional
Or Gerlitz wrote:
Sean Hefty wrote:
Sean Hefty (3):
rdma_cm: Increment port number after close to avoid re-use.
ib_sa: track multicast join/leave requests
rdma_cm: add multicast communication support
Assuming that you haven't look at this yet, I updated the ib_sa patch
I merged the increment port number and remove redundant '_wq'
patches from git.openfabrics.org/~shefty/scm/rdma-dev.git for-roland
I plan to review to multicast stuff next week and I hope to merge it
for 2.6.21. Or, have you or anyone else at Voltaire read over the
code in addition to using it?
Sean Hefty wrote:
Sean Hefty (3):
rdma_cm: Increment port number after close to avoid re-use.
ib_sa: track multicast join/leave requests
rdma_cm: add multicast communication support
Assuming that you haven't look at this yet, I updated the ib_sa patch
above to shorten
Can you comment on the multicast changes merge for 2.6.21 status?
Where are the final patches that you want to merge?
- R.
___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general
To unsubscribe,
Can you comment on the multicast changes merge for 2.6.21 status?
Where are the final patches that you want to merge?
Try the for-roland branch at git.openfabrics.org/~shefty/scm/rdma-dev.git. If
this doesn't work, or you hit any snags, let me know, and I'll try to correct
any issues so that
Sean Hefty (3):
rdma_cm: Increment port number after close to avoid re-use.
ib_sa: track multicast join/leave requests
rdma_cm: add multicast communication support
Assuming that you haven't look at this yet, I updated the ib_sa patch above to
shorten the workqueue name,
Roland,
I've created a 'for-roland' branch off of my git tree:
git://git.openfabrics.org/~shefty/rdma-dev.git
with the following changes:
Sean Hefty (3):
rdma_cm: Increment port number after close to avoid re-use.
ib_sa: track multicast join/leave requests
rdma_cm: add
17 matches
Mail list logo
