Re: [Openipmi-developer] [PATCH v2 1/1] kernel.h: Split out panic and oops helpers

2021-04-09 Thread Thomas Bogendoerfer
On Fri, Apr 09, 2021 at 01:02:50PM +0300, Andy Shevchenko wrote: > kernel.h is being used as a dump for all kinds of stuff for a long time. > Here is the attempt to start cleaning it up by splitting out panic and > oops helpers. > > There are several purposes of doing this: > - dropping

Re: [Openipmi-developer] [PATCH v2 1/1] kernel.h: Split out panic and oops helpers

2021-04-09 Thread Helge Deller
On 4/9/21 12:02 PM, Andy Shevchenko wrote: kernel.h is being used as a dump for all kinds of stuff for a long time. Here is the attempt to start cleaning it up by splitting out panic and oops helpers. There are several purposes of doing this: - dropping dependency in bug.h - dropping a loop by

Re: [Openipmi-developer] [PATCH v2 10/21] ipmi: kcs_bmc: Turn the driver data-structures inside-out

2021-04-09 Thread Zev Weiss
On Fri, Apr 09, 2021 at 01:25:26AM CDT, Zev Weiss wrote: >On Fri, Apr 09, 2021 at 12:59:09AM CDT, Andrew Jeffery wrote: >> >> >>On Fri, 9 Apr 2021, at 13:27, Zev Weiss wrote: >>>On Fri, Mar 19, 2021 at 01:27:41AM CDT, Andrew Jeffery wrote: Make the KCS device drivers responsible for allocating

Re: [Openipmi-developer] [PATCH v2 09/21] ipmi: kcs_bmc: Split out kcs_bmc_cdev_ipmi

2021-04-09 Thread Zev Weiss
On Fri, Apr 09, 2021 at 12:48:21AM CDT, Andrew Jeffery wrote: > > >On Fri, 9 Apr 2021, at 13:26, Zev Weiss wrote: >> On Fri, Mar 19, 2021 at 01:27:40AM CDT, Andrew Jeffery wrote: >> >Take steps towards defining a coherent API to separate the KCS device >> >drivers from the userspace interface.

Re: [Openipmi-developer] [PATCH v2 1/1] kernel.h: Split out panic and oops helpers

2021-04-09 Thread Stephen Boyd
Quoting Andy Shevchenko (2021-04-09 03:02:50) > kernel.h is being used as a dump for all kinds of stuff for a long time. > Here is the attempt to start cleaning it up by splitting out panic and > oops helpers. > > There are several purposes of doing this: > - dropping dependency in bug.h > -

Re: [Openipmi-developer] [PATCH v2 1/1] kernel.h: Split out panic and oops helpers

2021-04-09 Thread Luis Chamberlain
On Fri, Apr 09, 2021 at 01:02:50PM +0300, Andy Shevchenko wrote: > kernel.h is being used as a dump for all kinds of stuff for a long time. > Here is the attempt to start cleaning it up by splitting out panic and > oops helpers. > > There are several purposes of doing this: > - dropping

Re: [Openipmi-developer] [PATCH v2 1/1] kernel.h: Split out panic and oops helpers

2021-04-09 Thread Sebastian Reichel
Hi, On Fri, Apr 09, 2021 at 01:02:50PM +0300, Andy Shevchenko wrote: > kernel.h is being used as a dump for all kinds of stuff for a long time. > Here is the attempt to start cleaning it up by splitting out panic and > oops helpers. > > There are several purposes of doing this: > - dropping

Re: [Openipmi-developer] [PATCH v2 16/21] ipmi: kcs_bmc: Add a "raw" character device interface

2021-04-09 Thread Arnd Bergmann
On Fri, Mar 19, 2021 at 7:31 AM Andrew Jeffery wrote: > > The existing IPMI chardev encodes IPMI behaviours as the name suggests. > However, KCS devices are useful beyond IPMI (or keyboards), as they > provide a means to generate IRQs and exchange arbitrary data between a > BMC and its host

[Openipmi-developer] [PATCH v2 1/1] kernel.h: Split out panic and oops helpers

2021-04-09 Thread Andy Shevchenko
kernel.h is being used as a dump for all kinds of stuff for a long time. Here is the attempt to start cleaning it up by splitting out panic and oops helpers. There are several purposes of doing this: - dropping dependency in bug.h - dropping a loop by moving out panic_notifier.h - unload kernel.h

Re: [Openipmi-developer] [PATCH v2 17/21] dt-bindings: ipmi: Convert ASPEED KCS binding to schema

2021-04-09 Thread Zev Weiss
On Fri, Apr 09, 2021 at 12:44:04AM CDT, Zev Weiss wrote: >On Fri, Apr 09, 2021 at 12:33:10AM CDT, Andrew Jeffery wrote: >> >> >>On Fri, 9 Apr 2021, at 14:45, Zev Weiss wrote: >>>On Fri, Mar 19, 2021 at 01:27:48AM CDT, Andrew Jeffery wrote: Given the deprecated binding, improve the ability to

Re: [Openipmi-developer] [PATCH v1 1/1] kernel.h: Split out panic and oops helpers

2021-04-09 Thread Andy Shevchenko
On Thu, Apr 08, 2021 at 11:23:03PM -0700, Andrew Morton wrote: > On Wed, 7 Apr 2021 11:46:37 +0300 Andy Shevchenko > wrote: > > > On Wed, Apr 7, 2021 at 11:17 AM Kees Cook wrote: > > > > > > On Tue, Apr 06, 2021 at 04:31:58PM +0300, Andy Shevchenko wrote: > > > > kernel.h is being used as a

Re: [Openipmi-developer] [PATCH v2 00/21] ipmi: Allow raw access to KCS devices

2021-04-09 Thread Arnd Bergmann
On Fri, Apr 9, 2021 at 6:09 AM Joel Stanley wrote: > On Thu, 8 Apr 2021 at 23:47, Andrew Jeffery wrote: > > On Thu, 8 Apr 2021, at 21:44, Corey Minyard wrote: > > > On Thu, Apr 08, 2021 at 10:27:46AM +0930, Andrew Jeffery wrote: > > > There were some minor concerns that were unanswered, and

Re: [Openipmi-developer] [PATCH v1 1/1] kernel.h: Split out panic and oops helpers

2021-04-09 Thread Andrew Morton
On Wed, 7 Apr 2021 11:46:37 +0300 Andy Shevchenko wrote: > On Wed, Apr 7, 2021 at 11:17 AM Kees Cook wrote: > > > > On Tue, Apr 06, 2021 at 04:31:58PM +0300, Andy Shevchenko wrote: > > > kernel.h is being used as a dump for all kinds of stuff for a long time. > > > Here is the attempt to start

Re: [Openipmi-developer] [PATCH v2 16/21] ipmi: kcs_bmc: Add a "raw" character device interface

2021-04-09 Thread Andrew Jeffery
On Fri, 9 Apr 2021, at 14:47, Zev Weiss wrote: > On Fri, Mar 19, 2021 at 01:27:47AM CDT, Andrew Jeffery wrote: > >The existing IPMI chardev encodes IPMI behaviours as the name suggests. > >However, KCS devices are useful beyond IPMI (or keyboards), as they > >provide a means to generate IRQs

Re: [Openipmi-developer] [PATCH v2 14/21] ipmi: kcs_bmc: Allow clients to control KCS IRQ state

2021-04-09 Thread Andrew Jeffery
On Fri, 9 Apr 2021, at 14:07, Zev Weiss wrote: > On Fri, Mar 19, 2021 at 01:27:45AM CDT, Andrew Jeffery wrote: > >Add a mechanism for controlling whether the client associated with a > >KCS device will receive Input Buffer Full (IBF) and Output Buffer Empty > >(OBE) events. This enables an

Re: [Openipmi-developer] [PATCH v2 10/21] ipmi: kcs_bmc: Turn the driver data-structures inside-out

2021-04-09 Thread Zev Weiss
On Fri, Apr 09, 2021 at 12:59:09AM CDT, Andrew Jeffery wrote: > > >On Fri, 9 Apr 2021, at 13:27, Zev Weiss wrote: >> On Fri, Mar 19, 2021 at 01:27:41AM CDT, Andrew Jeffery wrote: >> >Make the KCS device drivers responsible for allocating their own memory. >> > >> >Until now the private data for

Re: [Openipmi-developer] [PATCH v2 13/21] ipmi: kcs_bmc: Decouple the IPMI chardev from the core

2021-04-09 Thread Andrew Jeffery
On Fri, 9 Apr 2021, at 14:05, Zev Weiss wrote: > On Fri, Mar 19, 2021 at 01:27:44AM CDT, Andrew Jeffery wrote: > >Now that we have untangled the data-structures, split the userspace > >interface out into its own module. Userspace interfaces and drivers are > >registered to the KCS BMC core to

Re: [Openipmi-developer] [PATCH v2 12/21] ipmi: kcs_bmc: Strip private client data from struct kcs_bmc

2021-04-09 Thread Andrew Jeffery
On Fri, 9 Apr 2021, at 13:37, Zev Weiss wrote: > On Fri, Mar 19, 2021 at 01:27:43AM CDT, Andrew Jeffery wrote: > >Move all client-private data out of `struct kcs_bmc` into the KCS client > >implementation. > > > >With this change the KCS BMC core code now only concerns itself with > >abstract

Re: [Openipmi-developer] [PATCH v2 11/21] ipmi: kcs_bmc: Split headers into device and client

2021-04-09 Thread Andrew Jeffery
On Fri, 9 Apr 2021, at 13:31, Zev Weiss wrote: > On Fri, Mar 19, 2021 at 01:27:42AM CDT, Andrew Jeffery wrote: > >Strengthen the distinction between code that abstracts the > >implementation of the KCS behaviours (device drivers) and code that > >exploits KCS behaviours (clients). Neither needs