Re: [Openipmi-developer] PANIC / OEM strings missing, not sure whether misconfiguration or a bug

2023-03-14 Thread Corey Minyard
On Tue, Mar 14, 2023 at 06:42:00PM +0100, Christian Theune via Openipmi-developer wrote: > Hi, > > ouch, sorry to hear that. I’ll test it with that patch and will ask for a > backport to 5.10 after that. Is that something you’d do or should I contact > the maintainers? I've already requested

Re: [Openipmi-developer] PANIC / OEM strings missing, not sure whether misconfiguration or a bug

2023-03-14 Thread Christian Theune via Openipmi-developer
Hi, ouch, sorry to hear that. I’ll test it with that patch and will ask for a backport to 5.10 after that. Is that something you’d do or should I contact the maintainers? Christian > On 14. Mar 2023, at 18:29, Corey Minyard wrote: > > Well, dang, I had already fixed this a year and a half

Re: [Openipmi-developer] PANIC / OEM strings missing, not sure whether misconfiguration or a bug

2023-03-14 Thread Corey Minyard
Well, dang, I had already fixed this a year and a half ago. I wish I had a better memory. Anyway, the fix is commit db05ddf7f321634c5659a0cf7ea56594e22365f7 ("ipmi:watchdog: Set panic count to proper value on a panic") in mainstream 5.16. I'm attaching that patch. -corey On Tue, Mar 14, 2023

Re: [Openipmi-developer] [PATCH v3 03/38] char: impi, tpm: depend on HAS_IOPORT

2023-03-14 Thread Arnd Bergmann
On Tue, Mar 14, 2023, at 15:17, Geert Uytterhoeven wrote: >> --- a/drivers/char/Kconfig >> +++ b/drivers/char/Kconfig >> @@ -34,6 +34,7 @@ config TTY_PRINTK_LEVEL >> config PRINTER >> tristate "Parallel printer support" >> depends on PARPORT >> + depends on HAS_IOPORT > >

Re: [Openipmi-developer] PANIC / OEM strings missing, not sure whether misconfiguration or a bug

2023-03-14 Thread Christian Theune via Openipmi-developer
Awesome! > On 14. Mar 2023, at 15:54, Corey Minyard wrote: > > On Tue, Mar 14, 2023 at 03:22:39PM +0100, Christian Theune via > Openipmi-developer wrote: >> Hi, >> >> sorry, I didn’t expect you to make me a branch. I had already taken your >> diff over to 5.10 as it applied cleanly … sorry

Re: [Openipmi-developer] PANIC / OEM strings missing, not sure whether misconfiguration or a bug

2023-03-14 Thread Corey Minyard
On Tue, Mar 14, 2023 at 03:22:39PM +0100, Christian Theune via Openipmi-developer wrote: > Hi, > > sorry, I didn’t expect you to make me a branch. I had already taken your diff > over to 5.10 as it applied cleanly … sorry for the additional work and thanks > anyways. Ok, that's great. It's

Re: [Openipmi-developer] PANIC / OEM strings missing, not sure whether misconfiguration or a bug

2023-03-14 Thread Christian Theune via Openipmi-developer
Hi, sorry, I didn’t expect you to make me a branch. I had already taken your diff over to 5.10 as it applied cleanly … sorry for the additional work and thanks anyways. Here’s the output: [ 6521.905890] sysrq: Trigger a crash [ 6521.909294] Kernel panic - not syncing: sysrq triggered crash [

Re: [Openipmi-developer] [PATCH v3 03/38] char: impi, tpm: depend on HAS_IOPORT

2023-03-14 Thread Geert Uytterhoeven
Hi Niklas, On Tue, Mar 14, 2023 at 1:12 PM Niklas Schnelle wrote: > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > not being declared. We thus need to add this dependency and ifdef > sections of code using inb()/outb() as alternative access methods. > > Co-developed-by:

Re: [Openipmi-developer] [PATCH v3 03/38] char: impi, tpm: depend on HAS_IOPORT

2023-03-14 Thread Jarkko Sakkinen
On Tue, Mar 14, 2023 at 01:11:41PM +0100, Niklas Schnelle wrote: > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > not being declared. We thus need to add this dependency and ifdef > sections of code using inb()/outb() as alternative access methods. > > Co-developed-by:

Re: [Openipmi-developer] [PATCH v3 03/38] char: impi, tpm: depend on HAS_IOPORT

2023-03-14 Thread Arnd Bergmann
On Tue, Mar 14, 2023, at 13:20, Jarkko Sakkinen wrote: > On Tue, Mar 14, 2023 at 01:11:41PM +0100, Niklas Schnelle wrote: > Reviewed-by: Jarkko Sakkinen > > Who should pick this? All patches in this series depend on patch 1, so either I merge them all through the asm-generic tree, or I ask

Re: [Openipmi-developer] [PATCH v3 03/38] char: impi, tpm: depend on HAS_IOPORT

2023-03-14 Thread Corey Minyard
On Tue, Mar 14, 2023 at 01:11:41PM +0100, Niklas Schnelle wrote: > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > not being declared. We thus need to add this dependency and ifdef > sections of code using inb()/outb() as alternative access methods. For the IPMI portions,

[Openipmi-developer] [PATCH v3 03/38] char: impi, tpm: depend on HAS_IOPORT

2023-03-14 Thread Niklas Schnelle via Openipmi-developer
In a future patch HAS_IOPORT=n will result in inb()/outb() and friends not being declared. We thus need to add this dependency and ifdef sections of code using inb()/outb() as alternative access methods. Co-developed-by: Arnd Bergmann Signed-off-by: Niklas Schnelle --- drivers/char/Kconfig