Re: [Openipmi-developer] [PATCH 33/34] drivers: remove incorrect of_match_ptr/ACPI_PTR annotations

2024-04-03 Thread Krzysztof Kozlowski
On 03/04/2024 10:06, Arnd Bergmann wrote: > From: Arnd Bergmann > > When building with CONFIG_OF and/or CONFIG_ACPI disabled but W=1 extra > warnings enabled, a lot of driver cause a warning about an unused > ID table: > > drivers/char/tpm/tpm_ftpm_tee.c:356:34: error: unused variable >

[Openipmi-developer] [PATCH] dt-bindings: ipmi: aspeed, ast2400-kcs-bmc: drop unneeded quotes

2023-06-09 Thread Krzysztof Kozlowski
Cleanup bindings dropping unneeded quotes. Once all these are fixed, checking for this can be enabled in yamllint. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [Openipmi-developer] [PATCH v3] dt-binding: ipmi: add fallback to npcm845 compatible

2022-08-08 Thread Krzysztof Kozlowski
On 08/08/2022 15:26, Corey Minyard wrote: > On Mon, Aug 08, 2022 at 11:11:16AM +0300, Krzysztof Kozlowski wrote: >> On 08/08/2022 09:54, Tomer Maimon wrote: >>> Add to npcm845 KCS compatible string a fallback to npcm750 KCS compatible >>> string becuase NPCM845 and NPCM7

Re: [Openipmi-developer] [PATCH v3] dt-binding: ipmi: add fallback to npcm845 compatible

2022-08-08 Thread Krzysztof Kozlowski
gned-off-by: Tomer Maimon Acked-by: Krzysztof Kozlowski Best regards, Krzysztof ___ Openipmi-developer mailing list Openipmi-developer@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openipmi-developer

Re: [Openipmi-developer] [PATCH v2] dt-binding: ipmi: add fallback to npcm845 compatible

2022-08-08 Thread Krzysztof Kozlowski
On 07/08/2022 09:51, Tomer Maimon wrote: > Hi Krzysztof, > > Thanks for your review. > > On Fri, 5 Aug 2022 at 09:36, Krzysztof Kozlowski > wrote: >> >> On 04/08/2022 20:18, Tomer Maimon wrote: >>> Add to npcm845 KCS compatible string a fallback to np

Re: [Openipmi-developer] [PATCH v2] dt-binding: ipmi: add fallback to npcm845 compatible

2022-08-08 Thread Krzysztof Kozlowski
On 07/08/2022 18:05, Corey Minyard wrote: >> We had a disscation with Arnd, Arnd asked us to use a fallback as we >> did here if NPCM8XX device module is similar to NPCM7XX module: >> https://lore.kernel.org/lkml/20220522155046.260146-5-tmaimo...@gmail.com/ >> >> I think we should use a fallback

Re: [Openipmi-developer] [PATCH v2] dt-binding: ipmi: add fallback to npcm845 compatible

2022-08-08 Thread Krzysztof Kozlowski
On 07/08/2022 16:54, Tomer Maimon wrote: > On Sun, 7 Aug 2022 at 15:11, Corey Minyard wrote: >> >> On Sun, Aug 07, 2022 at 11:03:56AM +0300, Tomer Maimon wrote: >>> Hi Corey, >>> >>> Thanks for your comment. >>> >>> On Fri, 5 Aug 2022 at 14:58, Corey Minyard wrote: On Thu, Aug 04, 2022

Re: [Openipmi-developer] [PATCH v2] dt-binding: ipmi: add fallback to npcm845 compatible

2022-08-08 Thread Krzysztof Kozlowski
On 07/08/2022 14:11, Corey Minyard wrote: > On Sun, Aug 07, 2022 at 11:03:56AM +0300, Tomer Maimon wrote: >> Hi Corey, >> >> Thanks for your comment. >> >> On Fri, 5 Aug 2022 at 14:58, Corey Minyard wrote: >>> >>> On Thu, Aug 04, 2022 at 09:18:00PM +0300, Tomer Maimon wrote: Add to npcm845

Re: [Openipmi-developer] [PATCH v2] dt-binding: ipmi: add fallback to npcm845 compatible

2022-08-08 Thread Krzysztof Kozlowski
On 05/08/2022 13:58, Corey Minyard wrote: > On Thu, Aug 04, 2022 at 09:18:00PM +0300, Tomer Maimon wrote: >> Add to npcm845 KCS compatible string a fallback to npcm750 KCS compatible >> string becuase NPCM845 and NPCM750 BMCs are using identical KCS modules. >> >> Signed-off-by: Tomer Maimon >>

Re: [Openipmi-developer] [PATCH v2] dt-binding: ipmi: add fallback to npcm845 compatible

2022-08-05 Thread Krzysztof Kozlowski
On 04/08/2022 20:18, Tomer Maimon wrote: > Add to npcm845 KCS compatible string a fallback to npcm750 KCS compatible > string becuase NPCM845 and NPCM750 BMCs are using identical KCS modules. > > Signed-off-by: Tomer Maimon Your previous commit adding that compatible was simply wrong and not

Re: [Openipmi-developer] [PATCH v1] dt-binding: ipmi: add fallback to npcm845 compatible

2022-08-04 Thread Krzysztof Kozlowski
On 04/08/2022 16:55, Tomer Maimon wrote: > Add to npcm845 KCS compatible string a fallback to npcm750 KCS compatible > string. It's easily visible in the code what you are doing, so instead you must explain why you are doing it. Best regards, Krzysztof

Re: [Openipmi-developer] [PATCH v1 1/2] dt-bindings: ipmi: Add npcm845 compatible

2022-07-18 Thread Krzysztof Kozlowski
On 17/07/2022 14:11, Tomer Maimon wrote: > Add a compatible string for Nuvoton BMC NPCM845 KCS and modify NPCM KCS > description to support all NPCM BMC SoC. > > Signed-off-by: Tomer Maimon Acked-by: Krzysztof Kozlowski Best regard

Re: [Openipmi-developer] [PATCH v7 2/3] bindings: ipmi: Add binding for SSIF BMC driver

2022-04-22 Thread Krzysztof Kozlowski
On 22/04/2022 06:16, Quan Nguyen wrote: > Added Krzysztof Kozlowski > as I'm not aware of the email change The email change from @canonical.com was 1.5 months ago, so it would be better if rebase your changes on more recent Linux kernel. You get all proper .mailmap entries. Best r

Re: [Openipmi-developer] [PATCH] HPE BMC GXP SUPPORT

2022-02-04 Thread Krzysztof Kozlowski
On 03/02/2022 18:07, Verdun, Jean-Marie wrote: > >> Maybe it does not look like, but this is actually a v2. Nick was asked >> to change the naming for the nodes already in v1. Unfortunately it did >> not happen, so we have vuart, spifi, vic and more. > >> It is a waste of

Re: [Openipmi-developer] [PATCH] HPE BMC GXP SUPPORT

2022-02-03 Thread Krzysztof Kozlowski
On 02/02/2022 17:52, nick.hawk...@hpe.com wrote: > From: Nick Hawkins > > GXP is the name of the HPE SoC. > This SoC is used to implement BMC features of HPE servers > (all ProLiant, Synergy, and many Apollo, and Superdome machines) > It does support many features including: > ARMv7

Re: [Openipmi-developer] [PATCH] HPE BMC GXP SUPPORT

2022-02-03 Thread Krzysztof Kozlowski
On 03/02/2022 15:29, Rob Herring wrote: > On Wed, Feb 2, 2022 at 10:55 AM wrote: >> >> From: Nick Hawkins >> (...) >> + >> + vuart_a: vuart_a@80fd0200 { > > serial@... Maybe it does not look like, but this is actually a v2. Nick was asked to change the naming for the nodes already in

[Openipmi-developer] [RESEND PATCH] char: ipmi: Drop owner assignment from i2c_driver

2015-11-18 Thread Krzysztof Kozlowski
i2c_driver does not need to set an owner because i2c_register_driver() will set it. Signed-off-by: Krzysztof Kozlowski <k.kozlow...@samsung.com> --- The coccinelle script which generated the patch was sent here: http://www.spinics.net/lists/kernel/msg2029903.html --- drivers/cha

[Openipmi-developer] [PATCH] char: Drop owner assignment from i2c_driver

2015-07-12 Thread Krzysztof Kozlowski
i2c_driver does not need to set an owner because i2c_register_driver() will set it. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- The coccinelle script which generated the patch was sent here: http://www.spinics.net/lists/kernel/msg2029903.html --- drivers/char/ipmi

[Openipmi-developer] [PATCH] Drop owner assignment from i2c_driver (and platform left-overs)

2015-07-12 Thread Krzysztof Kozlowski
was sent here: http://www.spinics.net/lists/kernel/msg2029903.html Best regards, Krzysztof Krzysztof Kozlowski (1): char: Drop owner assignment from i2c_driver drivers/char/ipmi/ipmi_ssif.c | 1 - drivers/char/tpm/st33zp24/i2c.c | 1 - drivers/char/tpm/tpm_i2c_atmel.c| 1