Re: [Openipmi-developer] [PATCH] HPE BMC GXP SUPPORT

2022-02-03 Thread Verdun, Jean-Marie
> Maybe it does not look like, but this is actually a v2. Nick was asked > to change the naming for the nodes already in v1. Unfortunately it did > not happen, so we have vuart, spifi, vic and more. > It is a waste of reviewers' time to ask them to perform the same review > twice

Re: [Openipmi-developer] [PATCH] HPE BMC GXP SUPPORT

2022-02-02 Thread Verdun, Jean-Marie
> This is far too big for a single patch. It needs to be broken into > functional chunks that can be reviewed individually. Each driver and > each device tree change along with it's accompanying code need to be > done in individual patches. The way it is it can't be reviewed in any > sane manner