Re: [Openipmi-developer] [PATCH v3 03/38] char: impi, tpm: depend on HAS_IOPORT

2023-03-21 Thread Jason Gunthorpe
On Tue, Mar 14, 2023 at 01:11:41PM +0100, Niklas Schnelle wrote: > diff --git a/drivers/char/tpm/tpm_infineon.c b/drivers/char/tpm/tpm_infineon.c > index 9c924a1440a9..2d2ae37153ba 100644 > --- a/drivers/char/tpm/tpm_infineon.c > +++ b/drivers/char/tpm/tpm_infineon.c > @@ -51,34 +51,40 @@ static st

Re: [Openipmi-developer] [PATCH v3 03/38] char: impi, tpm: depend on HAS_IOPORT

2023-03-14 Thread Arnd Bergmann
On Tue, Mar 14, 2023, at 15:17, Geert Uytterhoeven wrote: >> --- a/drivers/char/Kconfig >> +++ b/drivers/char/Kconfig >> @@ -34,6 +34,7 @@ config TTY_PRINTK_LEVEL >> config PRINTER >> tristate "Parallel printer support" >> depends on PARPORT >> + depends on HAS_IOPORT > > Thi

Re: [Openipmi-developer] [PATCH v3 03/38] char: impi, tpm: depend on HAS_IOPORT

2023-03-14 Thread Geert Uytterhoeven
Hi Niklas, On Tue, Mar 14, 2023 at 1:12 PM Niklas Schnelle wrote: > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > not being declared. We thus need to add this dependency and ifdef > sections of code using inb()/outb() as alternative access methods. > > Co-developed-by:

Re: [Openipmi-developer] [PATCH v3 03/38] char: impi, tpm: depend on HAS_IOPORT

2023-03-14 Thread Jarkko Sakkinen
On Tue, Mar 14, 2023 at 01:11:41PM +0100, Niklas Schnelle wrote: > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > not being declared. We thus need to add this dependency and ifdef > sections of code using inb()/outb() as alternative access methods. > > Co-developed-by: Ar

Re: [Openipmi-developer] [PATCH v3 03/38] char: impi, tpm: depend on HAS_IOPORT

2023-03-14 Thread Arnd Bergmann
On Tue, Mar 14, 2023, at 13:20, Jarkko Sakkinen wrote: > On Tue, Mar 14, 2023 at 01:11:41PM +0100, Niklas Schnelle wrote: > Reviewed-by: Jarkko Sakkinen > > Who should pick this? All patches in this series depend on patch 1, so either I merge them all through the asm-generic tree, or I ask Linus

Re: [Openipmi-developer] [PATCH v3 03/38] char: impi, tpm: depend on HAS_IOPORT

2023-03-14 Thread Corey Minyard
On Tue, Mar 14, 2023 at 01:11:41PM +0100, Niklas Schnelle wrote: > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > not being declared. We thus need to add this dependency and ifdef > sections of code using inb()/outb() as alternative access methods. For the IPMI portions,

[Openipmi-developer] [PATCH v3 03/38] char: impi, tpm: depend on HAS_IOPORT

2023-03-14 Thread Niklas Schnelle via Openipmi-developer
In a future patch HAS_IOPORT=n will result in inb()/outb() and friends not being declared. We thus need to add this dependency and ifdef sections of code using inb()/outb() as alternative access methods. Co-developed-by: Arnd Bergmann Signed-off-by: Niklas Schnelle --- drivers/char/Kconfig