Re: [Openipmi-developer] IPMI Serial Driver: state-> mutex issues

2007-04-20 Thread David Jenkins
Sending this to the list instead of just to Corey (forgot to reply-all). Corey, Here is the mutex-lock patch for serial_core.c --- linux-2.6.18-ipmi/drivers/serial/serial_core.c 2007-04-05 17:28: 15.0 -0500 +++ linux-2.6.18/drivers/serial/serial_core.c2007-04-04 17:06: 00.00

Re: [Openipmi-developer] IPMI Serial Driver: state-> mutex issues

2007-04-17 Thread Corey Minyard
Sorry, I've been very slow replying to this. David Jenkins wrote: > Corey, > > Moving uart_register_ldrv() into uart_add_one_port() seems to be > working. I can create and deliver a patch for you. I am unaware of > the proper procedure for posting patches so I have a few questions. > > What wou

Re: [Openipmi-developer] IPMI Serial Driver: state-> mutex issues

2007-04-05 Thread David Jenkins
Corey, Moving uart_register_ldrv() into uart_add_one_port() seems to be working. I can create and deliver a patch for you. I am unaware of the proper procedure for posting patches so I have a few questions. What would you like the patch generated against (stock kernel.org 2.6.18serial_core.c

Re: [Openipmi-developer] IPMI Serial Driver: state-> mutex issues

2007-03-30 Thread Corey Minyard
I haven't seen this problem, but it appears to be order related and that's probably why I missed it. I think the right answer is to move the call to uart_register_ldrv() out of uart_configure_port() and move it into uart_add_one_port() after the mutex->state is unlocked. However, I haven't te

[Openipmi-developer] IPMI Serial Driver: state-> mutex issues

2007-03-28 Thread David Jenkins
Hi, I am setting up IPMI for an ATCA board with a pigeon point MMC on it. This requires the serial driver. I have downloaded the 2.6.18 serial patches and applied them. There seems to be a problem with some mutex_lock(&state->mutex) code in the layered driver interface added to serial_core.c