Re: [Openipmi-developer] [PATCH arm/aspeed/ast2500 v5 1/2] ipmi: add a KCS IPMI BMC driver

2018-02-02 Thread Corey Minyard
On 02/01/2018 08:16 PM, Haiyue Wang wrote: --- v4->v5 - Fix -Wdiscarded-qualifiers 'const' compile warning. - Fix size_t printk compile error. v3->v4 - Change to accept WRITE_START any time. v2->v3 - Update the KCS phase state machine. - Fix the race condition of read/write. v1->v2 - Divide

Re: [Openipmi-developer] [PATCH arm/aspeed/ast2500 v4 1/2] ipmi: add a KCS IPMI BMC driver

2018-02-02 Thread Corey Minyard
On 02/01/2018 07:33 PM, Wang, Haiyue wrote: On 2018-02-02 09:10, Corey Minyard wrote: I loaded this in, tried a compile on x86_64, and got the following: In file included from ../drivers/char/ipmi/kcs_bmc.c:15:0: ../drivers/char/ipmi/kcs_bmc.h: In function ‘kcs_bmc_priv’:

Re: [Openipmi-developer] [PATCH arm/aspeed/ast2500 v5 1/2] ipmi: add a KCS IPMI BMC driver

2018-02-02 Thread Wang, Haiyue
On 2018-02-02 21:52, Corey Minyard wrote: On 02/01/2018 08:16 PM, Haiyue Wang wrote: --- v4->v5 - Fix -Wdiscarded-qualifiers 'const' compile warning. - Fix size_t printk compile error. v3->v4 - Change to accept WRITE_START any time. v2->v3 - Update the KCS phase state machine. - Fix the race