Re: [Openipmi-developer] [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-18 10:58, Corey Minyard wrote: On 01/17/2018 06:16 PM, Wang, Haiyue wrote: On 2018-01-17 23:59, Corey Minyard wrote: On 01/17/2018 08:31 AM, Wang, Haiyue wrote: On 2018-01-17 06:12, Corey Minyard wrote: On 01/16/2018 02:59 PM, Corey Minyard wrote: On 01/16/2018 05:43 AM,

[Openipmi-developer] [PATCH -next v2] ipmi/powernv: Fix error return code in ipmi_powernv_probe()

Fix to return a negative error code from the request_irq() error handling case instead of 0, as done elsewhere in this function. Fixes: dce143c3381c ("ipmi/powernv: Convert to irq event interface") Signed-off-by: Wei Yongjun --- v1 -> v2: add fixes. ---

Re: [Openipmi-developer] [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-18 00:31, Corey Minyard wrote: On 01/17/2018 08:31 AM, Wang, Haiyue wrote: Snip... + +struct kcs_bmc { +    struct regmap *map; +    spinlock_t lock; This lock is only used in threads, as far as I can tell. Couldn't it just be a normal mutex? But more on this later.

Re: [Openipmi-developer] [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-17 23:59, Corey Minyard wrote: On 01/17/2018 08:31 AM, Wang, Haiyue wrote: On 2018-01-17 06:12, Corey Minyard wrote: On 01/16/2018 02:59 PM, Corey Minyard wrote: On 01/16/2018 05:43 AM, Haiyue Wang wrote: The KCS (Keyboard Controller Style) interface is used to perform in-band

Re: [Openipmi-developer] [PATCH] ipmi: use dynamic memory for DMI driver override

On 17/01/2018 16:49, Corey Minyard wrote: On 01/17/2018 10:36 AM, John Garry wrote: Currently a crash can be seen if we reach the "err" label in dmi_add_platform_ipmi(), calling platform_device_put(), like here: [7.270584] (null): ipmi:dmi: Unable to add resources: -16 [7.330229]

Re: [Openipmi-developer] [PATCH] ipmi: use dynamic memory for DMI driver override

On 01/17/2018 10:36 AM, John Garry wrote: Currently a crash can be seen if we reach the "err" label in dmi_add_platform_ipmi(), calling platform_device_put(), like here: [7.270584] (null): ipmi:dmi: Unable to add resources: -16 [7.330229] [ cut here ] [

Re: [Openipmi-developer] [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

On 01/17/2018 08:31 AM, Wang, Haiyue wrote: Snip... +/* mapped to lpc-host@80 IO space */ +#define LPC_HICRB    0x080 +#define LPC_HICRB_IBFIF4 BIT(1) +#define LPC_HICRB_LPC4E  BIT(0) +#define LPC_LADR4    0x090 +#define LPC_IDR4 0x094

Re: [Openipmi-developer] [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

On 01/17/2018 08:31 AM, Wang, Haiyue wrote: On 2018-01-17 06:12, Corey Minyard wrote: On 01/16/2018 02:59 PM, Corey Minyard wrote: On 01/16/2018 05:43 AM, Haiyue Wang wrote: The KCS (Keyboard Controller Style) interface is used to perform in-band IPMI communication between a server host and

[Openipmi-developer] [PATCH] ipmi: use dynamic memory for DMI driver override

Currently a crash can be seen if we reach the "err" label in dmi_add_platform_ipmi(), calling platform_device_put(), like here: [7.270584] (null): ipmi:dmi: Unable to add resources: -16 [7.330229] [ cut here ] [7.334889] kernel BUG at mm/slub.c:3894! [

Re: [Openipmi-developer] [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

Sounds great for us (Nuvoton). Avi. On Wed, Jan 17, 2018 at 8:32 AM, Wang, Haiyue wrote: > > > On 2018-01-17 07:06, Joel Stanley wrote: >> >> On Tue, Jan 16, 2018 at 2:59 PM, Corey Minyard wrote: >>> >>> On 01/16/2018 05:43 AM, Haiyue Wang wrote:

Re: [Openipmi-developer] [PATCH -next] ipmi/powernv: Fix error return code in ipmi_powernv_probe()

On 01/17/2018 05:25 AM, Wei Yongjun wrote: Fix to return a negative error code from the request_irq() error handling case instead of 0, as done elsewhere in this function. I think you are right here.  However, you had a bunch of people on the email that probably didn't need to be there, and

Re: [Openipmi-developer] [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

Thanks Avi, wait for your response when new patch is ready. :-) BR, Haiyue On 2018-01-17 20:54, Avi Fishman wrote: Sounds great for us (Nuvoton). Avi. On Wed, Jan 17, 2018 at 8:32 AM, Wang, Haiyue wrote: On 2018-01-17 07:06, Joel Stanley wrote: On Tue, Jan

Re: [Openipmi-developer] [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-17 06:12, Corey Minyard wrote: On 01/16/2018 02:59 PM, Corey Minyard wrote: On 01/16/2018 05:43 AM, Haiyue Wang wrote: The KCS (Keyboard Controller Style) interface is used to perform in-band IPMI communication between a server host and its BMC (BaseBoard Management

[Openipmi-developer] [PATCH -next] ipmi/powernv: Fix error return code in ipmi_powernv_probe()

Fix to return a negative error code from the request_irq() error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/char/ipmi/ipmi_powernv.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git