Re: [Openipmi-developer] [PATCH] char: ipmi: use DEVICE_ATTR helper macro
On Fri, Jul 30, 2021 at 11:59:51AM +0530, Dwaipayan Ray wrote:
> Instead of open coding DEVICE_ATTR, use the helper macro
> DEVICE_ATTR_RO to replace DEVICE_ATTR with 0444 octal
> permissions.
Looks good, this is queued for the next release.
-corey
>
> This was detected as a part of checkpatch evaluation
> investigating all reports of DEVICE_ATTR_RO warning
> type.
>
> Signed-off-by: Dwaipayan Ray
> ---
> drivers/char/ipmi/ipmi_si_intf.c | 9 -
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_si_intf.c
> b/drivers/char/ipmi/ipmi_si_intf.c
> index 62929a3e397e..1cbc6a6a3ef4 100644
> --- a/drivers/char/ipmi/ipmi_si_intf.c
> +++ b/drivers/char/ipmi/ipmi_si_intf.c
> @@ -1605,7 +1605,7 @@ static ssize_t name##_show(struct device *dev,
> \
> \
> return snprintf(buf, 10, "%u\n", smi_get_stat(smi_info, name)); \
> }\
> -static DEVICE_ATTR(name, 0444, name##_show, NULL)
> +static DEVICE_ATTR_RO(name)
>
> static ssize_t type_show(struct device *dev,
>struct device_attribute *attr,
> @@ -1615,7 +1615,7 @@ static ssize_t type_show(struct device *dev,
>
> return snprintf(buf, 10, "%s\n", si_to_str[smi_info->io.si_type]);
> }
> -static DEVICE_ATTR(type, 0444, type_show, NULL);
> +static DEVICE_ATTR_RO(type);
>
> static ssize_t interrupts_enabled_show(struct device *dev,
> struct device_attribute *attr,
> @@ -1626,8 +1626,7 @@ static ssize_t interrupts_enabled_show(struct device
> *dev,
>
> return snprintf(buf, 10, "%d\n", enabled);
> }
> -static DEVICE_ATTR(interrupts_enabled, 0444,
> -interrupts_enabled_show, NULL);
> +static DEVICE_ATTR_RO(interrupts_enabled);
>
> IPMI_SI_ATTR(short_timeouts);
> IPMI_SI_ATTR(long_timeouts);
> @@ -1658,7 +1657,7 @@ static ssize_t params_show(struct device *dev,
> smi_info->io.irq,
> smi_info->io.slave_addr);
> }
> -static DEVICE_ATTR(params, 0444, params_show, NULL);
> +static DEVICE_ATTR_RO(params);
>
> static struct attribute *ipmi_si_dev_attrs[] = {
> _attr_type.attr,
> --
> 2.28.0
>
___
Openipmi-developer mailing list
Openipmi-developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openipmi-developer
[Openipmi-developer] [PATCH] char: ipmi: use DEVICE_ATTR helper macro
Instead of open coding DEVICE_ATTR, use the helper macro
DEVICE_ATTR_RO to replace DEVICE_ATTR with 0444 octal
permissions.
This was detected as a part of checkpatch evaluation
investigating all reports of DEVICE_ATTR_RO warning
type.
Signed-off-by: Dwaipayan Ray
---
drivers/char/ipmi/ipmi_si_intf.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index 62929a3e397e..1cbc6a6a3ef4 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -1605,7 +1605,7 @@ static ssize_t name##_show(struct device *dev,
\
\
return snprintf(buf, 10, "%u\n", smi_get_stat(smi_info, name)); \
} \
-static DEVICE_ATTR(name, 0444, name##_show, NULL)
+static DEVICE_ATTR_RO(name)
static ssize_t type_show(struct device *dev,
struct device_attribute *attr,
@@ -1615,7 +1615,7 @@ static ssize_t type_show(struct device *dev,
return snprintf(buf, 10, "%s\n", si_to_str[smi_info->io.si_type]);
}
-static DEVICE_ATTR(type, 0444, type_show, NULL);
+static DEVICE_ATTR_RO(type);
static ssize_t interrupts_enabled_show(struct device *dev,
struct device_attribute *attr,
@@ -1626,8 +1626,7 @@ static ssize_t interrupts_enabled_show(struct device *dev,
return snprintf(buf, 10, "%d\n", enabled);
}
-static DEVICE_ATTR(interrupts_enabled, 0444,
- interrupts_enabled_show, NULL);
+static DEVICE_ATTR_RO(interrupts_enabled);
IPMI_SI_ATTR(short_timeouts);
IPMI_SI_ATTR(long_timeouts);
@@ -1658,7 +1657,7 @@ static ssize_t params_show(struct device *dev,
smi_info->io.irq,
smi_info->io.slave_addr);
}
-static DEVICE_ATTR(params, 0444, params_show, NULL);
+static DEVICE_ATTR_RO(params);
static struct attribute *ipmi_si_dev_attrs[] = {
_attr_type.attr,
--
2.28.0
___
Openipmi-developer mailing list
Openipmi-developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openipmi-developer
Re: [Openipmi-developer] [PATCH] ipmi: ssif_bmc: Uninitialized return in ssif_bmc_write()
On Fri, Jul 30, 2021 at 06:08:01PM +0300, Dan Carpenter wrote:
> I accidentally introduced a bug in my previous patch. The "ret"
> variable needs to be initialized to prevent returning uninitialized
> data.
Thanks Dan, it's queued.
-corey
>
> Fixes: f9714eb04364 ("ipmi: ssif_bmc: Return -EFAULT if copy_from_user()
> fails")
> Signed-off-by: Dan Carpenter
> ---
> Sorry!
>
> drivers/char/ipmi/ssif_bmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ssif_bmc.c b/drivers/char/ipmi/ssif_bmc.c
> index ce8cd8364a3f..acdb1d9cb5c0 100644
> --- a/drivers/char/ipmi/ssif_bmc.c
> +++ b/drivers/char/ipmi/ssif_bmc.c
> @@ -80,7 +80,7 @@ static ssize_t ssif_bmc_write(struct file *file, const char
> __user *buf, size_t
> struct ssif_bmc_ctx *ssif_bmc = to_ssif_bmc(file);
> struct ssif_msg msg;
> unsigned long flags;
> - ssize_t ret;
> + ssize_t ret = 0;
>
> if (count > sizeof(struct ssif_msg))
> return -EINVAL;
> --
> 2.20.1
>
___
Openipmi-developer mailing list
Openipmi-developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openipmi-developer
[Openipmi-developer] [PATCH] ipmi: ssif_bmc: Uninitialized return in ssif_bmc_write()
I accidentally introduced a bug in my previous patch. The "ret"
variable needs to be initialized to prevent returning uninitialized
data.
Fixes: f9714eb04364 ("ipmi: ssif_bmc: Return -EFAULT if copy_from_user() fails")
Signed-off-by: Dan Carpenter
---
Sorry!
drivers/char/ipmi/ssif_bmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/ipmi/ssif_bmc.c b/drivers/char/ipmi/ssif_bmc.c
index ce8cd8364a3f..acdb1d9cb5c0 100644
--- a/drivers/char/ipmi/ssif_bmc.c
+++ b/drivers/char/ipmi/ssif_bmc.c
@@ -80,7 +80,7 @@ static ssize_t ssif_bmc_write(struct file *file, const char
__user *buf, size_t
struct ssif_bmc_ctx *ssif_bmc = to_ssif_bmc(file);
struct ssif_msg msg;
unsigned long flags;
- ssize_t ret;
+ ssize_t ret = 0;
if (count > sizeof(struct ssif_msg))
return -EINVAL;
--
2.20.1
___
Openipmi-developer mailing list
Openipmi-developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openipmi-developer
