Re: [Openipmi-developer] [PATCH 605/606] ipmi: ssif_bmc: Convert to i2c's .probe_new()
On Fri, Nov 18, 2022 at 11:45:39PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
Thanks, queued for next release.
-corey
>
> Signed-off-by: Uwe Kleine-König
> ---
> drivers/char/ipmi/ssif_bmc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/char/ipmi/ssif_bmc.c b/drivers/char/ipmi/ssif_bmc.c
> index 2d8069386398..caee848261e9 100644
> --- a/drivers/char/ipmi/ssif_bmc.c
> +++ b/drivers/char/ipmi/ssif_bmc.c
> @@ -797,7 +797,7 @@ static int ssif_bmc_cb(struct i2c_client *client, enum
> i2c_slave_event event, u8
> return ret;
> }
>
> -static int ssif_bmc_probe(struct i2c_client *client, const struct
> i2c_device_id *id)
> +static int ssif_bmc_probe(struct i2c_client *client)
> {
> struct ssif_bmc_ctx *ssif_bmc;
> int ret;
> @@ -860,7 +860,7 @@ static struct i2c_driver ssif_bmc_driver = {
> .name = DEVICE_NAME,
> .of_match_table = ssif_bmc_match,
> },
> - .probe = ssif_bmc_probe,
> + .probe_new = ssif_bmc_probe,
> .remove = ssif_bmc_remove,
> .id_table = ssif_bmc_id,
> };
> --
> 2.38.1
>
___
Openipmi-developer mailing list
Openipmi-developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openipmi-developer
Re: [Openipmi-developer] [PATCH 000/606] i2c: Complete conversion to i2c_probe_new
On Fri, 18 Nov 2022, Uwe Kleine-König wrote:
> Hello,
>
> since commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type") from 2016 there is a "temporary" alternative probe
> callback for i2c drivers.
Oh yeah, this! Thanks for picking this up Uwe, I guess I've been
distracted for the past 6 years or so. :)
> This series completes all drivers to this new callback (unless I missed
> something). It's based on current next/master.
> A part of the patches depend on commit 662233731d66 ("i2c: core:
> Introduce i2c_client_get_device_id helper function"), there is a branch that
> you can pull into your tree to get it:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git
> i2c/client_device_id_helper-immutable
>
> I don't think it's feasable to apply this series in one go, so I ask the
> maintainers of the changed files to apply via their tree. I guess it
> will take a few kernel release iterations until all patch are in, but I
> think a single tree creates too much conflicts.
>
> The last patch changes i2c_driver::probe, all non-converted drivers will
> fail to compile then. So I hope the build bots will tell me about any
> driver I missed to convert. This patch is obviously not for application
> now.
>
> I dropped most individuals from the recipents of this mail to not
> challenge the mail servers and mailing list filters too much. Sorry if
> you had extra efforts to find this mail.
[...]
> drivers/mfd/88pm800.c| 5 ++---
> drivers/mfd/88pm805.c| 5 ++---
> drivers/mfd/aat2870-core.c | 5 ++---
> drivers/mfd/act8945a.c | 5 ++---
> drivers/mfd/adp5520.c| 6 +++---
> drivers/mfd/arizona-i2c.c| 6 +++---
> drivers/mfd/as3711.c | 5 ++---
> drivers/mfd/as3722.c | 5 ++---
> drivers/mfd/atc260x-i2c.c| 5 ++---
> drivers/mfd/axp20x-i2c.c | 5 ++---
> drivers/mfd/bcm590xx.c | 5 ++---
> drivers/mfd/bd9571mwv.c | 5 ++---
> drivers/mfd/da903x.c | 6 +++---
> drivers/mfd/da9052-i2c.c | 6 +++---
> drivers/mfd/da9055-i2c.c | 5 ++---
> drivers/mfd/da9062-core.c| 6 +++---
> drivers/mfd/da9063-i2c.c | 6 +++---
> drivers/mfd/da9150-core.c| 5 ++---
> drivers/mfd/khadas-mcu.c | 5 ++---
> drivers/mfd/lm3533-core.c| 5 ++---
> drivers/mfd/lp3943.c | 4 ++--
> drivers/mfd/lp873x.c | 5 ++---
> drivers/mfd/lp87565.c| 5 ++---
> drivers/mfd/lp8788.c | 4 ++--
> drivers/mfd/madera-i2c.c | 6 +++---
> drivers/mfd/max14577.c | 6 +++---
> drivers/mfd/max77620.c | 6 +++---
> drivers/mfd/max77693.c | 6 +++---
> drivers/mfd/max77843.c | 6 +++---
> drivers/mfd/max8907.c| 5 ++---
> drivers/mfd/max8925-i2c.c| 5 ++---
> drivers/mfd/max8997.c| 6 +++---
> drivers/mfd/max8998.c| 6 +++---
> drivers/mfd/mc13xxx-i2c.c| 6 +++---
> drivers/mfd/menelaus.c | 5 ++---
> drivers/mfd/menf21bmc.c | 4 ++--
> drivers/mfd/palmas.c | 5 ++---
> drivers/mfd/pcf50633-core.c | 5 ++---
> drivers/mfd/rc5t583.c| 5 ++---
> drivers/mfd/retu-mfd.c | 4 ++--
> drivers/mfd/rk808.c | 5 ++---
> drivers/mfd/rohm-bd718x7.c | 5 ++---
> drivers/mfd/rsmu_i2c.c | 6 +++---
> drivers/mfd/rt5033.c | 5 ++---
> drivers/mfd/sec-core.c | 5 ++---
> drivers/mfd/si476x-i2c.c | 6 +++---
> drivers/mfd/sky81452.c | 5 ++---
> drivers/mfd/stmfx.c | 5 ++---
> drivers/mfd/stmpe-i2c.c | 5 +++--
> drivers/mfd/stpmic1.c| 5 ++---
> drivers/mfd/stw481x.c| 5 ++---
> drivers/mfd/tc3589x.c| 6 +++---
> drivers/mfd/ti-lmu.c | 5 +++--
> drivers/mfd/tps6105x.c | 5 ++---
> drivers/mfd/tps65010.c | 6 +++---
> drivers/mfd/tps6507x.c | 5 ++---
