[Openipmi-developer] [PATCH 33/34] drivers: remove incorrect of_match_ptr/ACPI_PTR annotations

From: Arnd Bergmann When building with CONFIG_OF and/or CONFIG_ACPI disabled but W=1 extra warnings enabled, a lot of driver cause a warning about an unused ID table: drivers/char/tpm/tpm_ftpm_tee.c:356:34: error: unused variable 'of_ftpm_tee_ids' [-Werror,-Wunused-const-variable] drivers/dma

[Openipmi-developer] [PATCH 00/34] address all -Wunused-const warnings

From: Arnd Bergmann Compilers traditionally warn for unused 'static' variables, but not if they are constant. The reason here is a custom for C++ programmers to define named constants as 'static const' variables in header files instead of using macros or enums. In W=1 builds, we get warnings

Re: [Openipmi-developer] [PATCH 2/9] dma: Convert from tasklet to BH workqueue

On Thu, Mar 28, 2024, at 20:39, Allen wrote: >> > >> > Since almost every driver associates the tasklet with the >> > dma_chan, we could go one step further and add the >> > work_queue structure directly into struct dma_chan, >> > with the wrapper operating on the dma_chan rather than >> > the

Re: [Openipmi-developer] [PATCH 2/9] dma: Convert from tasklet to BH workqueue

On Thu, Mar 28, 2024, at 06:55, Vinod Koul wrote: > On 27-03-24, 16:03, Allen Pais wrote: >> The only generic interface to execute asynchronously in the BH context is >> tasklet; however, it's marked deprecated and has some design flaws. To >> replace tasklets, BH workqueue support was recently

Re: [Openipmi-developer] [PATCH v3 03/38] char: impi, tpm: depend on HAS_IOPORT

On Tue, Mar 14, 2023, at 15:17, Geert Uytterhoeven wrote: >> --- a/drivers/char/Kconfig >> +++ b/drivers/char/Kconfig >> @@ -34,6 +34,7 @@ config TTY_PRINTK_LEVEL >> config PRINTER >> tristate "Parallel printer support" >> depends on PARPORT >> + depends on HAS_IOPORT > >

Re: [Openipmi-developer] [PATCH v3 03/38] char: impi, tpm: depend on HAS_IOPORT

On Tue, Mar 14, 2023, at 13:20, Jarkko Sakkinen wrote: > On Tue, Mar 14, 2023 at 01:11:41PM +0100, Niklas Schnelle wrote: > Reviewed-by: Jarkko Sakkinen > > Who should pick this? All patches in this series depend on patch 1, so either I merge them all through the asm-generic tree, or I ask

Re: [Openipmi-developer] [PATCH] HPE BMC GXP SUPPORT

On Wed, Feb 2, 2022 at 7:14 PM Verdun, Jean-Marie wrote: > > > This is far too big for a single patch. It needs to be broken into > > functional chunks that can be reviewed individually. Each driver and > > each device tree change along with it's accompanying code need to be > > done in

[Openipmi-developer] [PATCH] ipmi: ipmb: add CONFIG_I2C dependency

From: Arnd Bergmann When CONFIG_I2C is a loadable module, the slave interface is not available to built-in drivers: x86_64-linux-ld: drivers/char/ipmi/ipmi_ipmb.o: in function `ipmi_ipmb_remove': ipmi_ipmb.c:(.text+0x37): undefined reference to `i2c_slave_unregister' x86_64-linux-ld: drivers

Re: [Openipmi-developer] [PATCH v2 16/21] ipmi: kcs_bmc: Add a "raw" character device interface

On Tue, Apr 13, 2021 at 1:45 AM Andrew Jeffery wrote: > On Mon, 12 Apr 2021, at 18:18, Arnd Bergmann wrote: > > On Mon, Apr 12, 2021 at 3:33 AM Andrew Jeffery wrote: > > > On Fri, 9 Apr 2021, at 17:25, Arnd Bergmann wrote: > > > > On Fri, Mar 19, 2021 at

Re: [Openipmi-developer] [PATCH v2 16/21] ipmi: kcs_bmc: Add a "raw" character device interface

On Mon, Apr 12, 2021 at 3:33 AM Andrew Jeffery wrote: > On Fri, 9 Apr 2021, at 17:25, Arnd Bergmann wrote: > > On Fri, Mar 19, 2021 at 7:31 AM Andrew Jeffery wrote: > > > > > > The existing IPMI chardev encodes IPMI behaviours as the name suggests. > > > Ho

Re: [Openipmi-developer] [PATCH v2 16/21] ipmi: kcs_bmc: Add a "raw" character device interface

On Fri, Mar 19, 2021 at 7:31 AM Andrew Jeffery wrote: > > The existing IPMI chardev encodes IPMI behaviours as the name suggests. > However, KCS devices are useful beyond IPMI (or keyboards), as they > provide a means to generate IRQs and exchange arbitrary data between a > BMC and its host

Re: [Openipmi-developer] [PATCH v2 00/21] ipmi: Allow raw access to KCS devices

On Fri, Apr 9, 2021 at 6:09 AM Joel Stanley wrote: > On Thu, 8 Apr 2021 at 23:47, Andrew Jeffery wrote: > > On Thu, 8 Apr 2021, at 21:44, Corey Minyard wrote: > > > On Thu, Apr 08, 2021 at 10:27:46AM +0930, Andrew Jeffery wrote: > > > There were some minor concerns that were unanswered, and

Re: [Openipmi-developer] [PATCH v1 1/1] kernel.h: Split out panic and oops helpers

to use new header. > Though for time being include new header back to kernel.h to avoid twisted > indirected includes for existing users. > > Signed-off-by: Andy Shevchenko Nice! Acked-by: Arnd Bergmann ___ Openipmi-developer m

Re: [Openipmi-developer] [PATCH 0/5] drivers/char: Constify static variables

o - Constify id_table[] > ipmi: watchdog: Constify ident > virtio_console: Constify some static variables I just realized it was a series rather than a single patch I received. They all look correct, so Acked-by: Arnd Bergmann but if you do more of those, I would suggest not including the

Re: [Openipmi-developer] [PATCH 4/8] ipmi: kill off 'timespec' usage again

On Fri, Nov 8, 2019 at 11:11 PM Corey Minyard wrote: > > On Fri, Nov 08, 2019 at 09:34:27PM +0100, Arnd Bergmann wrote: > > 'struct timespec' is getting removed from the kernel. The usage in ipmi > > was fixed before in commit 48862ea2ce86 ("ipmi: Update timespec

[Openipmi-developer] [PATCH 4/8] ipmi: kill off 'timespec' usage again

ementation. Fixes: cbb19cb1eef0 ("ipmi_si: Convert timespec64 to timespec") Signed-off-by: Arnd Bergmann --- drivers/char/ipmi/ipmi_si_intf.c | 40 +++- 1 file changed, 13 insertions(+), 27 deletions(-) diff --git a/drivers/char/ipmi/ipmi_si_intf.c

[Openipmi-developer] [PATCH 0/8] y2038: bug fixes from y2038 work

/?h=y2038-endgame Arnd Arnd Bergmann (8): y2038: timex: remove incorrect time_t truncation timekeeping: optimize ns_to_timespec64 powerpc: fix vdso32 for ppc64le ipmi: kill off 'timespec' usage again netfilter: xt_time: use time64_t lp: fix sparc64 LPSETTIMEOUT ioctl ppdev: fix

[PATCH v5 06/18] compat_ioctl: move WDIOC handling into wdt drivers

not need the compat_ioctl handling. Signed-off-by: Arnd Bergmann --- arch/powerpc/platforms/52xx/mpc52xx_gpt.c | 1 + arch/um/drivers/harddog_kern.c| 1 + drivers/char/ipmi/ipmi_watchdog.c | 1 + drivers/hwmon/fschmd.c| 1 + drivers/rtc/rtc-ds1374.c

[Openipmi-developer] [PATCH v5 00/18] compat_ioctl.c removal, part 2/3

to ppp_generic Arnd Bergmann (16): xfs: compat_ioctl: use compat_ptr() xfs: compat_ioctl: add missing conversions gfs2: add compat_ioctl support fs: compat_ioctl: move FITRIM emulation into file systems watchdog: cpwd: use generic compat_ptr_ioctl compat_ioctl: move WDIOC handling into wdt

[Openipmi-developer] [PATCH] ipmi: ipmb: don't allocate i2c_client on stack

with this implementation; when user space passes a length of more than I2C_SMBUS_BLOCK_MAX bytes, all the rest is silently ignored. This should probably be addressed in a separate patch, but I don't know what the intended behavior is here. Fixes: 51bd6f291583 ("Add support for IPMB driver") Signed-of

Re: [Openipmi-developer] [PATCH] ipmi: avoid atomic_inc in exit function

On Mon, Apr 15, 2019 at 7:39 PM Corey Minyard wrote: > > On Mon, Apr 15, 2019 at 09:40:22AM -0700, Christoph Hellwig wrote: > > On Mon, Apr 15, 2019 at 05:55:00PM +0200, Arnd Bergmann wrote: > > > This causes a link failure on ARM in certain configurations, > > >

[Openipmi-developer] [PATCH] ipmi: avoid atomic_inc in exit function

`.exit.text' of drivers/char/ipmi/ipmi_msghandler.o In this case, we can trivially replace the atomic_inc() with an atomic_set() that has the same effect and does not require a fixup. Signed-off-by: Arnd Bergmann --- drivers/char/ipmi/ipmi_msghandler.c | 2 +- 1 file changed, 1 insertion(+), 1

[Openipmi-developer] [PATCH] ipmi: Change to ktime_get_ts64()

settimeofday() or leap second. The uses in ipmi are either for debugging prints or for comparing against a prior timestamp, so using a monotonic ktime_get_ts64() is probably best here. Signed-off-by: Arnd Bergmann --- drivers/char/ipmi/ipmi_si_intf.c | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [Openipmi-developer] [PATCH v2] ipmi: Fix error code in try_smi_init()

t to set it in the future. > > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> > --- > v2: Don't initialize "rv" and fix a typo in the commit message This addresses my comment, so Acked-by: Arnd Bergmann <a...@arndb.de> -

Re: [Openipmi-developer] [PATCH] ipmi: missing error code in try_smi_init()

On Tue, Mar 6, 2018 at 10:58 AM, Dan Carpenter wrote: > If platform_device_alloc() then we should return -ENOMEM instead of > returning success. > > Signed-off-by: Dan Carpenter Looks good, though I would probably remove that incorrect 'rv =

Re: [Openipmi-developer] [PATCH 1/3] ipmi/bt-bmc: change compatible node to 'aspeed, ast2400-ibt-bmc'

On Tuesday, November 8, 2016 12:15:57 PM CET Corey Minyard wrote: > On 11/08/2016 09:52 AM, Cédric Le Goater wrote: > > O > snip > > While we're modifying the binding, should we add a compat string for > the ast2500? > >>> Well, if the change in this patch is fine for all, may be we can

Re: [Openipmi-developer] [PATCH 1/3] ipmi/bt-bmc: change compatible node to 'aspeed, ast2400-ibt-bmc'

On Wednesday, November 2, 2016 3:28:01 PM CET Cédric Le Goater wrote: > On 11/02/2016 02:56 PM, Joel Stanley wrote: > > On Wed, Nov 2, 2016 at 11:45 PM, Arnd Bergmann <a...@arndb.de> wrote: > >> On Wednesday 02 November 2016, Cédric Le Goater wrote: > >>> Th

Re: [Openipmi-developer] [PATCH 1/3] ipmi/bt-bmc: change compatible node to 'aspeed, ast2400-ibt-bmc'

On Wednesday 02 November 2016, Cédric Le Goater wrote: > The Aspeed SoCs have two BT interfaces : one is IPMI compliant and the > other is H8S/2168 compliant. > > The current ipmi/bt-bmc driver implements the IPMI version and we > should reflect its nature in the compatible node name using >

Re: [Openipmi-developer] [PATCH v2 0/3] ARM: aspeed: add support for the BT IPMI interface

On Friday, September 16, 2016 12:39:24 PM CEST Cédric Le Goater wrote: > > Cédric Le Goater (2): > ARM: aspeed: Add defconfigs for CONFIG_ASPEED_BT_IPMI_BMC > ARM: dts: aspeed: Enable BT IPMI BMC device These two should go through the arm-soc tree, I assume Joel will forward them to

Re: [Openipmi-developer] [PATCH v2 1/3] ipmi: add an Aspeed BT IPMI BMC driver

st...@popple.id.au> > Signed-off-by: Jeremy Kerr <j...@ozlabs.org> > Signed-off-by: Joel Stanley <j...@jms.id.au> > Acked-by: Arnd Bergmann <a...@arndb.de> -- _

[Openipmi-developer] [PATCH] ipmi: avoid gcc warning

better to rework the code to avoid this. Signed-off-by: Arnd Bergmann a...@arndb.de Fixes: 7ea0ed2b5be81 (ipmi: Make the message handler easier to use for SMI interfaces) diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c index 6b65fa4e0c55..fb0f8eacd208 100644

[Openipmi-developer] [PATCH] ipmi: work around gcc-4.9 build warning

assignments but not smart enough. Marking the ipmi_thread_busy_wait function as inline gives the gcc optimization logic enough information to figure out for itself that the case cannot happen, which gets rid of the warning without adding any fake initialization. Signed-off-by: Arnd Bergmann a...@arndb.de

Re: [Openipmi-developer] IPMI misbehaving on ARM defconfigs, was [Re: stable boot: 18 pass, 4 fail (v3.10.39)]

On Wednesday 07 May 2014 10:20:56 Jason Cooper wrote: ipmi message handler version 39.2 IPMI System Interface driver. ipmi_si: Adding default-specified kcs state machine ipmi_si: Trying default-specified kcs state machine at i/o address 0xca2, slave address 0x0, irq 0 ipmi_si: Could

Re: [Openipmi-developer] [PATCH 31/62] driver/char: irq: Remove IRQF_DISABLED

On Wednesday 07 September 2011, Yong Zhang wrote: This flag is a NOOP and can be removed now. Signed-off-by: Yong Zhang yong.zha...@gmail.com Acked-by: Arnd Bergmann a...@arndb.de -- Doing More with Less: The Next

[Openipmi-developer] [PATCH 11/12] ipmi: autoconvert trivial BKL users to private mutex

' fi Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Corey Minyard miny...@acm.org Cc: openipmi-developer@lists.sourceforge.net --- drivers/char/ipmi/ipmi_devintf.c | 14 +++--- drivers/char/ipmi/ipmi_watchdog.c |8 2 files changed, 11 insertions(+), 11 deletions(-) diff

[Openipmi-developer] [PATCH 00/12] autoconvert trivial BKL users to private mutex

AB-BA deadlock. Please apply to the respective maintainer trees if the patches look good. Arnd Bergmann (12): staging: autoconvert trivial BKL users to private mutex isdn: autoconvert trivial BKL users to private mutex scsi: autoconvert trivial BKL users to private mutex media: autoconvert

Re: [Openipmi-developer] [patch 1/1] updated version, fixed the compiler warning

On Thursday 25 January 2007 01:45, Benjamin Herrenschmidt wrote: If the underlying ipmi stuff cannot cleanup, then the driver should not have a module_exit() so the module cannot be removed. It can do the cleanup, but it won't go through the driver's remove function currently, because it also

Re: [Openipmi-developer] [patch 1/1] next updated version, fixed cleanup and some minors

with compatible settings ipmi-kcs, ipmi-smic and ipmi-bt. Only ipmi-kcs could be tested. Signed-off-by: Christian Krafft [EMAIL PROTECTED] Acked-by: Heiko J Schick [EMAIL PROTECTED] Signed-off-by: Corey Minyard [EMAIL PROTECTED] Acked-by: Arnd Bergmann [EMAIL PROTECTED] Of course, the subject line

Re: [Openipmi-developer] [patch 0/1] ipmi: add autosensing of ipmi device on powerpc using device-tree

On Friday 08 December 2006 01:41, Paul Mackerras wrote: Christian Krafft writes: the patch I'll send, adds of_device support to the ipmi_si module. Having the correct device-tree entries, the ipmi module can be loaded without specifying the resources as module parameters. Which

Re: [Openipmi-developer] [patch 1/1] ipmi: add autosensing of ipmi device on powerpc using device-tree

On Friday 08 December 2006 23:50, Benjamin Herrenschmidt wrote: + info-io.regsize= resource0.end - resource0.start + 1; + info-io.regspacing = resource1.start - resource0.start; Are you sure this is a reliable way to check the register spacing and register size?