Re: [Openipmi-developer] [PATCH -next] ipmi: bt-bmc: use devm_platform_ioremap_resource() to simplify code

2019-10-16 Thread Cédric Le Goater
o not do > this. yes. Looks good to me. Reviewed-by: Cédric Le Goater Thanks, C. > -corey > >> >> Signed-off-by: YueHaibing >> --- >> drivers/char/ipmi/bt-bmc.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/

Re: [Openipmi-developer] linux 4.19-rc4 oops in acquire_ipmi_user()

2018-09-18 Thread Cédric Le Goater
On 09/18/2018 02:37 PM, Corey Minyard wrote: > On 09/18/2018 02:27 AM, Cédric Le Goater wrote: >> Hello Corey, >> >> I just noticed this panic message on an OpenPOWER system running 4.19.0-rc4 >> (plus some custom KVM PPC patches). AFAICT the system was idle and I did

[Openipmi-developer] linux 4.19-rc4 oops in acquire_ipmi_user()

2018-09-18 Thread Cédric Le Goater
Hello Corey, I just noticed this panic message on an OpenPOWER system running 4.19.0-rc4 (plus some custom KVM PPC patches). AFAICT the system was idle and I did not see anything similar on 4.18. Could it be commit 2512e40e48d2 ("ipmi: Rework SMI registration failure") ? Thanks, C.

Re: [Openipmi-developer] [RFC v1 4/4] ipmi_bmc: bt-aspeed: port driver to IPMI BMC framework

2017-08-10 Thread Cédric Le Goater
On 08/10/2017 04:31 AM, Jeremy Kerr wrote: > Hi Brendan, > >> The driver was handling interaction with userspace on its own. This >> patch changes it to use the functionality of the ipmi_bmc framework >> instead. >> >> Note that this removes the ability for the BMC to set SMS_ATN by making >> an

Re: [Openipmi-developer] [PATCH] ipmi: bt-bmc: Add ast2500 compatible string

2017-03-22 Thread Cédric Le Goater
On 03/22/2017 03:01 PM, Joel Stanley wrote: > The ast2500 SoCs contain the same IPMI BT device. > > Signed-off-by: Joel Stanley <j...@jms.id.au> Reviewed-by: Cédric Le Goater <c...@kaod.org> Thanks, C. > --- > Documentation/devicetree/bindings/ipmi/asp

Re: [Openipmi-developer] [PATCH] ipmi: bt-bmc: Use a regmap for register access

2016-12-06 Thread Cédric Le Goater
rebooting and powering down the host. > > Signed-off-by: Andrew Jeffery <and...@aj.id.au> It would be nice to have an example of the associated binding. I did not see it. A part from that : Reviewed-by: Cédric Le Goater <c...@kaod.org> Thanks, C. > --- > drivers/char/ipmi/Kconfig

Re: [Openipmi-developer] [PATCH] ipmi: bt-bmc: Use a regmap for register access

2016-12-05 Thread Cédric Le Goater
-off-by: Andrew Jeffery <and...@aj.id.au> It would be nice to have an example of the associated binding. I did not see it. A part from that : Reviewed-by: Cédric Le Goater <c...@kaod.org> Thanks, C. > --- > drivers/char/ipmi/Kconfig | 1 + > drivers/char/ipmi/bt-bmc.c | 82

Re: [Openipmi-developer] [PATCH 2/3] ipmi/bt-bmc: maintain a request expiry list

2016-11-09 Thread Cédric Le Goater
On 11/09/2016 04:52 PM, Corey Minyard wrote: > On 11/09/2016 08:30 AM, Cédric Le Goater wrote: >> On 11/07/2016 08:04 PM, Corey Minyard wrote: >>> On 11/02/2016 02:57 AM, Cédric Le Goater wrote: >>>> Regarding the response expiration handling, the IPMI spec says

Re: [Openipmi-developer] [PATCH 3/3] ipmi/bt-bmc: add a sysfs file to configure a maximum response time

2016-11-09 Thread Cédric Le Goater
On 11/07/2016 07:37 PM, Corey Minyard wrote: > Sorry, I was at Plumbers and extra busy with other stuff. Just getting > around to reviewing this. > > On 11/02/2016 02:57 AM, Cédric Le Goater wrote: >> We could also use an ioctl for that purpose. sysfs seems a better >>

[Openipmi-developer] [PATCH 0/3] ipmi/bt-bmc: fix compatible node and add a request expiry list

2016-11-02 Thread Cédric Le Goater
Hello Corey, Here is a short serie fixing the name of the device tree 'compatible' node of the ipmi/bt-bmc driver and adding a request expiry list to the driver. The first patch should be considered as a 4.9 fix, if possible. Thanks, C. Cédric Le Goater (3): ipmi/bt-bmc: change compatible

[Openipmi-developer] [PATCH 2/3] ipmi/bt-bmc: maintain a request expiry list

2016-11-02 Thread Cédric Le Goater
is updated each time a request is received and a response is sent. The expiration of the reponses is handled at each updates but also with a timer. Signed-off-by: Cédric Le Goater <c...@kaod.org> --- drivers/char/ipmi/bt-bmc.c | 132 + 1 file change

[Openipmi-developer] [PATCH 1/3] ipmi/bt-bmc: change compatible node to 'aspeed, ast2400-ibt-bmc'

2016-11-02 Thread Cédric Le Goater
should be used for a H8S interface driver if it is implemented one day. Signed-off-by: Cédric Le Goater <c...@kaod.org> --- .../ipmi/{aspeed,ast2400-bt-bmc.txt => aspeed,ast2400-ibt-bmc.txt}| 4 ++-- drivers/char/ipmi/bt-bmc.c| 4 ++--

Re: [Openipmi-developer] [PATCH v3 1/3] ipmi: add an Aspeed BT IPMI BMC driver

2016-09-28 Thread Cédric Le Goater
On 09/28/2016 03:53 PM, Corey Minyard wrote: > On 09/26/2016 01:50 AM, Cédric Le Goater wrote: >> >>>> Changes since v1: >>>> >>>> - replace 'bt_host' by 'bt_bmc' to reflect that the driver is >>>> the BMC side of the IPMI

Re: [Openipmi-developer] [PATCH] ipmi: Fix ioremap error handling in bt-bmc

2016-09-21 Thread Cédric Le Goater
On 09/21/2016 12:05 PM, Joel Stanley wrote: > devm_ioremap_resource returns ERR_PTR so we can't check for NULL. Thanks for spotting this. Acked-by: Cédric Le Goater <c...@kaod.org> C. > Signed-off-by: Joel Stanley <j...@jms.id.au> > --- > drivers/char/ipmi/bt-bmc.c |

Re: [Openipmi-developer] [PATCH v3 0/3] ARM: aspeed: add support for the BT IPMI interface

2016-09-20 Thread Cédric Le Goater
On 09/20/2016 04:58 PM, Corey Minyard wrote: > On 09/20/2016 02:01 AM, Cédric Le Goater wrote: >> Hello, >> >> This serie adds support for the iBT interface on Aspeed SOCs (AST2400 >> and AST2500). The BT (Block Transfer) interface is used to perform >> in-band

[Openipmi-developer] [PATCH v3 1/3] ipmi: add an Aspeed BT IPMI BMC driver

2016-09-20 Thread Cédric Le Goater
under drivers/char/ipmi/ but kept it as a misc device - changed the compatible cell to "aspeed,ast2400-bt-bmc" ] Signed-off-by: Cédric Le Goater <c...@kaod.org> Acked-by: Arnd Bergmann <a...@arndb.de> [clg: - checkpatch --strict fixes - removed the us

[Openipmi-developer] [PATCH v3 2/3] ARM: aspeed: Add defconfigs for CONFIG_ASPEED_BT_IPMI_BMC

2016-09-20 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater <c...@kaod.org> --- Changes since v1: - renamed config option arch/arm/configs/aspeed_g4_defconfig | 1 + arch/arm/configs/aspeed_g5_defconfig | 1 + 2 files changed, 2 insertions(+) diff --git a/arch/arm/configs/aspeed_g4_defconfig b/arch/arm/c

Re: [Openipmi-developer] [PATCH v2 1/3] ipmi: add an Aspeed BT IPMI BMC driver

2016-09-19 Thread Cédric Le Goater
On 09/16/2016 09:41 PM, Corey Minyard wrote: > On 09/16/2016 05:39 AM, Cédric Le Goater wrote: >> From: Alistair Popple <alist...@popple.id.au> >> >> This patch adds a simple device driver to expose the iBT interface on >> Aspeed SOCs (AST2400 and AST2500)

Re: [Openipmi-developer] [PATCH v2 1/3] ipmi: add an Aspeed BT IPMI BMC driver

2016-09-16 Thread Cédric Le Goater
On 09/16/2016 02:29 PM, LABBE Corentin wrote: > Hello > > I have some minor comment below: > > On Fri, Sep 16, 2016 at 12:39:25PM +0200, Cédric Le Goater wrote: >> From: Alistair Popple <alist...@popple.id.au> >> >> This patch adds a simple device driver t

[Openipmi-developer] [PATCH v2 3/3] ARM: dts: aspeed: Enable BT IPMI BMC device

2016-09-16 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater <c...@kaod.org> --- Changes since v1: - added the soc name ast2400 in the compatible cell arch/arm/boot/dts/aspeed-g4.dtsi | 6 ++ arch/arm/boot/dts/aspeed-g5.dtsi | 6 ++ 2 files changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/aspeed-g

[Openipmi-developer] [PATCH v2 2/3] ARM: aspeed: Add defconfigs for CONFIG_ASPEED_BT_IPMI_BMC

2016-09-16 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater <c...@kaod.org> --- Changes since v1: - renamed config option arch/arm/configs/aspeed_g4_defconfig | 1 + arch/arm/configs/aspeed_g5_defconfig | 1 + 2 files changed, 2 insertions(+) diff --git a/arch/arm/configs/aspeed_g4_defconfig b/arch/arm/c

[Openipmi-developer] [PATCH v2 1/3] ipmi: add an Aspeed BT IPMI BMC driver

2016-09-16 Thread Cédric Le Goater
under drivers/char/ipmi/ but kept it as a misc device - changed the compatible cell to "aspeed,ast2400-bt-bmc" ] Signed-off-by: Cédric Le Goater <c...@kaod.org> --- Changes since v1: - replace 'bt_host' by 'bt_bmc' to reflect that the driver is the BMC side of the