big.
Handle a bogus BMC a little better, fix autoload on some systems,
remove some deprecated interfaces from the docs.
--------
Corey Minyard (1):
ipmi:ssif: Improve detecting during probing
Wolfram Sang (1):
ipmi: docs:
On Tue, Sep 10, 2024 at 5:19 AM Ivan T. Ivanov wrote:
>
> Hi Corey,
>
> On 08-20 20:05, Corey Minyard wrote:
> >
> > If an IPMI SSIF device is probed and there is something there, but
> > probably not an actual BMC, the code would just issue a lot of errors
> >
On Wed, Sep 04, 2024 at 07:41:32PM +0200, Christophe JAILLET via
Openipmi-developer wrote:
> Le 04/09/2024 à 06:12, zhangjiao2 a écrit :
> > From: zhang jiao
> >
> > Use devm_kasprintf to simplify code.
>
> Hi,
>
> I don't think that it is correct because __ipmi_bmc_register() is not a
> probe
On Sun, Sep 01, 2024 at 11:02:11AM +0200, Wolfram Sang wrote:
> "i2c-adapter" class entries are deprecated since 2009. Switch to the
> proper location.
Thanks, in my queue.
-corey
>
> Reported-by: Heiner Kallweit
> Closes:
> https://lore.kernel.org/r/80c4a898-5867-4162-ac85-bdf7c7c68...@gmail
On Tue, Aug 27, 2024 at 10:07 AM Pavel Cahyna wrote:
>
> Hello Corey,
>
> On Thu, Aug 22, 2024 at 11:28:42AM -0500, Corey Minyard via
> Openipmi-developer wrote:
> > There was a bug found by AWS Security that affected the IPMI simulator,
> > ipmi_sim. It does NOT af
There was a bug found by AWS Security that affected the IPMI simulator,
ipmi_sim. It does NOT affect the main library, just the simulator. This
is mainly used for testing (by OpenIPMI and others) but I am fairly sure
that some people are using this in production systems to control QEMU
systems and
On Thu, Aug 22, 2024 at 10:22:55AM +0300, Ivan T. Ivanov wrote:
> Hi Corey,
>
> On 08-20 20:05, Corey Minyard wrote:
> >
> > If an IPMI SSIF device is probed and there is something there, but
> > probably not an actual BMC, the code would just issue a lot of errors
>
should alway work. If that fails,
nothing else is going to work and it's a pretty good indication that
there's no valid BMC there. So issue and check that command and bail
if it fails.
Reported-by: Ivan T. Ivanov
Signed-off-by: Corey Minyard
---
drivers/char/ipmi/ipmi_s
On Tue, Aug 20, 2024 at 5:15 AM Ivan T. Ivanov wrote:
>
> On 08-18 12:27, Ivan T. Ivanov wrote:
> >
> > >
> > > 3) It appears the response to the GET_DEVICE_ID command, though a
> > > response is returned, is not valid. The right way to handle this would
> > > be to do more validation in the ssif
On Fri, Aug 16, 2024 at 09:54:58AM +0300, Ivan T. Ivanov wrote:
> It is pointless to continue module probing when communication
> with device is failing. This just fill logs with misleading
> messages like this:
So the BMC (or whatever is there) responds to a GET_DEVICE_ID command,
but then doesn'
One of the fixes in the cleanup in 2.0.35 broke RMCP+ in lanserv/ipmi_sim.
Note that this does not affect the main library, just the simulator that
I use for testing, but some people use ipmi_sim for other things, so
this release is for those users.
-corey
__
The following changes since commit 0cac73eb3875f6ecb6105e533218dba1868d04c9:
Merge tag 'pm-6.10-rc4' of
git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm (2024-06-14
09:52:51 -0700)
are available in the Git repository at:
https://github.com/cminyard/linux-ipmi.git tags/for-linu
On Mon, Jul 08, 2024 at 05:09:12PM +0200, Uwe Kleine-König wrote:
> These drivers don't use the driver_data member of struct i2c_device_id,
> so don't explicitly initialize this member.
>
> This prepares putting driver_data in an anonymous union which requires
> either no initialization or named d
On Fri, Jun 14, 2024 at 08:30:44PM +0300, Dan Carpenter wrote:
> There are actually two bugs here. First, we need to ensure that count
> is at least sizeof(u32) or msg.len will be uninitialized data.
>
> The "msg.len" variable is a u32 that comes from the user. On 32bit
> systems the "sizeof_fie
On Thu, Jun 13, 2024 at 11:59:46AM -0600, Rob Herring wrote:
> On Wed, Jun 12, 2024 at 12:32:54PM +0800, Potin Lai wrote:
> > In ARM Server Base Manageability Requirements (SBMR) document, Callers can
> > choose to not read back Response Data after sending the command "Send Boot
> > Progress Code".
The following changes since commit 8d025e2092e29bfd13e56c78e22af25fac83c8ec:
Merge tag 'erofs-for-6.9-rc2-fixes' of
git://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs (2024-03-27 20:24:09
-0700)
are available in the Git repository at:
https://github.com/cminyard/linux-ipmi.git tags/
I spent some time going analyzing with Coverity and CodeQL to clean up a
bunch of issues. No functional changes, just bug fixes. You should
upgrade.
-corey
___
Openipmi-developer mailing list
Openipmi-developer@lists.sourceforge.net
https://lists.sourc
On Thu, Apr 11, 2024 at 09:15:03AM +0200, Uwe Kleine-König wrote:
> Hello,
>
> On Tue, Mar 05, 2024 at 05:26:57PM +0100, Uwe Kleine-König wrote:
> > this series converts all drivers below drivers/char/ipmi to struct
> > platform_driver::remove_new(). See commit 5c5a7680e67b ("platform: Provide a
>
On Thu, Apr 04, 2024 at 12:45:05PM +0200, Niklas Schnelle wrote:
> Hi Corey,
>
> This is a follow up in my ongoing effort of making inb()/outb() and
> similar I/O port accessors compile-time optional. Previously I sent this
> as a treewide series titled "treewide: Remove I/O port accessors for
> H
On Wed, Apr 03, 2024 at 12:30:44PM +0300, Andy Shevchenko wrote:
> On Wed, Apr 03, 2024 at 10:06:51AM +0200, Arnd Bergmann wrote:
> > From: Arnd Bergmann
> >
> > When building with CONFIG_OF and/or CONFIG_ACPI disabled but W=1 extra
> > warnings enabled, a lot of driver cause a warning about an u
testing for a configuration that doesn't matter in practice.
>
> I considered splitting up the large patch into per subsystem patches, but
> since
> it's really just the same thing everywhere it feels better to do it all at
> once.
>
> Signed-off-by:
t; > own
> > > workqueue.
> > >
> > > Thanks for taking time out to review.
> >
> > After looking and thinking about it a bit, a BH context is still
> > probably the best for this.
> >
> > I have tested this patch under load and vari
On Thu, Mar 28, 2024 at 10:52:16AM -0700, Allen wrote:
> On Wed, Mar 27, 2024 at 11:05 AM Corey Minyard wrote:
> >
> > I believe that work queues items are execute single-threaded for a work
> > queue, so this should be good. I need to test this, though. It may be
> &
On Wed, Mar 27, 2024 at 04:03:11PM +, Allen Pais wrote:
> The only generic interface to execute asynchronously in the BH context is
> tasklet; however, it's marked deprecated and has some design flaws. To
> replace tasklets, BH workqueue support was recently added. A BH workqueue
> behaves simi
On Wed, Feb 21, 2024 at 10:57:38AM -0600, Andrew Geissler wrote:
>
>
> > On Feb 20, 2024, at 4:36 PM, Andrew Jeffery
> > wrote:
> >
> > On Tue, 2024-02-20 at 13:33 -0600, Corey Minyard wrote:
> >> On Tue, Feb 20, 2024 at 04:51:21PM +0100, Paul Menzel wr
On Tue, Feb 20, 2024 at 04:51:21PM +0100, Paul Menzel wrote:
> Dear Andrew,
>
>
> Thank you for your patch. Some style suggestions.
>
> Am 20.02.24 um 13:36 schrieb Andrew Geissler:
> > From: Andrew Geissler
>
> (Oh no, Yahoo. (ignore))
>
> You could be more specific in the git commit message
The following changes since commit ceb6a6f023fd3e8b07761ed900352ef574010bcb:
Linux 6.7-rc6 (2023-12-17 15:19:28 -0800)
are available in the Git repository at:
https://github.com/cminyard/linux-ipmi.git tags/for-linus-6.8-1
for you to fetch changes up to 9bd9fbd9032a3b7e9ea916d6e58ba0116e062
On Tue, Dec 19, 2023 at 06:00:39AM +0100, Christophe JAILLET wrote:
> ida_alloc() and ida_free() should be preferred to the deprecated
> ida_simple_get() and ida_simple_remove().
>
> This is less verbose.
Thanks, queued for next release.
-corey
>
> Signed-off-by: Christophe JAILLET
> ---
> d
On Wed, Nov 22, 2023 at 08:34:28PM +, Emilio Perez wrote:
> regspacings parameter is currently ignored and the platform data uses a
> default value of 0, this has been fixed by setting the appropriate field
> in the platform data.
Yep, queued for next release. Thank you.
-corey
>
> Fixes:
On Wed, Nov 15, 2023 at 03:02:29PM -0600, Rob Herring wrote:
> Use preferred device_get_match_data() instead of of_match_device() to
> get the driver match data. With this, adjust the includes to explicitly
> include the correct headers.
Sorry, this is now queue for 6.8.
-corey
>
> Signed-off-b
On Thu, Nov 09, 2023 at 04:41:00PM +0100, Christian Theune wrote:
>
> > On 9. Nov 2023, at 14:50, Corey Minyard wrote:
> >
> > It's 09c5ba0aa2fc "printk: add kthread console printers" and some
> > others. It's in 5.19, so it was later than I tho
On Thu, Nov 09, 2023 at 10:14:22AM +0100, Christian Theune via
Openipmi-developer wrote:
> Hi,
>
>
>
> > On 3. Oct 2023, at 07:13, Corey Minyard wrote:
> >
> > Yeah, I understand how this would be a strange scenario. I have seen
> > this happen in the r
The following changes since commit 3669558bdf354cd352be955ef2764cde6a9bf5ec:
Merge tag 'for-6.6-rc1-tag' of
git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux (2023-09-12 11:28:00
-0700)
are available in the Git repository at:
https://github.com/cminyard/linux-ipmi.git tags/for-linu
On Tue, Oct 03, 2023 at 06:47:49AM +0200, Christian Theune wrote:
> Hey,
>
> > On 2. Oct 2023, at 17:08, Corey Minyard wrote:
> >
> > On Mon, Oct 02, 2023 at 08:05:09AM +0200, Christian Theune wrote:
> >
> > ...snip...
> >
> >>>> Can y
On Mon, Oct 02, 2023 at 08:05:09AM +0200, Christian Theune wrote:
...snip...
> > > Can you not get kernel coredumps?
> > Unfortunately no and I still have absolutely now idea why the watchdog
> > triggers… I have currently attached dozens of servers that are part of a
> > mysterious series of c
On Oct 1, 2023 11:14 AM, Christian Theune via Openipmi-developer wrote:Hi,
> On 1. Oct 2023, at 03:49, Corey Minyard wrote:
>
> On Sat, Sep 30, 2023 at 11:14:01PM +0200, Christian Theune via Openipmi-developer wrote:
>> Hi,
>>
>> sorry if this isn’t directly a develo
On Sat, Sep 30, 2023 at 11:14:01PM +0200, Christian Theune via
Openipmi-developer wrote:
> Hi,
>
> sorry if this isn’t directly a developers question, but I’ve run out of
> avenues after googling and looking around…
>
> We’re experiencing weird system stability issue where the “log to SEL”
>
On Wed, Sep 13, 2023 at 05:13:04PM +, Justin Stitt wrote:
> `strncpy` is deprecated for use on NUL-terminated destination strings [1].
Thanks, applied to my next tree.
-corey
>
> In this case, strncpy is being used specifically for its NUL-padding
> behavior (and has been commented as such)
On Tue, Sep 12, 2023 at 05:55:02PM -0700, Justin Stitt wrote:
> On Tue, Sep 12, 2023 at 5:19 PM Corey Minyard wrote:
> >
> > On Tue, Sep 12, 2023 at 11:43:05PM +, Justin Stitt wrote:
> > > `strncpy` is deprecated for use on NUL-terminated destination strings [1].
On Tue, Sep 12, 2023 at 11:43:05PM +, Justin Stitt wrote:
> `strncpy` is deprecated for use on NUL-terminated destination strings [1].
>
> In this case, strncpy is being used specifically for its NUL-padding
> behavior (and has been commented as such). We can use a more robust and
> less ambig
It's been over a year since 2.0.33. Not much has changed, really, a few small
things for improved usability.
This has some required changes for gensio testing of ipmi SOL.
Probably worth upgrading if you can.
___
Openipmi-developer mailing list
Openi
l deadlock on &kcs_bmc->lock
Corey Minyard (3):
ipmi_watchdog: Fix read syscall not responding to signals during sleep
ipmi:ssif: Fix a memory leak when scanning for an adapter
ipmi: Change request_module to request_module_nowait
Ivan Orlov (1):
ipmi: make ipmi_cla
On Wed, Aug 09, 2023 at 09:05:17PM +, Justin Stitt wrote:
> With W=1 we see the following warning:
>
> | drivers/char/ipmi/ipmi_si_platform.c:272:15: error: \
> | cast to smaller integer type 'enum si_type' from \
> | 'const void *' [-Werror,-Wvoid-pointer-to-enum-cast]
> |272
On Wed, Aug 09, 2023 at 09:05:17PM +, Justin Stitt wrote:
> With W=1 we see the following warning:
>
> | drivers/char/ipmi/ipmi_si_platform.c:272:15: error: \
> | cast to smaller integer type 'enum si_type' from \
> | 'const void *' [-Werror,-Wvoid-pointer-to-enum-cast]
> |272
On Fri, Jun 30, 2023 at 10:31:02AM +0930, Andrew Jeffery wrote:
> Hi Corey, Chengfeng,
>
> On Wed, 28 Jun 2023, at 21:17, Corey Minyard wrote:
> > Indeed, this looks like an issue.
> >
> > Andrew, any opinions on this? The attached patch will work, the other
>
On Thu, Jun 29, 2023 at 08:33:28PM +0800, GONG, Ruiqi wrote:
> From: Yi Yang
>
> Kmemleak reported the following leak info in try_smi_init():
>
> unreferenced object 0x00018ecf9400 (size 1024):
> comm "modprobe", pid 2707763, jiffies 4300851415 (age 773.308s)
> backtrace:
> [<000
Indeed, this looks like an issue.
Andrew, any opinions on this? The attached patch will work, the other
option would be to disable interrupts when calling
kcs_bmc_handle_event() in the timer handler. But then you have to worry
about RT.
-corey
On Tue, Jun 27, 2023 at 03:24:49PM +, Chengfen
of having to be dynamically
> allocated at boot time.
This is in my next tree and seems to work fine. Thanks.
-corey
>
> Cc: Corey Minyard
> Cc: openipmi-developer@lists.sourceforge.net
> Suggested-by: Greg Kroah-Hartman
> Signed-off-by: Ivan Orlov
> Signed-off-by: Greg Kroah
On Mon, Jun 19, 2023 at 05:28:02PM +0800, Jiasheng Jiang wrote:
> Add check for the return value of kstrdup() and return the error
> if it fails in order to avoid NULL pointer dereference.
Thanks, this is in my next tree.
-corey
>
> Fixes: c4436c9149c5 ("ipmi_ssif: avoid registering duplicate s
On Sat, Jun 10, 2023 at 08:49:27AM +0930, Andrew Jeffery wrote:
>
>
> On Fri, 9 Jun 2023, at 23:37, Krzysztof Kozlowski wrote:
> > Cleanup bindings dropping unneeded quotes. Once all these are fixed,
> > checking for this can be enabled in yamllint.
> >
> > Signed-off-by: Krzysztof Kozlowski
>
quot;) convert
> back to (the new) .probe() to be able to eventually drop .probe_new() from
> struct i2c_driver.
Ok, this is in my for-next tree.
Or, if you prefer:
Acked-by: Corey Minyard
if you would prefer to apply this, and I can drop mine.
-corey
>
> Signed-off-by: Uwe
On Mon, May 15, 2023 at 05:19:41AM -0700, Yu Chen wrote:
> A simple reproducer demonstrating the problem: (use ipmi_watchdog.ko)
>
> In one terminal:
>
> $ cat /dev/watchdog
> ...
>
> In another terminal:
>
> $ ps -aux | grep cat
> 14755 pts/1R+43:00 cat /dev/watchdog
> 51943 pts/2S
On Wed, May 17, 2023 at 04:54:12PM +0800, Zhen Ni wrote:
> Read syscall cannot response to sigals when data_to_read remains at 0
> and the while loop cannot break. Fix it.
>
> Signed-off-by: Zhen Ni
> ---
> drivers/char/ipmi/ipmi_watchdog.c | 9 -
> 1 file changed, 4 insertions(+), 5 del
PMI driver
There was a bug in the SSIF driver where in certain conditions it could
stop working.
Outside of that: spelling fixes, removing some dead code, re-adding a
missing statistic increment, and removal of register_sysctl_table().
----
Andrew, what do you think?
-corey
On Wed, Apr 19, 2023 at 05:00:32PM +0200, Govert Overgaauw via
Openipmi-developer wrote:
> While the KCS driver is not in KCS_PHASE_WAIT_READ state it returns
> -EINVAL to userspace on a write call. change this to -EAGAIN to indicate
> that the error is related
On Wed, Apr 12, 2023 at 05:07:21PM +0200, Uwe Kleine-König wrote:
> On Fri, Dec 30, 2022 at 01:44:31PM +0100, Uwe Kleine-König wrote:
> > For both variants (platform and i2c driver) after a successful bind
> > (i.e. .probe completed without error) driver data is set to a non-NULL
> > value.
> >
>
On Wed, Apr 12, 2023 at 03:49:07PM +0800, Zhang Yuchen wrote:
> The ipmi communication is not restored after a specific version of BMC is
> upgraded on our server.
> The ipmi driver does not respond after printing the following log:
Excellent explaination, this is queued in my branch for the next
On Thu, Mar 16, 2023 at 02:39:58PM +0800, zipeng zhang wrote:
> There is a spelling mistake in the comment information. Fix it.
It's in my queue. Thanks.
-corey
>
> Signed-off-by: zipeng zhang
> ---
> drivers/char/ipmi/ipmi_ssif.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
e explicitly
> testing your original?
We can just wait. The problem is obvious now, and the backports are in
progress.
Thanks for helping me with this.
-corey
>
> Christian
>
> > On 15. Mar 2023, at 13:07, Corey Minyard wrote:
> >
> > On Wed, Mar 15, 2023
too. Her it
is:
a01a89b1db ("ipmi/watchdog: replace atomic_add() and atomic_sub()")
Also attached.
-corey
>
>
> > On 14. Mar 2023, at 18:29, Corey Minyard wrote:
> >
> > Well, dang, I had already fixed this a year and a half ago. I wish I
> >
ve already requested a backport to 5.4 and 5.10. The backport was
requested in the patch, but it fell out in the earlier kernels because
of a missing prerequisite.
Thanks,
-corey
>
> Christian
>
> > On 14. Mar 2023, at 18:29, Corey Minyard wrote:
> >
> > Well, dang,
e, Mar 14, 2023 at 03:58:26PM +0100, Christian Theune via
Openipmi-developer wrote:
> Awesome!
>
> > On 14. Mar 2023, at 15:54, Corey Minyard wrote:
> >
> > On Tue, Mar 14, 2023 at 03:22:39PM +0100, Christian Theune via
> > Openipmi-developer wrote:
> >>
ndler
> [ 6522.052628] IPMI message handler: IPMI: handling panic event for intf 0:
> 0000443777b3 000067d05ff8
> …
> and then it reboots after the 255 seconds from the watchdog timer are passed.
>
> Christian
>
> > On 13. Mar 2023, at 18:13, Corey Minyard wrot
portions, this looks good.
Acked-by: Corey Minyard
Thanks
-corey
>
> Co-developed-by: Arnd Bergmann
> Signed-off-by: Niklas Schnelle
> ---
> drivers/char/Kconfig | 3 ++-
> drivers/char/ipmi/Makefile | 11 ---
> drivers/char/ipmi/ipmi_si_i
urn values, and adds traces in the IPMI panic event
handlers.
It's a single patch right on top of 6.2; I'm not sure how portable it is
to other kernel versions. I can port if you like.
Thanks,
-corey
>
> Cheers,
> Christian
>
> > On 13. Mar 2023, at 13:58, Cor
000a R09:
> 7f58739c2f40
> [1107586.040504] R10: 005cc348 R11: 0246 R12:
> 0002
> [1107586.047794] R13: 7f5873a00520 R14: 7f5873a00720 R15:
> 0002
>
> Nothing obvious to me here … if you have any further idea
ing offer still stands.)
Any news on this? I'm curious what this could be.
-corey
>
> Christian
>
> > On 1. Mar 2023, at 17:58, Corey Minyard wrote:
> >
> > On Tue, Feb 28, 2023 at 06:36:17PM +0100, Christian Theune wrote:
> >> Thanks, both machi
On Thu, Mar 02, 2023 at 12:46:07PM -0800, Luis Chamberlain wrote:
> register_sysctl_table() is a deprecated compatibility wrapper.
> register_sysctl() can do the directory creation for you so just use
> that.
Thanks, I have included this in my tree for the next merge window.
-corey
>
> Signed-o
s happing.
Maybe something is getting in the way of the panic notifiers and doing
something to prevent the IPMI driver from working.
-corey
>
>
> > On 28. Feb 2023, at 18:04, Corey Minyard wrote:
> >
> > Oh, I forgot. You can look at panic_op in
> >
Oh, I forgot. You can look at panic_op in
/sys/module/ipmi_msghandler/parameters/panic_op
-corey
On Tue, Feb 28, 2023 at 05:48:07PM +0100, Christian Theune via
Openipmi-developer wrote:
> Hi,
>
> > On 28. Feb 2023, at 17:36, Corey Minyard wrote:
> >
> > On Tue, Fe
On Tue, Feb 28, 2023 at 02:53:12PM +0100, Christian Theune via
Openipmi-developer wrote:
> Hi,
>
> I’ve been trying to debug the PANIC and OEM string handling and am running
> out of ideas whether this is a bug or whether something so subtle has changed
> in my config that I’m just not seeing i
quot; or "depends on" can also help reduce
> Kconfig circular dependency issues.
>
> Therefore, change the use of "depends on REGMAP_MMIO" to
> "select REGMAP_MMIO", which will also set REGMAP.
This seems reasonable. I can take it into my tree, or..
Ac
IPMI and IPMB driver
Nothing big, cleanups, fixing names, and one small deviation from the
specification fixed.
Christophe JAILLET (1):
ipmi: ipmb: Fix the MODULE_PARM_DESC associated to 'retry_time_ms'
Corey Minyard (4
On Sun, Feb 05, 2023 at 11:04:01AM +0100, Christophe JAILLET wrote:
> 'This should be 'retry_time_ms' instead of 'max_retries'.
Oops. Applied to my next tree.
Thanks,
-corey
>
> Fixes: 63c4eb347164 ("ipmi:ipmb: Add initial support for IPMI over IPMB")
> Signed-off-by: Christophe JAILLET
> --
):
ipmi/watchdog: Include when appropriate
Corey Minyard (1):
ipmi:ssif: Increase the message retry time
Dan Carpenter (1):
ipmi: fix use after free in _ipmi_destroy_user()
Quan Nguyen (3):
ipmi: ssif_bmc: Add SSIF BMC driver
bindings: ipmi: Add binding for SSIF BMC
On Mon, Dec 05, 2022 at 07:36:40PM +0800, yang.yan...@zte.com.cn wrote:
> Xu Panda
>
> The implementation of strscpy() is more robust and safer.
> That's now the recommended way to copy NUL terminated strings.
This looks right. Applied, thanks.
-corey
>
> Signed-off-by: Xu Panda
> Signed-of
On Fri, Nov 18, 2022 at 11:45:39PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
Thanks, queued for next release.
-corey
>
> Signed-off-by: Uwe Kleine-König
> ---
> drivers
On Tue, Nov 15, 2022 at 04:17:43PM +0300, Dan Carpenter wrote:
> The intf_free() function frees the "intf" pointer so we cannot
> dereference it again on the next line.
Thanks. I will request a backport for 5.5 and later.
>
> Fixes: cbb79863fc31 ("ipmi: Don't allow device module unload when in
On Sat, Nov 05, 2022 at 12:16:54PM +0100, Christophe JAILLET wrote:
> The kstrto() functions have been moved from kernel.h to
> kstrtox.h.
>
> So, in order to eventually remove from ,
> include the latter directly in the appropriate files.
This is in my queue. Thanks.
-corey
>
> Signed-off-b
On Thu, Oct 27, 2022 at 10:20:15AM -0500, Corey Minyard wrote:
> On Thu, Oct 27, 2022 at 11:05:35AM -0400, Steven Rostedt wrote:
> > From: "Steven Rostedt (Google)"
> >
> > Before a timer is freed, del_timer_shutdown() must be called.
>
> Thanks, this is
On Thu, Oct 27, 2022 at 11:05:35AM -0400, Steven Rostedt wrote:
> From: "Steven Rostedt (Google)"
>
> Before a timer is freed, del_timer_shutdown() must be called.
Thanks, this is in my queue, or:
Acked-by: Corey Minyard
if you prefer that.
-corey
>
> Link: ht
On Tue, Oct 25, 2022 at 02:04:36AM -0400, Bo Liu wrote:
> The current code provokes some kernel-doc warnings:
> drivers/char/ipmi/ipmi_msghandler.c:618: warning: This comment starts
> with '/**', but isn't a kernel-doc comment. Refer
> Documentation/doc-guide/kernel-doc.rst
Thanks, this is
On Mon, Oct 24, 2022 at 02:59:56PM +0700, Quan Nguyen wrote:
> This fixes the following sparse warning:
> sparse warnings: (new ones prefixed by >>)
> >> drivers/char/ipmi/ssif_bmc.c:254:22: sparse: sparse: invalid assignment: |=
> >> drivers/char/ipmi/ssif_bmc.c:254:22: sparse:left side has ty
On Sun, Oct 09, 2022 at 05:18:09PM +0800, Zhang Yuchen wrote:
> If you continue to access and send messages at a high frequency (once
> every 55s) when the IPMI is disconnected, messages will accumulate in
> intf->[hp_]xmit_msg. If it lasts long enough, it takes up a lot of
> memory.
This is queue
On Sat, Oct 08, 2022 at 09:36:16AM +0800, Yuchen Zhang wrote:
> > Also, the following is in start_kcs_transaction():
> >
> > if ((kcs->state != KCS_IDLE) && (kcs->state != KCS_HOSED)) {
> > dev_warn(kcs->io->dev, "KCS in invalid state %d\n", kcs->state);
> > return IPMI
On Fri, Oct 07, 2022 at 05:26:17PM +0800, Zhang Yuchen wrote:
> After the IPMI disconnect problem, the memory kept rising and we tried
> to unload the driver to free the memory. However, only part of the
> free memory is recovered after the driver is uninstalled. Using
> ebpf to hook free functions
On Fri, Oct 07, 2022 at 05:26:16PM +0800, Zhang Yuchen wrote:
> When fixing the problem mentioned in PATCH1, we also found
> the following problem:
>
> If the IPMI is disconnected and in the sending process, the
> uninstallation driver will be stuck for a long time.
>
> The main problem is that u
On Fri, Oct 07, 2022 at 05:26:15PM +0800, Zhang Yuchen wrote:
> If you continue to access and send messages at a high frequency (once
> every 55s) when the IPMI is disconnected, messages will accumulate in
> intf->[hp_]xmit_msg. If it lasts long enough, it takes up a lot of
> memory.
The IPMI driv
On Thu, Oct 06, 2022 at 01:36:51PM +1030, Andrew Jeffery wrote:
>
>
> On Thu, 6 Oct 2022, at 10:20, Joel Stanley wrote:
> > On Fri, 12 Aug 2022 at 14:48, Andrew Jeffery wrote:
> >>
> >> The ASPEED KCS devices don't provide a BMC-side interrupt for the host
> >> reading the output data register (
On Thu, Oct 06, 2022 at 09:42:57AM +1030, Andrew Jeffery wrote:
> Hi Corey,
>
> On Sat, 13 Aug 2022, at 00:17, Andrew Jeffery wrote:
> > The ASPEED KCS devices don't provide a BMC-side interrupt for the host
> > reading the output data register (ODR). The act of the host reading ODR
> > clears the
On Tue, Oct 04, 2022 at 04:31:03PM +0700, Quan Nguyen wrote:
> This series add support the SSIF BMC driver which is to perform in-band
> IPMI communication with their host in management (BMC) side.
>
> SSIF BMC driver in this series is tested with Aspeed AST2500 and AST2600
I have applied the two
On Tue, Sep 27, 2022 at 01:38:14PM +, Yuan Can wrote:
> After commit e86ee2d44b44("ipmi: Rework locking and shutdown for hot remove"),
> no one use struct watcher_entry, so remove it.
Thanks, got it.
-corey
>
> Signed-off-by: Yuan Can
> ---
> drivers/char/ipmi/ipmi_msghandler.c | 6 --
On Fri, Sep 23, 2022 at 12:38:08AM +, ChiaWei Wang wrote:
> > From: Corey Minyard On Behalf Of Corey Minyard
> > Sent: Friday, September 23, 2022 8:21 AM
> >
> > On Fri, Sep 23, 2022 at 12:08:07AM +, ChiaWei Wang wrote:
> > > Hi Corey,
> > >
On Fri, Sep 23, 2022 at 12:08:07AM +, ChiaWei Wang wrote:
> Hi Corey,
>
> > From: Corey Minyard On Behalf Of Corey Minyard
> > Sent: Friday, September 23, 2022 2:58 AM
> >
> > On Tue, Sep 20, 2022 at 10:03:33AM +0800, Chia-Wei Wang wrote:
> > > Remove
On Tue, Sep 20, 2022 at 10:03:33AM +0800, Chia-Wei Wang wrote:
> Remove AST_usrGuide_KCS.pdf as it is no longer maintained.
Even if it's no longer maintained, is it useful? It seems better to
leave in useful documentation unless it has been replaced with something
else.
-corey
>
> Add more des
On Thu, Sep 22, 2022 at 07:19:24PM +0800, Xiu Jianfeng wrote:
> Add missing __init/__exit annotations to module init/exit funcs.
Applied, thanks.
-corey
>
> Signed-off-by: Xiu Jianfeng
> ---
> drivers/char/ipmi/ipmi_ssif.c | 4 ++--
> drivers/char/ipmi/kcs_bmc_cdev_ipmi.c | 4 ++--
>
Adding Andrew, the author of this code.
On Sun, Sep 04, 2022 at 03:35:16PM +0200, Christophe JAILLET wrote:
> KCS_MSG_BUFSIZ is 1000.
>
> When using devm_kmalloc(), there is a small memory overhead and, on most
> systems, this leads to 40 bytes of extra memory allocation.
> So 1040 bytes are expe
On Mon, Aug 15, 2022 at 06:15:40PM -0700, Jay Vosburgh wrote:
> Corey Minyard wrote:
>
> >On Fri, Aug 12, 2022 at 04:33:18PM -0700, Jay Vosburgh wrote:
> >> We have observed issues wherein the IPMI driver will sleep forever in
> >> uninterruptible wait with mutexes
On Fri, Aug 12, 2022 at 04:33:18PM -0700, Jay Vosburgh wrote:
> We have observed issues wherein the IPMI driver will sleep forever in
> uninterruptible wait with mutexes held (specifically, dyn_mutex and
> bmc_reg_mutex, acquired by __bmc_get_device_id). This occurs ultimately
> due to a BMC firmw
On Mon, Aug 08, 2022 at 03:38:45PM +0300, Krzysztof Kozlowski wrote:
> On 08/08/2022 15:26, Corey Minyard wrote:
> > On Mon, Aug 08, 2022 at 11:11:16AM +0300, Krzysztof Kozlowski wrote:
> >> On 08/08/2022 09:54, Tomer Maimon wrote:
> >>> Add to npcm845 KCS compatibl
1 - 100 of 1387 matches
Mail list logo
