Re: [Openipmi-developer] [PATCH v2 1/3] ipmi: add an Aspeed BT IPMI BMC driver

Hello I have some minor comment below: On Fri, Sep 16, 2016 at 12:39:25PM +0200, Cédric Le Goater wrote: > From: Alistair Popple > > This patch adds a simple device driver to expose the iBT interface on > Aspeed SOCs (AST2400 and AST2500) as a character device. Such SOCs

[Openipmi-developer] [PATCH 2/4] ipmi: constify the reason parameter of start_error_recovery

Both start_error_recovery() function are different but they didn't modify the reason parameter. Furthermore, the reason parameter is always given string literal. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- drivers/char/ipmi/ipmi_kcs_sm.c | 2 +- drivers/cha

[Openipmi-developer] [PATCH 3/4] ipmi: Replace all printk(KERN_xxx by their pr_xxx counterpart

This patch replace all printk(KERN_XXX) by their pr_xxx counterparts. This will also permit to remove some line wrapping. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- drivers/char/ipmi/ipmi_si_intf.c | 91 +--- 1 file changed, 39 inse

[Openipmi-developer] [PATCH] ipmi: constify some struct and char arrays

Lots of char arrays could be set as const since they contain only literal char arrays. We could in the same time make const some struct members who are pointer to those const char arrays. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- drivers/char/ipmi/ipmi_msghandler.

[Openipmi-developer] [PATCH] ipmi: constify some struct and char arrays

Lots of char arrays could be set as const since they contain only literal char arrays. We could in the same time make const some struct members who are pointer to those const char arrays. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- drivers/char/ipmi/ipmi_msghandler.