Re: [Openipmi-developer] [RFC PATCH 15/17] ipmi: kcs: aspeed: Implement v2 bindings

在 2019-07-26 13:39, Andrew Jeffery 写道: The v2 bindings allow us to extract the resources from the devicetree. The table in the driver is retained to derive the channel index, which removes the need for kcs_chan property from the v1 bindings. The v2 bindings allow us to reduce the number of

Re: [RFC PATCH 14/17] ipmi: kcs: Finish configuring ASPEED KCS device before enable

在 2019-07-27 01:04, Wang, Haiyue 写道: 在 2019-07-26 13:39, Andrew Jeffery 写道: The currently interrupts are configured after the channel was enabled. Cc: Haiyue Wang Cc: Corey Minyard Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc:openipmi-developer@lists.sourceforge.net Signed-off-by: Andrew

Re: [RFC PATCH 14/17] ipmi: kcs: Finish configuring ASPEED KCS device before enable

在 2019-07-26 13:39, Andrew Jeffery 写道: The currently interrupts are configured after the channel was enabled. Cc: Haiyue Wang Cc: Corey Minyard Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc:openipmi-developer@lists.sourceforge.net Signed-off-by: Andrew Jeffery ---

Re: [Openipmi-developer] [PATCH] ipmi: kcs_bmc: handle devm_kasprintf() failure case

[Resend for wrong reply HTML format mail] Great check for making kcs_bmc module be more stable and handle things gracefully. My tag if needed. Reviewed-by: Haiyue Wang 在 2018-11-27 21:36, Corey Minyard 写道: On 11/21/18 9:08 AM, Nicholas Mc Guire wrote: devm_kasprintf() may return NULL

Re: [Openipmi-developer] [PATCH] ipmi: kcs_bmc: handle devm_kasprintf() failure case

Great check for making kcs_bmc module be more stable and handle things gracefully. My tag if needed. Reviewed-by: Haiyue Wang 在 2018-11-27 21:36, Corey Minyard 写道: On 11/21/18 9:08 AM, Nicholas Mc Guire wrote: devm_kasprintf() may return NULL if internal allocation failed so this

Re: [Openipmi-developer] [PATCH v2] ipmi: kcs_bmc: fix IRQ exception if the channel is not open

On 2018-06-26 03:34, Corey Minyard wrote: return 0 to low level IRQ handler to indicate that the IRQ is handled. I've looked at this some more, and I think it's ok, especially with the better description. I'm going to submit this for the current release after it sits in next for a bit.

Re: [Openipmi-developer] [PATCH ] ipmi: kcs_bmc: fix IRQ exception if the channel is not open

On 2018-06-23 01:23, Wang, Haiyue wrote: Maybe it's best to have the interrupt disabled unless the device is open. You have to handle the interrupt disable race on a close, but with the sync functions that shouldn't be too hard. In fact, in BMC chip design, the LPC controller has many

Re: [Openipmi-developer] [PATCH ] ipmi: kcs_bmc: fix IRQ exception if the channel is not open

On 2018-06-22 20:43, Corey Minyard wrote: Signed-off-by: Haiyue Wang --- Hi Corey, This patch looks introducing BIG modification, it should be easily understandable, and makes code clean & fix an error design, which is introduced by misunderstanding the IRQ return value. I'm having a

Re: [Openipmi-developer] [PATCH ipmi/kcs_bmc v1] ipmi: kcs_bmc: optimize the data buffers allocation

On 2018-04-13 21:50, Corey Minyard wrote: On 04/07/2018 02:54 AM, Wang, Haiyue wrote: Hi Corey, Since IPMI 2.0 just defined minimum, no maximum: KCS/SMIC Input : Required: 40 bytes IPMI Message, minimum KCS/SMIC Output : Required: 38 bytes IPMI Message, minimum Yes, though

Re: [Openipmi-developer] [PATCH ipmi/kcs_bmc v1] ipmi: kcs_bmc: optimize the data buffers allocation

case. And I think this patch make checking simple (from 3 to 1), and the code clean, this is the biggest reason I want to change. The TLB is just memory management study from book, no data to support access improvement. :) BR, Haiyue On 2018-04-07 10:37, Wang, Haiyue wrote: On 2018-04-07

Re: [Openipmi-developer] [PATCH ipmi/kcs_bmc v1] ipmi: kcs_bmc: optimize the data buffers allocation

On 2018-04-07 05:47, Corey Minyard wrote: On 03/15/2018 07:20 AM, Haiyue Wang wrote: Allocate a continuous memory block for the three KCS data buffers with related index assignment. I'm finally getting to this. Is there a reason you want to do this?  In general, it's better to not try to

Re: [Openipmi-developer] [PATCH ipmi/kcs_bmc v1] ipmi: kcs_bmc: optimize the data buffers allocation

Just a small piece of cake, not so urgent. I just try to understand the code commitment process, such as time etc. :) Thanks! BR, Haiyue On 2018-04-04 02:45, Corey Minyard wrote: On 04/03/2018 01:00 AM, Wang, Haiyue wrote: Hi Corey, The 4.17 merge window is opened now, this patch

Re: [Openipmi-developer] [PATCH ipmi/kcs_bmc v1] ipmi: kcs_bmc: optimize the data buffers allocation

Hi Corey, The 4.17 merge window is opened now, this patch is not yet in linux-next tree, so it will be merged into 4.18 ? Thanks & Regards, Haiyue On 2018-03-15 20:20, Haiyue Wang wrote: Allocate a continuous memory block for the three KCS data buffers with related index assignment.

Re: [Openipmi-developer] [PATCH] ipmi: kcs_bmc: mark expected switch fall-through in kcs_bmc_handle_data

On 2018-02-15 05:46, Corey Minyard wrote: On 02/14/2018 11:30 AM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Thanks, queued for next release. -corey Addresses-Coverity-ID: 1465255 ("Missing break

Re: [Openipmi-developer] [PATCH arm/aspeed/ast2500 v5 1/2] ipmi: add a KCS IPMI BMC driver

On 2018-02-02 21:52, Corey Minyard wrote: On 02/01/2018 08:16 PM, Haiyue Wang wrote: --- v4->v5 - Fix -Wdiscarded-qualifiers 'const' compile warning. - Fix size_t printk compile error. v3->v4 - Change to accept WRITE_START any time. v2->v3 - Update the KCS phase state machine. - Fix the race

Re: [Openipmi-developer] [PATCH arm/aspeed/ast2500 v3 1/2] ipmi: add a KCS IPMI BMC driver

On 2018-02-02 04:32, Corey Minyard wrote: +static void kcs_bmc_handle_cmd(struct kcs_bmc *kcs_bmc) +{ +    u8 cmd; + +    set_state(kcs_bmc, WRITE_STATE); +    write_data(kcs_bmc, KCS_ZERO_DATA); + +    cmd = read_data(kcs_bmc); +    switch (cmd) { +    case KCS_CMD_WRITE_START: +    if

Re: [Openipmi-developer] [PATCH arm/aspeed/ast2500 v2] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-31 09:52, Corey Minyard wrote: On 01/30/2018 07:37 PM, Wang, Haiyue wrote: On 2018-01-31 09:25, Corey Minyard wrote: On 01/30/2018 07:02 PM, Wang, Haiyue wrote: On 2018-01-31 08:52, Corey Minyard wrote: On 01/30/2018 06:02 PM, Wang, Haiyue wrote: On 2018-01-30 21:49

Re: [Openipmi-developer] [PATCH arm/aspeed/ast2500 v2] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-31 09:25, Corey Minyard wrote: On 01/30/2018 07:02 PM, Wang, Haiyue wrote: On 2018-01-31 08:52, Corey Minyard wrote: On 01/30/2018 06:02 PM, Wang, Haiyue wrote: On 2018-01-30 21:49, Corey Minyard wrote: On 01/29/2018 07:57 AM, Wang, Haiyue wrote: On 2018-01-26 22:48

Re: [Openipmi-developer] [PATCH arm/aspeed/ast2500 v2] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-31 08:52, Corey Minyard wrote: On 01/30/2018 06:02 PM, Wang, Haiyue wrote: On 2018-01-30 21:49, Corey Minyard wrote: On 01/29/2018 07:57 AM, Wang, Haiyue wrote: On 2018-01-26 22:48, Corey Minyard wrote: On 01/26/2018 12:08 AM, Wang, Haiyue wrote: On 2018-01-25 01:48

Re: [Openipmi-developer] [PATCH arm/aspeed/ast2500 v2] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-30 21:49, Corey Minyard wrote: On 01/29/2018 07:57 AM, Wang, Haiyue wrote: On 2018-01-26 22:48, Corey Minyard wrote: On 01/26/2018 12:08 AM, Wang, Haiyue wrote: On 2018-01-25 01:48, Corey Minyard wrote: On 01/24/2018 10:06 AM, Haiyue Wang wrote: The KCS (Keyboard Controller

Re: [Openipmi-developer] [PATCH arm/aspeed/ast2500 v2] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-26 22:48, Corey Minyard wrote: On 01/26/2018 12:08 AM, Wang, Haiyue wrote: On 2018-01-25 01:48, Corey Minyard wrote: On 01/24/2018 10:06 AM, Haiyue Wang wrote: The KCS (Keyboard Controller Style) interface is used to perform in-band IPMI communication between a server host

Re: [Openipmi-developer] [PATCH arm/aspeed/ast2500 v2] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-25 01:48, Corey Minyard wrote: On 01/24/2018 10:06 AM, Haiyue Wang wrote: The KCS (Keyboard Controller Style) interface is used to perform in-band IPMI communication between a server host and its BMC (BaseBoard Management Controllers). This driver exposes the KCS interface on

Re: [Openipmi-developer] [PATCH arm/aspeed/ast2500 v2] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-25 01:05, Andy Shevchenko wrote: On Thu, 2018-01-25 at 00:06 +0800, Haiyue Wang wrote: The KCS (Keyboard Controller Style) interface is used to perform in- band IPMI communication between a server host and its BMC (BaseBoard Management Controllers). +config ASPEED_KCS_IPMI_BMC +

Re: [Openipmi-developer] [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-18 10:58, Corey Minyard wrote: On 01/17/2018 06:16 PM, Wang, Haiyue wrote: On 2018-01-17 23:59, Corey Minyard wrote: On 01/17/2018 08:31 AM, Wang, Haiyue wrote: On 2018-01-17 06:12, Corey Minyard wrote: On 01/16/2018 02:59 PM, Corey Minyard wrote: On 01/16/2018 05:43 AM

Re: [Openipmi-developer] [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-18 00:31, Corey Minyard wrote: On 01/17/2018 08:31 AM, Wang, Haiyue wrote: Snip... + +struct kcs_bmc { +    struct regmap *map; +    spinlock_t lock; This lock is only used in threads, as far as I can tell. Couldn't it just be a normal mutex? But more on this later

Re: [Openipmi-developer] [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-17 23:59, Corey Minyard wrote: On 01/17/2018 08:31 AM, Wang, Haiyue wrote: On 2018-01-17 06:12, Corey Minyard wrote: On 01/16/2018 02:59 PM, Corey Minyard wrote: On 01/16/2018 05:43 AM, Haiyue Wang wrote: The KCS (Keyboard Controller Style) interface is used to perform in-band

Re: [Openipmi-developer] [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

Thanks Avi, wait for your response when new patch is ready. :-) BR, Haiyue On 2018-01-17 20:54, Avi Fishman wrote: Sounds great for us (Nuvoton). Avi. On Wed, Jan 17, 2018 at 8:32 AM, Wang, Haiyue <haiyue.w...@linux.intel.com> wrote: On 2018-01-17 07:06, Joel Stanley wrote: On Tue,

Re: [Openipmi-developer] [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-17 06:12, Corey Minyard wrote: On 01/16/2018 02:59 PM, Corey Minyard wrote: On 01/16/2018 05:43 AM, Haiyue Wang wrote: The KCS (Keyboard Controller Style) interface is used to perform in-band IPMI communication between a server host and its BMC (BaseBoard Management

Re: [Openipmi-developer] [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-17 07:06, Joel Stanley wrote: On Tue, Jan 16, 2018 at 2:59 PM, Corey Minyard wrote: On 01/16/2018 05:43 AM, Haiyue Wang wrote: The KCS (Keyboard Controller Style) interface is used to perform in-band IPMI communication between a server host and its BMC (BaseBoard

Re: [Openipmi-developer] [PATCH linux ipmi for BMC v2] ipmi: add an Aspeed KCS IPMI BMC driver

On 2017-12-21 09:07, Joel Stanley wrote: On Thu, Dec 21, 2017 at 6:41 AM, Corey Minyard wrote: On 12/14/2017 10:34 PM, Haiyue Wang wrote: This patch adds a simple device driver to expose the KCS interface on Aspeed SOCs (AST2400 and AST2500) as a character device. Such

Re: [Openipmi-developer] [PATCH linux ipmi for BMC v2] ipmi: add an Aspeed KCS IPMI BMC driver

On 2017-12-21 09:12, Corey Minyard wrote: On 12/20/2017 06:59 PM, Wang, Haiyue wrote: On 2017-12-21 04:11, Corey Minyard wrote: On 12/14/2017 10:34 PM, Haiyue Wang wrote: This patch adds a simple device driver to expose the KCS interface on Aspeed SOCs (AST2400 and AST2500) as a character

Re: [Openipmi-developer] [PATCH linux ipmi for BMC v2] ipmi: add an Aspeed KCS IPMI BMC driver

On 2017-12-21 04:11, Corey Minyard wrote: On 12/14/2017 10:34 PM, Haiyue Wang wrote: This patch adds a simple device driver to expose the KCS interface on Aspeed SOCs (AST2400 and AST2500) as a character device. Such SOCs are commonly used as BMCs (BaseBoard Management Controllers) and this