Re: [Openipmi-developer] [PATCH] ipmi: missing error code in try_smi_init()

2018-03-06 Thread Corey Minyard
On 03/06/2018 03:58 AM, Dan Carpenter wrote: If platform_device_alloc() then we should return -ENOMEM instead of returning success. Thanks, queued for next release. -corey Signed-off-by: Dan Carpenter diff --git a/drivers/char/ipmi/ipmi_si_intf.c

Re: [Openipmi-developer] [PATCH] ipmi: missing error code in try_smi_init()

2018-03-06 Thread Dan Carpenter
On Tue, Mar 06, 2018 at 11:26:19AM +0100, Julia Lawall wrote: > > > On Tue, 6 Mar 2018, Dan Carpenter wrote: > > > If platform_device_alloc() then we should return -ENOMEM instead of > > returning success. > > It looks like the word "fails" got lost here. > Thanks. Let me resend. regards,

Re: [Openipmi-developer] [PATCH] ipmi: missing error code in try_smi_init()

2018-03-06 Thread Julia Lawall
On Tue, 6 Mar 2018, Dan Carpenter wrote: > If platform_device_alloc() then we should return -ENOMEM instead of > returning success. It looks like the word "fails" got lost here. julia > > Signed-off-by: Dan Carpenter > > diff --git

Re: [Openipmi-developer] [PATCH] ipmi: missing error code in try_smi_init()

2018-03-06 Thread Arnd Bergmann
On Tue, Mar 6, 2018 at 10:58 AM, Dan Carpenter wrote: > If platform_device_alloc() then we should return -ENOMEM instead of > returning success. > > Signed-off-by: Dan Carpenter Looks good, though I would probably remove that incorrect 'rv =

[Openipmi-developer] [PATCH] ipmi: missing error code in try_smi_init()

2018-03-06 Thread Dan Carpenter
If platform_device_alloc() then we should return -ENOMEM instead of returning success. Signed-off-by: Dan Carpenter diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c index f2a294f78892..ff870aa91cfe 100644 ---