Re: [Openipmi-developer] [PATCH] ipmi: kcs_bmc: handle devm_kasprintf() failure case

2018-11-27 Thread Corey Minyard
On 11/27/18 6:54 PM, Wang, Haiyue wrote: [Resend for wrong reply HTML format mail] Great check for making kcs_bmc module be more stable and handle things gracefully. My tag if needed. Reviewed-by: Haiyue Wang Thanks for the review, it's included. -corey 在 2018-11-27 21:36, Corey

Re: [Openipmi-developer] [PATCH] ipmi: kcs_bmc: handle devm_kasprintf() failure case

2018-11-27 Thread Wang, Haiyue
[Resend for wrong reply HTML format mail] Great check for making kcs_bmc module be more stable and handle things gracefully. My tag if needed. Reviewed-by: Haiyue Wang 在 2018-11-27 21:36, Corey Minyard 写道: On 11/21/18 9:08 AM, Nicholas Mc Guire wrote: devm_kasprintf() may return NULL

Re: [Openipmi-developer] [PATCH] ipmi: kcs_bmc: handle devm_kasprintf() failure case

2018-11-27 Thread Wang, Haiyue
Great check for making kcs_bmc module be more stable and handle things gracefully. My tag if needed. Reviewed-by: Haiyue Wang 在 2018-11-27 21:36, Corey Minyard 写道: On 11/21/18 9:08 AM, Nicholas Mc Guire wrote: devm_kasprintf() may return NULL if internal allocation failed so this

Re: [Openipmi-developer] [PATCH] ipmi: kcs_bmc: handle devm_kasprintf() failure case

2018-11-27 Thread Corey Minyard
On 11/21/18 9:08 AM, Nicholas Mc Guire wrote: devm_kasprintf() may return NULL if internal allocation failed so this assignment is not safe. Moved the error exit path and added the !NULL which then allows the devres manager to take care of cleanup. Added the original author.  This looks

[Openipmi-developer] [PATCH] ipmi: kcs_bmc: handle devm_kasprintf() failure case

2018-11-21 Thread Nicholas Mc Guire
devm_kasprintf() may return NULL if internal allocation failed so this assignment is not safe. Moved the error exit path and added the !NULL which then allows the devres manager to take care of cleanup. Signed-off-by: Nicholas Mc Guire Fixes: cd2315d471f4 ("ipmi: kcs_bmc: don't change device