Lots of char arrays could be set as const since they contain only literal
char arrays.
We could in the same time make const some struct members who are pointer
to those const char arrays.
Signed-off-by: LABBE Corentin
---
drivers/char/ipmi/ipmi_msghandler.c | 7 ---
drivers/char/ipmi
Lots of char arrays could be set as const since they contain only literal
char arrays.
We could in the same time make const some struct members who are pointer
to those const char arrays.
Signed-off-by: LABBE Corentin
---
drivers/char/ipmi/ipmi_msghandler.c | 7 ---
drivers/char/ipmi
This patch replace all printk(KERN_XXX) by their pr_xxx counterparts.
This will also permit to remove some line wrapping.
Signed-off-by: LABBE Corentin
---
drivers/char/ipmi/ipmi_si_intf.c | 91 +---
1 file changed, 39 insertions(+), 52 deletions(-)
diff
The simple_strtoul function is marked as obsolete.
This patch replace it by kstrtoint/kstrtoul.
This will simplify code, since some error case not handled by
simple_strtoul are handled by kstrtox.
Signed-off-by: LABBE Corentin
---
drivers/char/ipmi/ipmi_si_intf.c | 15 ---
drivers
The name parameter of ipmi_smi_add_proc_entry() is never modified.
Furthermore, the name parameter of ipmi_smi_add_proc_entry is always given
string literal.
Signed-off-by: LABBE Corentin
---
drivers/char/ipmi/ipmi_msghandler.c | 2 +-
include/linux/ipmi_smi.h| 2 +-
2 files changed
Both start_error_recovery() function are different but they didn't
modify the reason parameter.
Furthermore, the reason parameter is always given string literal.
Signed-off-by: LABBE Corentin
---
drivers/char/ipmi/ipmi_kcs_sm.c | 2 +-
drivers/char/ipmi/ipmi_smic_sm.c | 2 +-
2 files ch
This patch replace all printk(KERN_XXX) by their pr_xxx counterparts.
This will also permit to remove some line wrapping.
Signed-off-by: LABBE Corentin
---
drivers/char/ipmi/ipmi_si_intf.c | 91 +---
1 file changed, 39 insertions(+), 52 deletions(-)
diff
Hello
I have some minor comment below:
On Fri, Sep 16, 2016 at 12:39:25PM +0200, Cédric Le Goater wrote:
> From: Alistair Popple
>
> This patch adds a simple device driver to expose the iBT interface on
> Aspeed SOCs (AST2400 and AST2500) as a character device. Such SOCs are
> commonly used as