Re: [9] Review request for FX Jigsaw changes

2016-03-18 Thread Kevin Rushforth
It is transitional, and will be eliminated later once we are able to use a Jigsaw-enabled JDK 9 as our boot JDK> -- Kevin Alan Bateman wrote: On 17/03/2016 03:04, Kevin Rushforth wrote: I should add that the only changes are related to: 1) Renamed JDK9_HOME to JIGSAW_HOME Is this for trans

Re: [9] Review request for FX Jigsaw changes

2016-03-18 Thread Alan Bateman
On 17/03/2016 03:04, Kevin Rushforth wrote: I should add that the only changes are related to: 1) Renamed JDK9_HOME to JIGSAW_HOME Is this for transition purposes and it would revert again to JDK9_HOME later? -Alan

FX-9: strange (?) factory pattern in BehaviorBase:

2016-03-18 Thread fastegal
The implementation of creating/accessing its inputMap looks strange to me: // no field // abstract getter protected abstract InputMap getInputMap(); // implemented factory method protected InputMap createInputMap() { return new InputMap(getNode()); } Now all subclasses (need to) contain

In(Sanity) Testing Mondays

2016-03-18 Thread Vadim Pakhnushev
Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PST until 1pm PST. Happy testing! Thanks, Vadim