[9] Code Review Request For 8157295: Encapsulate impl_ methods in Scene and KeyValue classes

Hi Jonathan and Kevin, Please review the proposed fix: Webrev: https://bugs.openjdk.java.net/browse/JDK-8157295 JIRA: http://cr.openjdk.java.net/~ckyang/JDK-8157295/webrev.00/ Thanks, - Chien

review: remove use of GetPropertyAction

Kevin, https://bugs.openjdk.java.net/browse/JDK-8157280 webrev: http://cr.openjdk.java.net/~ddhill/8157280 -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey

Re: [9] Review request for 8157213: HiDPI support for Linux creates unnecessary dependency

New updated webrevs with the new default value at: http://cr.openjdk.java.net/~flar/JDK-8157213/webrev-01/ I also found a way to remove the schema from the Gentoo LiveCD environment and tested that way as well... ...jim On 5/18/16 1:28 PM, Erik De Rijcke wrote: Yes

Re: [9] Review request for 8157213: HiDPI support for Linux creates unnecessary dependency

Yes that seems to fix it. On Wed, May 18, 2016 at 9:55 PM, Jim Graham wrote: > Ah, this is probably me returning a -1 as an uint. If you change the > "defval" used (line 167) in the call to query the property from -1 to 0 > does it work as intended? > >

Re: Support for GTK 2 & 3 now in JFX

Hi, I tried using the gtk3 broadway backend. This results in a segfault. Current thread (0x7fe8cc0c2000): JavaThread "GtkNativeMainLoopThread" [_thread_in_native, id=21171, stack(0x7fe8abcad000,0x7fe8abdae000)] Stack: [0x7fe8abcad000,0x7fe8abdae000], sp=0x7fe8abdac1c0,

Re: [9] Review request for 8157213: HiDPI support for Linux creates unnecessary dependency

Ah, this is probably me returning a -1 as an uint. If you change the "defval" used (line 167) in the call to query the property from -1 to 0 does it work as intended? ...jim On 5/18/16 11:59 AM, Erik De Rijcke wrote: I tested the patch. Without the dependency I get a

Re: [9] Review request for 8157213: HiDPI support for Linux creates unnecessary dependency

I tested the patch. Without the dependency I get a an enormous stage (I explicitly set it to be 100x100). Debugging shows me the screen is initialized with these values: Screen: ptr:0 adapter:0 depth:24 x:0 y:0 width:0 height:0 platformX:0 platformY:0