[9] Code Review Request For 8154148: JavaFX crashes on startup when run on Mac in VMWare

Hi Kevin and Dave, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8154148 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8154148/webrev.00/ Thanks, - Chien

Re: [PATCH] 8160325: Provide a public API to obtain the FXCanvas for an embedded scene.

Hi Kevin, attached please find a revised patch. My comments are inlined. > Am 28.07.2016 um 18:03 schrieb Kevin Rushforth : > > Hi > > Alexander Nyssen wrote: >> >> Hi, >> >> I have added my comments below: >> >> >>> Am 28.07.2016 um 17:22 schrieb Kevin Rushforth >>

Re: JDK-8153350 - JavaFX webstart with javaws.exe selects wrong toolkit (unnecessary relaunch)

>> it may be unrelated to these relaunches, but I have been wondering for >> awhile, what the toolkit parameter in the ant element is >> supposed to do. >> >> see: >> >> https://docs.oracle.com/javase/8/docs/technotes/guides/deploy/javafx_ant_task_reference.html#CIAGCAFH >> >> At least in my

Re: [PATCH] 8160325: Provide a public API to obtain the FXCanvas for an embedded scene.

Hi Alexander Nyssen wrote: Hi, I have added my comments below: Am 28.07.2016 um 17:22 schrieb Kevin Rushforth mailto:kevin.rushfo...@oracle.com>>: I got the attachment, since Alexander also CCed me directly. I will attach it shortly. Thanks! Done. I do have two comments on this: 1)

Re: [PATCH] 8160325: Provide a public API to obtain the FXCanvas for an embedded scene.

Hi, I have added my comments below: > Am 28.07.2016 um 17:22 schrieb Kevin Rushforth : > > I got the attachment, since Alexander also CCed me directly. I will attach it > shortly. Thanks! > > I do have two comments on this: > > 1) We are past Feature Freeze, so all Enhancements need formal

Re: [PATCH] 8160325: Provide a public API to obtain the FXCanvas for an embedded scene.

I got the attachment, since Alexander also CCed me directly. I will attach it shortly. I do have two comments on this: 1) We are past Feature Freeze, so all Enhancements need formal JDK 9 R-team approval [1][2]. In this case, the justification can be internal API that is no longer accessible

Re: [PATCH] 8160325: Provide a public API to obtain the FXCanvas for an embedded scene.

The mailing list rejects attachments so we got nothing. -phil. On 7/28/2016 8:06 AM, Alexander Nyssen wrote: Hi Kevin, all, attached please find a patch that fixes JDK-8160325. The patch comprises the following changes: - Provided static FXCanvas#getFXCanvas(Scene) method to obtain the FXCan

[PATCH] 8160325: Provide a public API to obtain the FXCanvas for an embedded scene.

Hi Kevin, all, attached please find a patch that fixes JDK-8160325. The patch comprises the following changes: - Provided static FXCanvas#getFXCanvas(Scene) method to obtain the FXCanvas instance embedding the given Scene instance. - Added EmbeddedWindow.getHost() so the HostInterface can be re