Re: [PATCH] 8160325: Provide a public API to obtain the FXCanvas for an embedded scene.

2016-08-08 Thread Kevin Rushforth
I uploaded the patch, reviewed it, and provided comments in the bug report. The short version is: * The new API looks good * There is a missing '@since 9' in the javadoc comments along with a few typos / style issues * Rather than using reflection and setAccessible in the implementation,

[9, 8u] Review request: 8159726: Cleanup whitespace and file permission in tests repo

2016-08-08 Thread Kevin Rushforth
Andrey, Please review the following white-space-only change: https://bugs.openjdk.java.net/browse/JDK-8159726 http://cr.openjdk.java.net/~kcr/8159726/webrev-9.01/ With this change the openjfx tests repo in both 8u and 9 will be jcheck compliant. Thanks. -- Kevin

[9] Review request: 8163183: [test] Correct assertEquals ("", actual, expected) in LoadTest.loadJarFile

2016-08-08 Thread Guru Hb
Hi Kevin & Arun, Please review the fix for JBS : https://bugs.openjdk.java.net/browse/JDK-8163183 Webrev : http://cr.openjdk.java.net/~ghb/8163183/webrev.00/ Thanks, Guru