[9] Review request: JDK-8172216: Remove unused, obsolete iOS code

2017-01-04 Thread Kevin Rushforth
Hi, Please review the following simple cleanup fix: https://bugs.openjdk.java.net/browse/JDK-8172216 http://cr.openjdk.java.net/~kcr/8172216/webrev.00/ Thanks. -- Kevin

Review: create a run.java.policy file

2017-01-04 Thread David Hill
Kevin, if you could review: https://bugs.openjdk.java.net/browse/JDK-8172243 webrev: http://cr.openjdk.java.net/~ddhill/8172243 thanks, Dave -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his

Re: Question/discussion about JDK-8129582

2017-01-04 Thread Phil Race
You can't skip layout just because it is bidi .. where here you are apparently implicitly meaning Hebrew. This might be apparently working but may not always work even for Hebrew and will be a disaster for Arabic. Here is a web page which talks about OTL (OpenType Layout) for Hebrew : https://www

Re: Question/discussion about JDK-8129582

2017-01-04 Thread Itai
Some quick-and-dirty thing I hacked now and seems to improve the performance drastically is something like: if (complex but not bidi) { use GlyphLayout. } else if (bidi) { use java.text.Bidi.reorderVisually to get visual glyph order, then use same implementation as non-bidi non-complex layou

Re: Question/discussion about JDK-8129582

2017-01-04 Thread Itai
Thanks for replying. I think I understand what you're saying about the cache. As for complexity - I'm mostly working with text which is only in Hebrew, which isn't complex as far as I understand the definition (no glyph "fusing" as in Arabic or Farsi). I can work with minor performance drops, but w

Re: Question/discussion about JDK-8129582

2017-01-04 Thread Philip Race
The cache is a heuristic optimisation and whether it helps depends on how well that cache is used. It is a time-space trade-off and I'd expect it to show up as helping more in micro-benchmarks or text-intensive benchmarks which use the same text broken in the same way. Complex text layout is inh

Question/discussion about JDK-8129582

2017-01-04 Thread Itai
Recently JDK-8129582 [1] started really affecting me, with startup speed and overall responsiveness becoming really bad. Digging into it, I have found most time is wasted in com.sun.javafx.text.GlyphLayout.layout (as represented by PangoGlyphLayout on my Linux machine), which in turn is called by

Result: New OpenJFX Committer: Victor Drozdov

2017-01-04 Thread Chris Bensen
Voting for Victor Drozdov [1] to OpenJFX Committer [2] is now closed. Yes: 7 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. Chris [1] http://openjdk.java.net/census#vdrozdov [2]

Correct warning in linux build

2017-01-04 Thread David Hill
Chris, Kevin, Please review the fix for a problem that Chris stumbled on. The one line diff is in the JBS. This will teach me to test the side branches when I change the logging level :-) (actually, I think I switched from a print) https://bugs.openjdk.java.net/browse/JDK-8172219 -- David