[Review request] 8171983: Add javadoc comments to module-info.java for javafx.* modules

2017-01-08 Thread Jonathan Giles
Kevin, Please review the webrev for adding module-level javadoc comments to all JavaFX modules defined in JDK 9: https://bugs.openjdk.java.net/browse/JDK-8171983 http://cr.openjdk.java.net/~jgiles/8171983/index.html Thanks, -- Jonathan

Re: Question/discussion about JDK-8129582

2017-01-08 Thread Itai
I think I have found two problems. The first, and probably most critical one, is that a new PangoFontMap is created for every call of PangoGlyphLayout#layout. It is not entirely clear from the Pango documentation what the lifetime or intended usage of a PangoFontMap is, but I have found this commen

Re: Question/discussion about JDK-8129582

2017-01-08 Thread Itai
Thank you for the link, it's an interesting read indeed! I wasn't really skipping layout, just using the much simpler layout used by Latin scripts, but you are correct that this will break for anything more complex - this has nothing to do with BiDi though, more to do with complex layout elements