[9] Review request for 8170630: [MacOSX] Media crash NSInvalidArgumentException playing some video

Hi David, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8170630 Fixed crash by checking value for NSNull. Thanks, Alexander

[9] Review request: 8155687: Legacy sample jar fails in launch

Dave D and Dave H, Please review the following fix for launching legacy jar files: https://bugs.openjdk.java.net/browse/JDK-8155687 http://cr.openjdk.java.net/~kcr/8155687/webrev.00/ Most of the changes are to implement a new unit test. The fix itself is simple. -- Kevin

Code Review Request 8172364: Ensemble8 Canvas Fireworks jitters while animating

Hi Kevin, Please review the proposed fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8172364 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8172364/webrev.00/ Thanks, - Chien

review: fix developer script compareBuilds to properly support windows

https://bugs.openjdk.java.net/browse/JDK-8173779 webrev: http://cr.openjdk.java.net/~ddhill/8173779 -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

[9] Review request: 8173774 Update script and icon

Victor, Please review these minor changes to the AppStore version number and icons for submitting to the Mac AppStore. JIRA: https://bugs.openjdk.java.net/browse/JDK-8173774 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8173774/webrev.02/

[9] Review request: 8173768: gradle -PBUILD_SDK_FOR_TEST=false fails accessing a non-existent property

Please review the following fix to allow "gradle -PBUILD_SDK_FOR_TEST=false" to work again: https://bugs.openjdk.java.net/browse/JDK-8173768 The patch is in the bug report. -- Kevin

[9] Review request: 8173661 Fix ALL-MODULE-PATH

Victor, Please review this change to the addModules. ALL-MODULE-PATH now works with this change but it is subtle and we need to make sure it doesn’t break anything. JIRA: https://bugs.openjdk.java.net/browse/JDK-8173661 Webrev: http://cr.openjd

review: correct build.gradle buildVersionFile

Kevin, Chris, this seems to fix and issue where version.properties may or may not be in ant-javafx.jar https://bugs.openjdk.java.net/browse/JDK-8173767 webrev: http://cr.openjdk.java.net/~ddhill/8173767/ -- David Hill Java Embedded Development

Re: [9] Review request : JDK-8089875 : MenuBarSkin does not update if a menu changes its visibility.

As a reminder we are not fixing P4 bugs at this phase of the JDK 9 release [1], except for test and doc bugs. We can consider this bug fix for JDK 10 once we open an FX 10 repo (more on the time of this will be forthcoming). -- Kevin [1] http://openjdk.java.net/projects/jdk9/rdp-1 Ajit Ghai