Re: [9] Review request: 8173080: Add licenses for non-distributed third-party source code in repo

2017-04-05 Thread Mandy Chung
> On Apr 5, 2017, at 3:51 PM, Kevin Rushforth > wrote: > > Dave, > > Please review the following fix to add missing .md license files for > non-distributed third-party source code in our repo: > > https://bugs.openjdk.java.net/browse/JDK-8173080 >

[9] Review request: 8173080: Add licenses for non-distributed third-party source code in repo

2017-04-05 Thread Kevin Rushforth
Dave, Please review the following fix to add missing .md license files for non-distributed third-party source code in our repo: https://bugs.openjdk.java.net/browse/JDK-8173080 http://cr.openjdk.java.net/~kcr/8173080/webrev.00/ -- Kevin

[9] Review request: 8169555: Need unit tests for JDK-8169289

2017-04-05 Thread Kevin Rushforth
Dave and Dave, Please review: https://bugs.openjdk.java.net/browse/JDK-8169555 http://cr.openjdk.java.net/~kcr/8169555/webrev.00/ This adds three new unit tests for verifying that we can launch modular FX applications. -- Kevin

Re: [10] Review request for 8176844: Menus not always selected properly with GTK 3

2017-04-05 Thread Semyon Sadetsky
On 04/05/2017 11:23 AM, David Hill wrote: On 4/5/17, 12:52 PM, Semyon Sadetsky wrote: Okay. Thank you to you all! The root cause why we need to add sync is a new way to grab/ungrab focus used in the GTK3 glass implementation. The GTK2 way to grab/ungrab is still applicable in GTK3 though

Re: [10] Review request for 8176844: Menus not always selected properly with GTK 3

2017-04-05 Thread David Hill
On 4/5/17, 12:52 PM, Semyon Sadetsky wrote: Okay. Thank you to you all! The root cause why we need to add sync is a new way to grab/ungrab focus used in the GTK3 glass implementation. The GTK2 way to grab/ungrab is still applicable in GTK3 though it is deprecated. But the used GTK3

Re: [10] Review request for 8176844: Menus not always selected properly with GTK 3

2017-04-05 Thread Semyon Sadetsky
Okay. Thank you to you all! The root cause why we need to add sync is a new way to grab/ungrab focus used in the GTK3 glass implementation. The GTK2 way to grab/ungrab is still applicable in GTK3 though it is deprecated. But the used GTK3 grab/ungrab is deprecated as well since version 3.20