Uploaded here:
http://cr.openjdk.java.net/~kcr/8194871/webrev.01/
This looks good.
+1
I'll push it tomorrow.
-- Kevin
Nir Lisker wrote:
Attached a new webrev.
On Thu, Jan 11, 2018 at 2:27 AM, Kevin Rushforth
> wrote:
Since we are talking about the layout bounds of a node, I would avoid
using the term '3D scene' (or subscene) since in this case it is the
node that has the characteristic of 3D (geometry or transforms)
associated with it.
Anyway, let's go with the note at the end somewhere. Since layout is a
Yes, I initially had it as a note in the end saying something like this:
Note that for nodes in a 3D Scene (or SubScene), layoutBounds is
cuboid.
but thought that for someone working with 3D, seeing a 2D discussion all
the way until the end will be confusing. (Also thought about putting a
The changes look good to me for the most part. I only have one comment.
Node.java:
- * The rectangular bounds that should be used for layout ...
+ * The rectangular (cuboid for 3D nodes) bounds that should be used
for layout ...
While technically correct, in that the layout bounds of
I just removed the trailing whitespace (using the handy
tools/scripts/checkWhiteSpace script with the '-F' option).
-- Kevin
Nir Lisker wrote:
Thanks,
modules/javafx.controls/src/main/java/javafx/scene/control/TableView.java:209:
Trailing whitespace
That one is an empty line
Thanks,
> modules/javafx.controls/src/main/java/javafx/scene/control/TableView.java:209:
> Trailing whitespace
That one is an empty line inside a code block, if it matters.
On Thu, Jan 11, 2018 at 12:14 AM, Kevin Rushforth <
kevin.rushfo...@oracle.com> wrote:
> > I'll review it, and sponsor
> I'll review it, and sponsor the change. Since I will be pushing it, I
will need one more reviewer.
Actually, this is incorrect. As long as I list you as contributor,
jcheck is perfectly happy with just me as reviewer.
If anyone else wants to review it, too, that would be fine, but not
Thank you for providing the patch. I uploaded it to cr.openjdk.java.net
for easy browsing:
http://cr.openjdk.java.net/~kcr/8194871/webrev.00/
I'll review it, and sponsor the change. Since I will be pushing it, I
will need one more reviewer.
My quick sanity checking shows trailing whitespace
Hi Kevin,
Please review the attached webrev.
I addressed a few fixes I found as I was working, so they are not listed in
the JIRA report.
About Transition#getParentTargetNode:
The current behavior of parent-child relationship is that an animation can
be added to multiple parent transitions.
Voting for Laurent Bourgès [1] to OpenJFX Committer [2] is now closed.
Yes: 8
Veto: 0
Abstain: 0
According to the Bylaws definition of Lazy Consensus, this is sufficient
to approve the nomination.
-- Kevin
[1] http://openjdk.java.net/census#lbourges
[2]
Hi,
Please review the below simple fix.
JIRA: https://bugs.openjdk.java.net/browse/JDK-8193368
Webrev: http://cr.openjdk.java.net/~mbilla/8193368/webrev.00/
Thanks,
Murali
The bug has now been moved to the JDK project, so the ID has changed to
8194871.
https://bugs.openjdk.java.net/browse/JDK-8194871
I'll upload your webrev once you send it.
Thanks.
-- Kevin
Nir Lisker wrote:
Submitted a new bug with ID: 9052190.
On Tue, Jan 9, 2018 at 10:51 PM, Kevin
12 matches
Mail list logo