Re: Repositories, AdoptOpenJDK and github

2018-02-15 Thread Kevin Rushforth
Johan Vos wrote: On Thu, Feb 15, 2018 at 4:09 AM Kevin Rushforth mailto:kevin.rushfo...@oracle.com>> wrote: A global reference in JBS would indeed be very good to track back the work in a PR to a real issue. It can also be very useful as there are many existing issues in JBS that can be

[11] Review Request - JDK-8196802: 3D unit tests listed as pass although they are actually skipped

2018-02-15 Thread Rajath Kamath
Hi Kevin, Murali, Please review this fix for skipping tests those are not run(because of missing feature support), instead of incorrectly listing as pass. JBS : https://bugs.openjdk.java.net/browse/JDK-8196802 WebRev : http://cr.openjdk.java.net/~rkamath/8196802/webrev.01/ Thanks, Rajath

Re: [11] Review request : JDK-8195806 : Eliminate dependency on sun.font.lookup in javafx.graphics

2018-02-15 Thread Phil Race
This part is probably as good as you can do + return System.getProperty("java.home","") + File.separator + + "lib" + File.separator + "fonts"; but if we want to support running against OpenJDK which does not have Lucida Sans then we need to look at the caller of getJDKFontDir() So going forw

Re: Additional info on JDK-8197536: TableView, ListView: unexpected scrolling behaviour on up/down keys

2018-02-15 Thread fastegal
Seems to have happened right at the start of moving VirtualFlow into public scope (which included lots changes to the implementation plus some refactoring, codereader's brain cells need to be kept alert ;) see my comment at https://bugs.openjdk.java.net/browse/JDK-8197536 Zitat von Nir Liske

Re: Repositories, AdoptOpenJDK and github

2018-02-15 Thread Johan Vos
On Thu, Feb 15, 2018 at 4:09 AM Kevin Rushforth wrote: > > As I said before, we need to be careful where the discussion is made. PRs > on GitHub have their own thread and there's also the mailing list. Maybe > someone from Oracle already has done work related to the PR, and this will > only be kn