Re: Proposal For Inclusion of Robot and ParametersImpl in the Public API

2018-03-22 Thread Michael Ennen
Got it. Not sure why I made it so complicated in my head, lol. Will be working on this in the next few days. On Thu, Mar 22, 2018 at 5:54 AM, Kevin Rushforth wrote: > > > Michael Ennen wrote: > > Quick question: > > Currently a Robot is created by calling

Re: Proposal For Inclusion of Robot and ParametersImpl in the Public API

2018-03-22 Thread Kevin Rushforth
Michael Ennen wrote: Quick question: Currently a Robot is created by calling `Application.createRobot` which delegates to the underlying platform-specific application class (GtkApplication, WinApplication, etc.) via `com.sun.glass.ui.Application.GetApplication().createRobot();` I just

Re: Proposal For Inclusion of Robot and ParametersImpl in the Public API

2018-03-22 Thread Michael Ennen
I should have been more clear in my previous message. I am creating the Robot thusly: javafx.scene.robot.Robot constructor (public API so JavaFX users can simply instantiate one): public Robot() { // Ensure we have proper permission for creating a robot. final SecurityManager

Re: Proposal For Inclusion of Robot and ParametersImpl in the Public API

2018-03-22 Thread Nir Lisker
Hi Michael, About the public API, I agree with Kevin that the following methods are redundant: - mousePress(MouseButton button) - mouseRelease(MouseButton button); - mouseWheel(int wheelAmt, VerticalDirection direction) About the implementation of getScreenCapture, isn't that conflicting with

Re: Proposal For Inclusion of Robot and ParametersImpl in the Public API

2018-03-22 Thread Michael Ennen
Quick question: Currently a Robot is created by calling `Application.createRobot` which delegates to the underlying platform-specific application class (GtkApplication, WinApplication, etc.) via `com.sun.glass.ui.Application.GetApplication().createRobot();` You suggest moving this to the